From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751741AbdBJXiN (ORCPT ); Fri, 10 Feb 2017 18:38:13 -0500 Received: from mail-io0-f177.google.com ([209.85.223.177]:33996 "EHLO mail-io0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751040AbdBJXiL (ORCPT ); Fri, 10 Feb 2017 18:38:11 -0500 MIME-Version: 1.0 In-Reply-To: <20170209131625.GA16954@pjb1027-Latitude-E5410> References: <20170209131625.GA16954@pjb1027-Latitude-E5410> From: Kees Cook Date: Fri, 10 Feb 2017 15:36:37 -0800 X-Google-Sender-Auth: SWY0NLMaJ0Nep86VJxAPSAKbmmQ Message-ID: Subject: Re: [PATCH] mm: testcases for RODATA: fix config dependency To: Jinbum Park , Andrew Morton Cc: Valentin Rothberg , Linux-MM , LKML , Laura Abbott Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 9, 2017 at 5:16 AM, Jinbum Park wrote: > Since DEBUG_RODATA has renamed to STRICT_KERNEL_RWX, > Fix the config dependency. > > Reported-by: Valentin Rothberg > Signed-off-by: Jinbum Park > --- > mm/Kconfig.debug | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug > index 3e5eada..3c88b7e 100644 > --- a/mm/Kconfig.debug > +++ b/mm/Kconfig.debug > @@ -93,7 +93,7 @@ config DEBUG_PAGE_REF > > config DEBUG_RODATA_TEST > bool "Testcase for the marking rodata read-only" > - depends on DEBUG_RODATA > + depends on STRICT_KERNEL_RWX > ---help--- > This option enables a testcase for the setting rodata read-only. Great, thanks! Acked-by: Kees Cook Andrew, do you want to take this patch, since it applies on top of "mm: add arch-independent testcases for RODATA", or do you want me to take both patches into my KSPP tree which has the DEBUG_RODATA -> STRICT_KERNEL_RWX renaming series? -Kees -- Kees Cook Pixel Security