From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC4C3397E97 for ; Mon, 23 Mar 2026 11:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.167.41 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774266091; cv=pass; b=UDJpaiX5L6rvzEz6N98Tl0WA2jgJz/7TllsZvQWDhGhmQTZlzkDpfvTMg/lX3Clm+elmdvpN7/mfhS+6KSyK86JrAKoo0acJP0awmCNecMsp4YqHUkkjvvvdMhQlRko3DUUlmppDP/+z+By7fesn6v/0ixLjKTXhV4OMMZF164Y= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774266091; c=relaxed/simple; bh=sj6ktFY8rGvb7MnpkIOBpJYVELEIasXN0XLZjKqtYbs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=uuRDGM3pJ44LeC04Jxjx0uvD8YPeFhIzeIm9GsCwnd+6w+do8WJsOFwhwbE1Z6OKvLYpI64QQIc+joqVVCO841vDUxGSLHJjjvfl8D3hfHlOEXB0KapZL+6f/CMryw2Qafdj5AdDvkvWt0ugzSAdHtOK8XOOgFB1p7NFxB+yIYA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=SZnvIsLK; arc=pass smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="SZnvIsLK" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5a281b091c2so21347e87.0 for ; Mon, 23 Mar 2026 04:41:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774266088; cv=none; d=google.com; s=arc-20240605; b=TJe4GahplgKCZmTZN+RpHLW/z3D6OHVWW+JTjvh9+oCIXwaXEMuxvIurbCPf1hVz6n 50GcKWI9Bckjkrh75rHxOZDI68Xm59JzCHn8RHlarTaKoiEqCYafMiY9Hp41WINwgjXN /KXHva4ZxPP+aPzsnQoO7J6A0h1WLuG3iRqD1ZDB1zvUn3uFsYUdBfoSwNCu00E06PPN gBAjVCDLBLl+fMRQTra2/Kd9P1ks6SJF3G6OQ0zCvBId253D2xziXEhOeYDN3QDeJ2m2 rO5953NnDY3vYAUn7QQLwIWpjvojAFoBRXYdXhcAdNPZDGefTLLAC776tLzBpbcMv1Wo aBXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=6qaas9JqtGbwzhDv8dAGHkzZXIP7w+k14X0YonK0wTQ=; fh=x4nH/7O+dZ9ufPBqdHtAc8q2Jg9Hp3ArelWvz5kYMG4=; b=Ma6WRTlfSwwiMnWpotYeJsopJcumq4qncmr1GL/U9Lysr0846XsGHLtlMQM4wIv1El SjOFbcJ0gDui3eQ1QF0nIKF8i7vxWrRhL8qtSiKhHpOLg8mBowm6KmHD+gD7xvxaKV3Y bJQUWPRmOih2U3frKmu5zjPTvkyI83mNzfKt+2GusKT7lWBFivihd8BYojZVLEtsgy2L DMZb+tb++PPJ3GWaSOpdw8FVIR1TgQ550uZZOAcrFzYnWoZoMmlfLR8IWeL7+cm+yXge qHnACd/ecf7E5GgAHmz+G9tT41IoqeaoB7PEcagAfWVhLiKETIdhsznRNElxMfahJOzG X3ow==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1774266088; x=1774870888; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6qaas9JqtGbwzhDv8dAGHkzZXIP7w+k14X0YonK0wTQ=; b=SZnvIsLKjlDsITdy+9Hpf5OGiZO8ocA+u9mW9RApNLDLYDUt5k/s8PoFG8+DEkER2D fu438svTBxlS1YFQseg0tz4L1pPsYS9hVzfs3EGV+XKSuRweeQ+wLikzlHBKYe9rlrKm riu+FL/FdhkifHv/pcnE2qLmd/k0iwehYMIcc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774266088; x=1774870888; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6qaas9JqtGbwzhDv8dAGHkzZXIP7w+k14X0YonK0wTQ=; b=LOT3Gj6Wcj1LrfXsNc8/8bjuwzNGCZ3rPyrHLC43ewjLZonURKE08S+wSGL4bk79jD C3riTIDuXvc/rn3FOROWU840wvOXcxCl7hu4Zb/n2sGKOGTems2ojRaplvN6D/1vRxq3 grMCLBQiYb5BJkS9ruKUEkPv2+8ZqMs0XtXIvrF/ZJGlev8UQyPVwtkfFWsX3hxiauOJ FSLUcyi7krs0dnNFxVPCEWB1U24yLf+xQsLFxVzKo6Z/EBVpJ9x2/SJUtnwGxMfeQOXA TGO2LERhMBIJRcMSMQzFRBiBtZIwQbkNt1wHrO7Zfh3FW7Rd7fFBYSoCpmr9qI2PqVS5 p27A== X-Forwarded-Encrypted: i=1; AJvYcCV7IJ3OkXF9WOYQ5Kt3CVYBxjdKd7RzEVqMggPJV8XS4paPs3EMyKlnQuLx4BYfAqRR/5isB0b+V7MaWqc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywr5LdJnsL698WdtdZVxn0LfQD1aFBvh+Nbqs3oBT3cyRXNdnW6 B+rUQMnTSKNcZ1jtGF5KDrWH/rzNruZV2UcnGiigaLJXSHa9XIlD8rCfAh+PjN6f+xBndEVGD1k hazdWnKV7FZlkQRj/4XxuzVav3rU8XfzaXw276daT X-Gm-Gg: ATEYQzygAMs68Bn9c1GRqLC6vM4MhKiQRCRg4Be6GknYzZgVXCrEOV7oyx+f3idY+tG NVdemeHLTsaIdn1vHu7PGIKGg6VwJFAJldjKv8r7o7b7U84kDRccSsytfF04JOgq0W17CZ+Tc4M exMtgyKydjy8GwaIXMnLb9guDRzGr6ezZ0Nlla5sxAJQAmdjZE2jzQyimrA1j0Wi5K58o5b4PV/ kW4UAqXOG4QWV/ovj1EUKiVZs7/x/XMX/EjR33NImOydOJf7BPEZU55qZGWXHa1ywL3hzwnLeTl N3Qg73D50mWIMs1mG8vP0vERD3Be/zCif9NATw== X-Received: by 2002:a05:6512:318d:b0:5a1:3437:84ac with SMTP id 2adb3069b0e04-5a285b876c9mr4805460e87.31.1774266087955; Mon, 23 Mar 2026 04:41:27 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260226092234.3859740-1-wenst@chromium.org> In-Reply-To: From: Chen-Yu Tsai Date: Mon, 23 Mar 2026 19:41:17 +0800 X-Gm-Features: AQROBzDDC_YsgLPutSPicNkJG8O9a13GIhwfkf2HoJ_f9zwoBBGyNxuho0ax_ek Message-ID: Subject: Re: [PATCH v2] PCI/pwrctrl: Do not power off on pwrctrl device removal To: Manivannan Sadhasivam , Bjorn Helgaas Cc: Bartosz Golaszewski , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ping? What's going on with this patch? The slot driver got renamed and this fix is still not merged. On Thu, Feb 26, 2026 at 5:30=E2=80=AFPM Manivannan Sadhasivam wrote: > > On Thu, Feb 26, 2026 at 05:22:33PM +0800, Chen-Yu Tsai wrote: > > With the move to explicit pwrctrl power on/off APIs, the caller, i.e. > > the PCI driver should manage the power state. The pwrctrl drivers shoul= d > > not try to clean up or power off when they are removed, as this might > > end up disabling an already disabled regulator, causing a big warning. > > This can be triggered if a PCI controller driver's .remove() callback > > calls pci_pwrctrl_destroy_devices() after pci_pwrctrl_power_off_devices= (). > > > > Drop the devm cleanup parts that turn off regulators from the pwrctrl > > drivers. > > > > Fixes: b921aa3f8dec ("PCI/pwrctrl: Switch to pwrctrl create, power on/o= ff, destroy APIs") > > Cc: Manivannan Sadhasivam > > Signed-off-by: Chen-Yu Tsai > > Reviewed-by: Manivannan Sadhasivam > > - Mani > > > Reviewed-by: Bartosz Golaszewski > > > > --- > > Changes since v1: > > - Keep the release function for the PCI slot driver to free the > > regulators > > > > I ran into this while integrating the new pci_pwrctrl_*() API into the > > MediaTek driver. I am sending this separately since this change is > > unrelated and does not conflict with or depend on the other changes for > > the driver itself. > > > > I think this should be merged for fixes. > > > > --- > > drivers/pci/pwrctrl/pci-pwrctrl-pwrseq.c | 12 ------------ > > drivers/pci/pwrctrl/slot.c | 1 - > > 2 files changed, 13 deletions(-) > > > > diff --git a/drivers/pci/pwrctrl/pci-pwrctrl-pwrseq.c b/drivers/pci/pwr= ctrl/pci-pwrctrl-pwrseq.c > > index 0d0377283c37..c7e4beec160a 100644 > > --- a/drivers/pci/pwrctrl/pci-pwrctrl-pwrseq.c > > +++ b/drivers/pci/pwrctrl/pci-pwrctrl-pwrseq.c > > @@ -68,13 +68,6 @@ static int pwrseq_pwrctrl_power_off(struct pci_pwrct= rl *pwrctrl) > > return pwrseq_power_off(pwrseq->pwrseq); > > } > > > > -static void devm_pwrseq_pwrctrl_power_off(void *data) > > -{ > > - struct pwrseq_pwrctrl *pwrseq =3D data; > > - > > - pwrseq_pwrctrl_power_off(&pwrseq->pwrctrl); > > -} > > - > > static int pwrseq_pwrctrl_probe(struct platform_device *pdev) > > { > > const struct pwrseq_pwrctrl_pdata *pdata; > > @@ -101,11 +94,6 @@ static int pwrseq_pwrctrl_probe(struct platform_dev= ice *pdev) > > return dev_err_probe(dev, PTR_ERR(pwrseq->pwrseq), > > "Failed to get the power sequencer\n= "); > > > > - ret =3D devm_add_action_or_reset(dev, devm_pwrseq_pwrctrl_power_o= ff, > > - pwrseq); > > - if (ret) > > - return ret; > > - > > pwrseq->pwrctrl.power_on =3D pwrseq_pwrctrl_power_on; > > pwrseq->pwrctrl.power_off =3D pwrseq_pwrctrl_power_off; > > > > diff --git a/drivers/pci/pwrctrl/slot.c b/drivers/pci/pwrctrl/slot.c > > index 082af81efe25..b87639253ae2 100644 > > --- a/drivers/pci/pwrctrl/slot.c > > +++ b/drivers/pci/pwrctrl/slot.c > > @@ -63,7 +63,6 @@ static void devm_slot_pwrctrl_release(void *data) > > { > > struct slot_pwrctrl *slot =3D data; > > > > - slot_pwrctrl_power_off(&slot->pwrctrl); > > regulator_bulk_free(slot->num_supplies, slot->supplies); > > } > > > > -- > > 2.53.0.414.gf7e9f6c205-goog > > > > -- > =E0=AE=AE=E0=AE=A3=E0=AE=BF=E0=AE=B5=E0=AE=A3=E0=AF=8D=E0=AE=A3=E0=AE=A9= =E0=AF=8D =E0=AE=9A=E0=AE=A4=E0=AE=BE=E0=AE=9A=E0=AE=BF=E0=AE=B5=E0=AE=AE= =E0=AF=8D