From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C88463F86F8 for ; Tue, 4 Aug 2026 02:43:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.128.175 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785811401; cv=pass; b=Gn5sQGd9PvKvY/giytzDDQJDhNMfrKgFq2TxBKNtyF1aZppgfFzevFLuurxGBA6bji3jyZ1Z+x78ZZ8uKlRnNZxQMR8iM+MF2+DLnSt+k4wYoBnfNrccz12JNIxOnrkoLYGidMorfKWo4YaVpQ3QPIjQ9hvjgPAFlkW/N7FTXQk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785811401; c=relaxed/simple; bh=YZKYb+GkPftg01Ou+o7yt15VY2iSSja29MKhp+0jynE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=sFE6HWv05J1hVyymlBWdtv6dooquUfJ3XiIOeW4ZBM+wq0i+C1lgnQDMNPiMYRrZUfbRaXYCOXMXRSS27vrDQLyiSpbzJPy4Pt4YzlgOMoSSNoNcEm4uvt2fns7d/RJxJClRUMMJmB5sf0FR4xyJevk1SF+PIAcT0xLjYI5rqKo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=jC8vkyGR; arc=pass smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jC8vkyGR" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-81ee6b2da98so49937607b3.3 for ; Mon, 03 Aug 2026 19:43:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1785811399; cv=none; d=google.com; s=arc-20260327; b=YmCwArxhBDzMMFnO1Xa+wzyjM0oJ1IBeOgxAcSqBuopNEYmMosOWZdWFONpsCgKh8T hp7dtamUUiKCI3OfDGQU67u7UCL3T5fV08zAmMgcyLNsTBiT6GFyvXXc2LK+BChiwKDC C5+pNK3wzKxIuxEk5L4aXdbOJZRxU2hM68XXX6Otc+vDFu4TR1rNC9KeFQDlbF9fiG5U +h8bUE36Z60MjWdvpMmA8FPI38FluvPSCOsccau5gqEKInC+ItS4xVbDsr8lWOXxtj4j WKgdrDCowca2cL681AR49fOK0F2hNBeOo7Dor8Pciks64Ius0GpCJKVm88ImdAG/fcEz /41w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=RF3fTD6VniiBpbG6B64SSlFMt6UnvATMppDDhdm47VI=; fh=J4JcUUsINVlKigNYPMzUUJttus6ZHFyWAiflvVUtEN0=; b=ocY0n0c/1CpmTcZN8P9Bs3+34L4nNj9cdWLEgt/3gVYQBMFHYM0BKhgobcJ+D0wUEd R+4cxQ55mXk0Y69D+IpU3os1uxNhgEsyyc7Zyv2PeD89XUtiyBFpdWv8eytH+5/y6aj4 Tfk1kZE9pUX/Nz8NNAfzet3XQcONci88yGkct7E7oxQVrbrApTUvQlKINhmIxHMl2ksf Sv99R6KsVHpfaMnDhBpISKah39QpFa8HUrtYLs5Z/86T/pi1yfQrWlr36/OHP9rJMGAc GJlkpBDBIUF+N3Uzx0Q+o/gpuEPKJLXIa6Mo7yNEOlnH5EOroHc3QP79ctgKhCacbMtq vptQ==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1785811399; x=1786416199; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=RF3fTD6VniiBpbG6B64SSlFMt6UnvATMppDDhdm47VI=; b=jC8vkyGRk/6dVnzI57mRjrGd4MqWLiArc7JTmqjqD6z0oiS0mwNucudqoCumJqjU6B yfCx7waIOJmSxiWu6GvOnURVX/TuBoZF/zv/89yb+OVs/IWg5BeyTcALp8iho/2z2Lwg k15bw1pWFm6RivINUFCPNnpZjG4nxfykdY+6s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785811399; x=1786416199; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RF3fTD6VniiBpbG6B64SSlFMt6UnvATMppDDhdm47VI=; b=Oj9hx4BgXLMvyGjOjbU4Lpp5SJVmHB8pilAzCIYjbGaV3a5JbVih7DlEIKepuZI7hB v9ZNetbQMnOe6l/UzN3ut1f8a3UgZPomew02dJY2JIoQPmsLWhWyqzEXrOwrDO2QHBDG BvBn2gE/vtqi0zEbC4wZwI7c6NOVSvT9Kss4tULbvk9AS+0BvSpJrlC5FXhVBNgEZeIK cICVM3r9mmBd4Ey7yH2Q5nScqGkSMVxxacP6h6YVsR6wG49n5NosdSK/Wmz+WNuYj1S4 4biHwB0aR9IZ0akDpm7iZL/wUCuc4h0rEnDHjrjq7w+H77Uzb9H1LwVnxdUbADzzGopV 6PTg== X-Forwarded-Encrypted: i=1; AHgh+RrQrrGYN9L5I9VGnJ0uQaWjz8toLSBO6lZ9nwbyONZ8/RXEz4twzfcRFsqWg1JA0qjKC55bEnGHfxIuK7Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3FS3Fszz5yLPB9yqdZSP2NMDJJfrj1qnVYDA2zNiCg0bnUI0o XnNtMaZ1ujw8t67ygVgkKf+8KeLP+AcnmMxAriW+8FBXJ+zpsUfMQVlGhS5l6LLgws4OZHEYaSA 4eWrD7SmumYG+etC4dPbijUWY51cEKICiwy7ebwfd X-Gm-Gg: AR+sD13pgQachUhjG1EQ7dPPAZdtNc2hU5sM0UWulASsKNX2nABD0BEyP1djRCdwWe6 rJOacOwUTqIAITH+4XGC6omfCvkTndn6n2bZJ47hKjeXwtQuSDrp7mP7pjutlBtcBfncgXcdXkr Sw5NHhFrCfz+YpY1VJd91JGa15rnmEsoDCCwFSpS9qk6Af0RpLF8hMYrfMqjskFnie1ZeQ2+FrJ b6/BkXU+oXB2fY88BC0g/lTWdjtr2DH+radAlowGDjvVrrMe/OFdYjYzvGhkmbcX/QsfjHiyuof CZ44Bi7udEErvIWht8zCCxFBF4rtZCoyqiJyjKl9LX9xWE8= X-Received: by 2002:a05:690c:6984:b0:81e:a425:fe88 with SMTP id 00721157ae682-81fd4bf523fmr168290117b3.33.1785811398719; Mon, 03 Aug 2026 19:43:18 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260803141659.559129-1-akkun11.open@gmail.com> <20260803141659.559129-12-akkun11.open@gmail.com> In-Reply-To: <20260803141659.559129-12-akkun11.open@gmail.com> From: Chen-Yu Tsai Date: Tue, 4 Aug 2026 10:43:08 +0800 X-Gm-Features: AUfX_mw0ODj1uLGkUiNOBLIVs6yIxP-U-M-JHW0wgLxFKYiXjICIFii0-d42exg Message-ID: Subject: Re: [PATCH 11/32] clk: mediatek: Add auto-population of sub-devices support in simple probe To: Akari Tsuyukusa Cc: Michael Turquette , Stephen Boyd , Brian Masney , Matthias Brugger , AngeloGioacchino Del Regno , Yassine Oudjana , Richard Cochran , Laura Nao , =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Bartosz Golaszewski , Danilo Krummrich , Bjorn Helgaas , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig_=28The_Capable_Hub=29?= , Nicolas Frattaroli , Takashi Sakamoto , Haotian Zhang , Kees Cook , Miles Chen , Daniel Golle , Sam Shih , "open list:COMMON CLK FRAMEWORK" , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:PTP HARDWARE CLOCK SUPPORT:Keyword:(?:b|_)ptp(?:b|_)" , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Aug 3, 2026 at 10:18=E2=80=AFPM Akari Tsuyukusa wrote: > > MediaTek audio clock drivers call devm_of_platform_populate() after > mtk_clk_simple_probe(). Extend __mtk_clk_simple_probe() to run > devm_of_platform_populate() when the new 'populate_children' flag is > set, reducing boilerplate. > > Note that explicit of_platform_depopulate() calls in remove functions > are unnecessary because devm_of_platform_populate() is managed by > devres and cleans up automatically. > > Signed-off-by: Akari Tsuyukusa > --- > drivers/clk/mediatek/clk-mtk.c | 7 +++++++ > drivers/clk/mediatek/clk-mtk.h | 1 + > 2 files changed, 8 insertions(+) > > diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mt= k.c > index c3369a04cdec..71d70b5a9990 100644 > --- a/drivers/clk/mediatek/clk-mtk.c > +++ b/drivers/clk/mediatek/clk-mtk.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -609,6 +610,12 @@ static int __mtk_clk_simple_probe(struct platform_de= vice *pdev, > if (mcd->need_runtime_pm) > pm_runtime_put(&pdev->dev); > > + if (mcd->populate_children) { > + r =3D devm_of_platform_populate(&pdev->dev); > + if (r) > + goto unregister_clks; You cannot use devm_* here, as they get unrolled _after_ the probe function returns an error or after the remove function returns. A child could be referencing a clock that got tore down in the error path below. All devm_* functions need to happen before anything that requires manual tear down. You can't mix the two together. ChenYu > + } > + > return r; > > unregister_clks: > diff --git a/drivers/clk/mediatek/clk-mtk.h b/drivers/clk/mediatek/clk-mt= k.h > index b6504b3e77ed..11939e3e0b38 100644 > --- a/drivers/clk/mediatek/clk-mtk.h > +++ b/drivers/clk/mediatek/clk-mtk.h > @@ -265,6 +265,7 @@ struct mtk_clk_desc { > unsigned int mfg_clk_idx; > > bool need_runtime_pm; > + bool populate_children; > }; > > int mtk_clk_pdev_probe(struct platform_device *pdev); > -- > 2.55.0 >