From: Chen-Yu Tsai <wenst@chromium.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Tomasz Figa <tfiga@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Ricardo Ribalda <ribalda@chromium.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: videobuf2: always set buffer vb2 pointer
Date: Tue, 28 Sep 2021 15:53:14 +0800 [thread overview]
Message-ID: <CAGXv+5G16fZWyyFDHTeaqJG02cYhVm20u47ZXJb+HdHmFc8HSw@mail.gmail.com> (raw)
In-Reply-To: <CAGXv+5HaZcf-RwGGb7phfKcoTnaeiN2H6b_BvR+qdcRYys=nzA@mail.gmail.com>
On Tue, Sep 28, 2021 at 2:24 PM Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> On Tue, Sep 28, 2021 at 2:16 PM Sergey Senozhatsky
> <senozhatsky@chromium.org> wrote:
> >
> > We need to always link allocated vb2_dc_buf back to vb2_buffer because
> > we dereference vb2 in prepare() and finish() callbacks.
> >
> > Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
>
> This fixes the breakage from the "videobuf2: support new noncontiguous DMA
> API" series on the RK3399 Scarlet if the ChromeOS patch that changes
> min_buffers_needed to 0 [1] is not applied.
>
> Since there are other in-tree drivers that have min_buffers_needed=0,
> I would recommend getting some more testing.
Seems I had a stale kernel when testing the min_buffers_needed=0 case.
Everythings works now.
Tested-by: Chen-Yu Tsai <wenst@chromium.org>
next prev parent reply other threads:[~2021-09-28 7:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 3:46 Sergey Senozhatsky
2021-09-28 6:24 ` Chen-Yu Tsai
2021-09-28 7:53 ` Chen-Yu Tsai [this message]
2021-10-05 9:57 ` Tomasz Figa
2021-10-12 1:57 ` Sergey Senozhatsky
2021-10-12 7:52 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXv+5G16fZWyyFDHTeaqJG02cYhVm20u47ZXJb+HdHmFc8HSw@mail.gmail.com \
--to=wenst@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=senozhatsky@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®