From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754099AbdKOChj (ORCPT ); Tue, 14 Nov 2017 21:37:39 -0500 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:46906 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872AbdKOChf (ORCPT ); Tue, 14 Nov 2017 21:37:35 -0500 X-Google-Smtp-Source: AGs4zMbOuU04YFDwiRpPjGlHxpjskKk9wWWKIjVn2aay9uhGSU0SdgA7G8Q83dvkI4Zgpg+pa1E6iXjKy9SCIzSYXxQ= MIME-Version: 1.0 In-Reply-To: <20171024160102.fjonpvkykyijxmow@rob-hp-laptop> References: <20171017121807.2994-1-wens@csie.org> <20171017121807.2994-3-wens@csie.org> <20171024160102.fjonpvkykyijxmow@rob-hp-laptop> From: Chen-Yu Tsai Date: Wed, 15 Nov 2017 10:37:02 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 02/10] drm/sun4i: tcon: Add support for A10 TCON To: Rob Herring Cc: Chen-Yu Tsai , Maxime Ripard , David Airlie , Mark Rutland , Jonathan Liu , dri-devel , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 25, 2017 at 12:01 AM, Rob Herring wrote: > On Tue, Oct 17, 2017 at 08:17:59PM +0800, Chen-Yu Tsai wrote: >> From: Jonathan Liu >> >> The A10 has two TCONs that are similar to the ones found on other SoCs. >> Like the A31, TCON0 has a register used to mux the TCON outputs to the >> downstream encoders. The bit fields are slightly different. >> >> Signed-off-by: Jonathan Liu >> [wens@csie.org: Reworked for A10 and fixed up commit message] >> Signed-off-by: Chen-Yu Tsai >> --- >> .../bindings/display/sunxi/sun4i-drm.txt | 1 + >> drivers/gpu/drm/sun4i/sun4i_drv.c | 3 ++- >> drivers/gpu/drm/sun4i/sun4i_tcon.c | 30 ++++++++++++++++++++++ >> 3 files changed, 33 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt >> index 46df3b78ae9e..b2c08af73a95 100644 >> --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt >> +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt >> @@ -86,6 +86,7 @@ The TCON acts as a timing controller for RGB, LVDS and TV interfaces. >> >> Required properties: >> - compatible: value must be either: >> + * allwinner,sun4i-a10-tcon >> * allwinner,sun5i-a13-tcon >> * allwinner,sun6i-a31-tcon >> * allwinner,sun6i-a31s-tcon >> diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c >> index b5879d4620d8..b8089ac6feef 100644 >> --- a/drivers/gpu/drm/sun4i/sun4i_drv.c >> +++ b/drivers/gpu/drm/sun4i/sun4i_drv.c >> @@ -184,7 +184,8 @@ static bool sun4i_drv_node_is_frontend(struct device_node *node) >> >> static bool sun4i_drv_node_is_tcon(struct device_node *node) >> { >> - return of_device_is_compatible(node, "allwinner,sun5i-a13-tcon") || >> + return of_device_is_compatible(node, "allwinner,sun4i-a10-tcon") || >> + of_device_is_compatible(node, "allwinner,sun5i-a13-tcon") || > > This would be better written with of_match_node. Since there's already a > match table in sun4i_tcon.c, it would be better to use it. Tried this and it looks good. I'll send a patch after the merge window. ChenYu > Otherwise, > > Acked-by: Rob Herring