From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1888C07E85 for ; Wed, 14 Nov 2018 06:58:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A8972087A for ; Wed, 14 Nov 2018 06:58:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A8972087A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731575AbeKNRAY (ORCPT ); Wed, 14 Nov 2018 12:00:24 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:38981 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726927AbeKNRAX (ORCPT ); Wed, 14 Nov 2018 12:00:23 -0500 Received: by mail-ed1-f65.google.com with SMTP id b14so10152494edt.6; Tue, 13 Nov 2018 22:58:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IFgmvrn1Uc4t3y/os32mrfJIYufUIc2ZFQ1ZVHConhQ=; b=iTthEFgehMl5/4yRdYIQQhEjoLXCXMrYwwgH9GNiPvG2I2cB67TIgXWlD3D1Nr77UT w7Vy1lE+pcwQDAStTZgvTleiZE2h3JPw3g72neKU2MBYdZb0WkNDKOTovjj8gaJlbSxb bFFf5Btm5mQVJ81EaqNslpnGeAygekvHYl2kyDAMQ8mOF38lT2yaW7F6s3gvaZRXga0l vTUiGG7jBPbnIRSl+nSmhj7hLucQB8JNgarAFrRSt7LIS/DroraGSfJrdEqbsruI2Jb/ i4xEcFn6aoJ9puL58NC4AF8IZTp/C8aY/ZVpgaEOF+exLSuTC1359LehIpSwifRQN0PG ZTnQ== X-Gm-Message-State: AGRZ1gJwfkTd0FSTZSvWaTVgdteWlRZ07X2VVNsUEPcQcZJYvB3DzWYx E81UdOLxDLLTsyPRcgSIrx/ysy2egPg= X-Google-Smtp-Source: AJdET5fWn10v5YhoLAaLitAe75OHbOXcQi+JMQtFIC91BdU047K1GRZhEu6fx9SKLUba7F9FzYq10g== X-Received: by 2002:a17:906:12d3:: with SMTP id l19-v6mr904845ejb.74.1542178706038; Tue, 13 Nov 2018 22:58:26 -0800 (PST) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com. [209.85.128.45]) by smtp.gmail.com with ESMTPSA id r8-v6sm3386440ejb.52.2018.11.13.22.58.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Nov 2018 22:58:24 -0800 (PST) Received: by mail-wm1-f45.google.com with SMTP id p2-v6so13593360wmc.2; Tue, 13 Nov 2018 22:58:24 -0800 (PST) X-Received: by 2002:a1c:f008:: with SMTP id a8-v6mr711154wmb.5.1542178703511; Tue, 13 Nov 2018 22:58:23 -0800 (PST) MIME-Version: 1.0 References: <20181113111633.20189-1-jagan@amarulasolutions.com> <20181113111633.20189-26-jagan@amarulasolutions.com> <20181113122204.337db8b1@donnerap.cambridge.arm.com> In-Reply-To: From: Chen-Yu Tsai Date: Wed, 14 Nov 2018 14:58:11 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 25/26] [DO NOT MERGE] arm64: dts: allwinner: bananapi-m64: Bananapi S070WV20-CT16 DSI panel To: Jagan Teki Cc: =?UTF-8?Q?Andr=C3=A9_Przywara?= , Maxime Ripard , Icenowy Zheng , Jernej Skrabec , Vasily Khoruzhick , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , David Airlie , dri-devel , Mike Turquette , Stephen Boyd , linux-clk , Michael Trimarchi , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi@googlegroups.com, linux-amarula@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 14, 2018 at 2:31 PM Jagan Teki wrote: > > On Tue, Nov 13, 2018 at 5:52 PM Andre Przywara wrote: > > > > On Tue, 13 Nov 2018 16:46:32 +0530 > > Jagan Teki wrote: > > > > Hi, > > > > > This patch add support for Bananapi S070WV20-CT16 DSI panel to > > > BPI-M64 board. > > > > > > DSI panel connected via board DSI port with, > > > - DC1SW as AVDD supply > > > > Are you sure of that? I don't see anything in the schematic to support > > this. The only power lines that go to the DSI connector are DCDC1 and > > PS. DC1SW is only connected to PortD on the SoC and to the Ethernet PHY. > > Is there anything I miss? > > Thanks for the comment, yes dc1sw is connected in ephy. I have reused > dc1, BSP is attached lcd_power1 to axp81x_dc1sw [1]. I just looking > for someone to comment, may be we can skip this regulator attachment. That seems sketchy. The schematics show the connector has feeds from both the unregulated output IPSOUT (PS) and DCDC1. For designs with RGB LCD panels, we only see the PS feed. Since the LCD panel can be used in either RGB or MIPI DSI mode, I highly suspect the DCDC1 supply feeds the bridge IC. As for DC1SW, this is likely referenced because it provides power to the GPIO lines that are used to control the LCD panel. If you don't provide power, you can't pull them up. While many of us dislike FEX and the new FEX-derived device tree, they do provide some information, such as regulator usage. Note that each regulator output has multiple names, which likely denote specific usages. I've asked BPI for schematics on the bridge board. Hopefully we'll have something in more detail. In the meantime, I suggest leaving this panel out of your next submission, and focus on getting the bulk of the dsi driver and dts changes in first. ChenYu > > > > > > - DCDC1 as DVDD supply > > > > That seems right, but doesn't match with what you write below. > > Commit need to fix s/DCDC1/DLDO1 > > > > > > - PD6 gpio for reset pin > > > - PD5 gpio for backlight enable pin > > > - PD7 gpio for backlight vdd supply > > > > > > Signed-off-by: Jagan Teki > > > --- > > > .../dts/allwinner/sun50i-a64-bananapi-m64.dts | 42 > > > +++++++++++++++++++ 1 file changed, 42 insertions(+) > > > > > > diff --git > > > a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > > > b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts index > > > ef1c90401bb2..6cb010e3bbd9 100644 --- > > > a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts +++ > > > b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts @@ -45,6 > > > +45,7 @@ #include "sun50i-a64.dtsi" > > > #include > > > +#include > > > > > > / { > > > model = "BananaPi-M64"; > > > @@ -56,6 +57,15 @@ > > > serial1 = &uart1; > > > }; > > > > > > + backlight: backlight { > > > + compatible = "pwm-backlight"; > > > + pwms = <&r_pwm 0 50000 PWM_POLARITY_INVERTED>; > > > + brightness-levels = <1 2 4 8 16 32 64 128 512>; > > > + default-brightness-level = <2>; > > > + enable-gpios = <&pio 3 5 GPIO_ACTIVE_HIGH>; /* > > > LCD-BL-EN: PD5 */ > > > + power-supply = <®_vdd_backlight>; > > > + }; > > > + > > > chosen { > > > stdout-path = "serial0:115200n8"; > > > }; > > > @@ -91,6 +101,15 @@ > > > }; > > > }; > > > > > > + reg_vdd_backlight: vdd-backlight { > > > + compatible = "regulator-fixed"; > > > + regulator-name = "vdd-backlight"; > > > + regulator-min-microvolt = <3300000>; > > > + regulator-max-microvolt = <3300000>; > > > + gpio = <&pio 3 7 GPIO_ACTIVE_HIGH>; /* LCD-PWR-EN: > > > PD7 */ > > > + enable-active-high; > > > + }; > > > + > > > wifi_pwrseq: wifi_pwrseq { > > > compatible = "mmc-pwrseq-simple"; > > > reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */ > > > @@ -101,6 +120,23 @@ > > > status = "okay"; > > > }; > > > > > > +&dphy { > > > + status = "okay"; > > > +}; > > > + > > > +&dsi { > > > + status = "okay"; > > > + > > > + panel@0 { > > > + compatible = "bananapi,s070wv20-ct16-icn6211"; > > > + reg = <0>; > > > + avdd-supply = <®_dc1sw>; > > > > As mentioned above, I don't see this on the DSI connector. > > > > > + dvdd-supply = <®_dldo1>; > > > > Mmh, this line is connected to the *SoC*, to drive the DSI data lines > > or the DPHY, presumably. So I wouldn't expect it in the panel node, but > > rather in the DPHY or DSI node. Although I can't find a power-supply > > property in those bindings. > > Got it, this has to attach via vcc-dsi-supply. > > [1] https://github.com/BPI-SINOVOIP/BPI-M64-bsp/blob/master/bootloader/blobs/bpi-m64-lcd7.dts#L2266