From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751740AbdINMOl (ORCPT ); Thu, 14 Sep 2017 08:14:41 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:43018 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbdINMOk (ORCPT ); Thu, 14 Sep 2017 08:14:40 -0400 X-Google-Smtp-Source: AOwi7QDZGzSKS2XFO4sy+4VMthRCYCDha4xsO19CB/JI1I1XD36n/nCShKfkvn0/WiZJ+w7ECz1tOgxRy8mz1sasGSQ= MIME-Version: 1.0 In-Reply-To: <20170914120519.2006-1-alex@asyring.de> References: <20170914120519.2006-1-alex@asyring.de> From: Chen-Yu Tsai Date: Thu, 14 Sep 2017 20:14:10 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] clk: sunxi-ng: Fix missing CLK_SET_RATE_PARENT in ccu-sun4i-a10.c To: Alexander Syring Cc: Maxime Ripard , Chen-Yu Tsai , Michael Turquette , Stephen Boyd , linux-arm-kernel , linux-clk , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 14, 2017 at 8:05 PM, Alexander Syring wrote: > When using cpufreq-dt with default govenor other than "performance" > system freezes while booting. > Adding CLK_SET_RATE_PARENT | CLK_IS_CRITICAL to clk_cpu fixes the > problem. > > Tested on Cubietruck (A20). > > Fixes: c84f5683f6E ("clk: sunxi-ng: Add sun4i/sun7i CCU driver") > > Reported-by: Alexander Syring You typically don't need this if you yourself are the reporter. > Signed-off-by: Alexander Syring Acked-by: Chen-Yu Tsai > --- > drivers/clk/sunxi-ng/ccu-sun4i-a10.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/sunxi-ng/ccu-sun4i-a10.c b/drivers/clk/sunxi-ng/ccu-sun4i-a10.c > index 286b0049b7b6..a48fde191c0a 100644 > --- a/drivers/clk/sunxi-ng/ccu-sun4i-a10.c > +++ b/drivers/clk/sunxi-ng/ccu-sun4i-a10.c > @@ -223,7 +223,7 @@ static struct ccu_mux cpu_clk = { > .hw.init = CLK_HW_INIT_PARENTS("cpu", > cpu_parents, > &ccu_mux_ops, > - CLK_IS_CRITICAL), > + CLK_SET_RATE_PARENT | CLK_IS_CRITICAL), > } > }; > > -- > 2.11.0 >