From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794240439; b=pN3sqc/pdfVqnZ7yVRhXd2dOszbuNHtVTE2ZsWMPrCEW0SYYBn01vltyVpxIn3NwM6vD w2KJbev864U77wb2msayXCPH+pU7jZQZ3LMsCASgmSDJ5XX8hH4i7X6v/fINujvBG+RGk EqbhhsFQWY2nqO1Aq5E1GKC927Y9BYJpREKUMHE3ur8QU5Tv8i9E4myERVPZzu9CCE1ch n6RvIZpAm9zBT9XyENDbvXPeBwQjmRsbRqmR0QeusVYbEcPpMAo3uzJCc/Ikfd49DPxEC BcRlb6dOaXRlXV+3hYb5SY0iglZEzxFPkkONcFzKYLcAvqfcPpwGoAOFbXBb7Nh0XZw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794240439; h=Received:DKIM-Signature:Received:X-Forwarded-Encrypted: X-Gm-Message-State:X-Received:MIME-Version:References:In-Reply-To: Reply-To:From:Date:X-Gmail-Original-Message-ID:X-Gm-Features: Message-ID:Subject:To:Cc:Content-Type:Content-Transfer-Encoding; bh=GFQPb65NT7RMSCppnWXFsuqs6MvLmEnYZdDh5XC4mjA=; b=WddmweFMOhvenKw+lfyLUTqguQNXYaLBORTnZ1UDFo6fIj2ONyAb6DXuV1pSqAi12Y3s +OD09JtCw4zIojSQVLw3SMiH2EoQypHSGgsAp19hpj7VxEagk9ff5IimHzoxQD8+jXHCA pxcd0povNtwjHKij8NIHVc5StD+ZMSjpTR5k/5AkGYxTC/UrJi6A0UaslfRv58E1WsZNP 9GcTprmpBrJEP1wos2YEfLdCkYrKHP8pPOVknVTzGlbcfiMbai3P1LAqFnd5BAIGnL7vR 9MXKOTJJOAEIf7pxGH1j68PUxS7Z4ImyKZ3N01PM2mOJEqifWMHaCqqblwfLYOQZCvQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=UPpFuF29; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49AF4606A33D for ; Mon, 9 Nov 2026 16:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=UPpFuF29 Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB2321F00901 for ; Mon, 9 Nov 2026 16:07:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794240437; bh=GFQPb65NT7RMSCppnWXFsuqs6MvLmEnYZdDh5XC4mjA=; h=References:In-Reply-To:Reply-To:From:Date:Subject:To:Cc; b=UPpFuF292enNAk33j0lC+1PqdbjJadzioJZ9ju8EwW47zs88GH4LOgNx6EXsBeAVS naQyLa5OJnp5SwqUX8i35edRwP+9AafAV+Zz8HdaTatC78INOzQLTZGY6xqBbAdv/w IiBpDWoJ7kQqe+JNkrpVw+hcxH4K73HSm0ZwcQcAPxQTgH7kNV3MNpL2gTH1DzNyal c2ohYafFn+0LycaXUe345gUZ3bkAugp/UYZE1nBzEES9VDKgulLZ94SrK0/f9E6ILx D/nEratmZRTSCwdOkvM1jJUmOWwhPHp9t6xXNpRh+E/zY0IW2d3tLcFSer/hskkYgY vTE3vP+uIGl7Q== Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-3ab4891fc73so7936211fa.0 for ; Mon, 09 Nov 2026 08:07:17 -0800 (PST) X-Forwarded-Encrypted: i=1; AL+hErERlLkpe7Q8JwX4zoqDtHjkzju7hgME2rCsIuWmbiQskssijthxVa8BC6tyJooEHc3imzLao336WEYqga4=@vger.kernel.org X-Gm-Message-State: APuU4Z+cTjt8z1VYleZ/DVjsEQC/LpmWooGOZsbw7QE88q80x4gL4OJs j2Vf0aE9R/qtXcj1z9t7aPA+z0wsoO9D32ajMN4ifeaVZRnNQ+1IAe24MYdDH+4mHPr9t8ILOL+ u6M5Ze4CrY2oxVHajj7iiaEhIU+37zOk= X-Received: by 2002:a05:6512:1396:b0:5c1:4974:c15e with SMTP id 2adb3069b0e04-5c14c0347cbmr1335285e87.52.1794240436213; Mon, 09 Nov 2026 08:07:16 -0800 (PST) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <20261009-a733-clk-v6-0-ae8178fce7e8@pigmoral.tech> <20261009-a733-clk-v6-6-ae8178fce7e8@pigmoral.tech> In-Reply-To: <20261009-a733-clk-v6-6-ae8178fce7e8@pigmoral.tech> Reply-To: wens@kernel.org From: Chen-Yu Tsai Date: Tue, 10 Nov 2026 01:07:03 +0900 X-Gmail-Original-Message-ID: X-Gm-Features: AclHuK9agX6QEN1ILAcd18vE_t6MGmoL64ggMRVBKmQGQ0cwuc_S8X4_YIrWVls Message-ID: Subject: Re: [PATCH v6 6/8] clk: sunxi-ng: a733: Add mod clocks support To: Junhui Liu Cc: Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jernej Skrabec , Samuel Holland , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Richard Cochran , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, netdev@vger.kernel.org, Jerome Brunet , Enzo Adriano , Andre Przywara , Norman Herms , Vinicius Pedrosa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Oct 10, 2026 at 12:54=E2=80=AFAM Junhui Liu wrote: > > Add the module clocks found in the Allwinner A733 SoC, including video, > storage, interfaces and others. While most of these clocks are similar > to those in the A523 SoC, this implementation accounts for changes in > register offsets and introduces support for new modules. > > Tested-by: Jerome Brunet > Signed-off-by: Junhui Liu > --- > drivers/clk/sunxi-ng/ccu-sun60i-a733.c | 1103 ++++++++++++++++++++++++++= ++++++ > 1 file changed, 1103 insertions(+) > > diff --git a/drivers/clk/sunxi-ng/ccu-sun60i-a733.c b/drivers/clk/sunxi-n= g/ccu-sun60i-a733.c > index 371c4297c3ab..7847eec84313 100644 > --- a/drivers/clk/sunxi-ng/ccu-sun60i-a733.c > +++ b/drivers/clk/sunxi-ng/ccu-sun60i-a733.c [...] > +static const struct clk_parent_data dram_parents[] =3D { > + { .hw =3D &pll_ddr_clk.common.hw, }, > + { .hw =3D &pll_periph0_800M_clk.common.hw, }, > + { .hw =3D &pll_periph0_600M_clk.hw, }, > + { .hw =3D &pll_de_clk.common.hw, }, > + { .hw =3D &pll_npu_clk.common.hw, }, > +}; > +static SUNXI_CCU_M_DATA_WITH_MUX_GATE_FEAT(dram0_clk, "dram0", dram_pare= nts, 0xc00, > + 0, 4, /* M */ My LLM agent flagged this: the divider is 5 bits wide, not 4. Both the user manual (page 149 from start or 128 as numbered on the page) and the BSP agree. ChenYu