From: Barry Song <baohua@kernel.org>
To: Xu Wang <vulab@iscas.ac.cn>
Cc: Michael Turquette <mturquette@baylibre.com>,
sboyd@kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: clk-prima2: fix return value check in prima2_clk_init()
Date: Sat, 26 Sep 2020 14:50:32 +1200 [thread overview]
Message-ID: <CAGsJ_4w89Un_howPcfH2jKi1WBsXzQWimdYoW2gOjCf9K23Pyg@mail.gmail.com> (raw)
In-Reply-To: <20200921034522.9077-1-vulab@iscas.ac.cn>
Xu Wang <vulab@iscas.ac.cn> 于2020年9月21日周一 下午3:45写道:
>
> In case of error, the function clk_register() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Acked-by: Barry Song <baohua@kernel.org>
Thanks
> ---
> drivers/clk/sirf/clk-prima2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sirf/clk-prima2.c b/drivers/clk/sirf/clk-prima2.c
> index 45dcbc9e0302..d17b345f4d2d 100644
> --- a/drivers/clk/sirf/clk-prima2.c
> +++ b/drivers/clk/sirf/clk-prima2.c
> @@ -134,7 +134,7 @@ static void __init prima2_clk_init(struct device_node *np)
>
> for (i = pll1; i < maxclk; i++) {
> prima2_clks[i] = clk_register(NULL, prima2_clk_hw_array[i]);
> - BUG_ON(!prima2_clks[i]);
> + BUG_ON(IS_ERR(prima2_clks[i]));
> }
> clk_register_clkdev(prima2_clks[cpu], NULL, "cpu");
> clk_register_clkdev(prima2_clks[io], NULL, "io");
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-09-26 2:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 3:45 Xu Wang
2020-09-26 2:50 ` Barry Song [this message]
2020-10-14 2:54 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGsJ_4w89Un_howPcfH2jKi1WBsXzQWimdYoW2gOjCf9K23Pyg@mail.gmail.com \
--to=baohua@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®