mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Barry Song <baohua@kernel.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Shakeel Butt <shakeel.butt@linux.dev>,
	akpm@linux-foundation.org, linux-mm@kvack.org,
	 baoquan.he@linux.dev, chrisl@kernel.org, jp.kobryn@linux.dev,
	 kasong@tencent.com, liam@infradead.org,
	linux-kernel@vger.kernel.org,  ljs@kernel.org, mhocko@suse.com,
	nphamcs@gmail.com, rppt@kernel.org,  shikemeng@huaweicloud.com,
	surenb@google.com, usama.arif@linux.dev,  vbabka@kernel.org,
	youngjun.park@lge.com
Subject: Re: [PATCH v2 1/4] mm: avoid unnecessary lru drain for wp_can_reuse_anon_folio()
Date: Tue, 30 Jun 2026 07:16:24 +0800	[thread overview]
Message-ID: <CAGsJ_4yRKAhRqtC=ieGV=gQ0-x2aYPDV6QW8_akkGiJsmxkbfg@mail.gmail.com> (raw)
In-Reply-To: <3903def5-e823-4fe3-9784-b6bd63470516@kernel.org>

On Mon, Jun 29, 2026 at 3:52 PM David Hildenbrand (Arm)
<david@kernel.org> wrote:
[...]
>
> So yeah, if Nadav's reproducer works even without the drain (which I assume), we
> could indeed think about just removing this optimization here.

Yet I think the problem is resolved with the exclusive flag.
Right now, we can still have cases where "exclusive" cannot
address it, such as:

#include <sys/mman.h>

int main(int argc, char *argv[])
{
    int i;
    #define SIZE 30*1024*1024
    while(1) {
        volatile int *p = mmap(0, SIZE, PROT_READ | PROT_WRITE,
             MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
        volatile int q;

        for (int i = 0; i < SIZE/sizeof(int); i++)
              p[i] =  i;
        madvise((void *)p, SIZE, MADV_PAGEOUT);
        if (!fork())
             _exit(0);
        for (int i = 0; i < SIZE/sizeof(int); i++)
              q = p[i];
        for (int i = 0; i < SIZE/sizeof(int); i++)
              p[i] =  i;
        munmap(p, SIZE);
    }
    return 0;
}

I assume this is less frequent and less of a concern?

Thanks
Barry

  reply	other threads:[~2026-06-29 23:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23 23:16 [PATCH v2 0/4] mm: drop redundant lru_add_drain in anon folio reuse paths Barry Song (Xiaomi)
2026-06-23 23:16 ` [PATCH v2 1/4] mm: avoid unnecessary lru drain for wp_can_reuse_anon_folio() Barry Song (Xiaomi)
2026-06-24 10:14   ` Kairui Song
2026-06-24 15:02   ` David Hildenbrand (Arm)
2026-06-24 21:04     ` Barry Song
2026-06-26 16:25       ` David Hildenbrand (Arm)
2026-06-27  2:44         ` Shakeel Butt
2026-06-27  7:20           ` Barry Song
2026-06-29  7:52             ` David Hildenbrand (Arm)
2026-06-29 23:16               ` Barry Song [this message]
2026-06-30  5:38                 ` David Hildenbrand (Arm)
2026-06-23 23:16 ` [PATCH v2 2/4] mm: drop stale folio_ref_count()==1 check in do_swap_page reuse logic Barry Song (Xiaomi)
2026-06-24 15:07   ` David Hildenbrand (Arm)
2026-06-24 21:29     ` Barry Song
2026-06-23 23:16 ` [PATCH v2 3/4] mm: entirely remove lru_add_drain in do_swap_page Barry Song (Xiaomi)
2026-06-24 10:16   ` Kairui Song
2026-06-24 15:10   ` David Hildenbrand (Arm)
2026-06-23 23:16 ` [PATCH v2 4/4] mm: try to free swapcache for non-LRU folios Barry Song (Xiaomi)
2026-06-24 15:20   ` David Hildenbrand (Arm)
2026-06-24 21:14     ` Barry Song
2026-06-25 14:40       ` Kairui Song
2026-06-26 16:35         ` David Hildenbrand (Arm)
2026-06-29 23:59           ` Barry Song
2026-06-30  5:48             ` David Hildenbrand (Arm)
2026-06-30 22:36               ` Barry Song
2026-07-01  8:18                 ` David Hildenbrand (Arm)
2026-07-01  9:50                   ` Barry Song
2026-07-01 20:09                     ` David Hildenbrand (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGsJ_4yRKAhRqtC=ieGV=gQ0-x2aYPDV6QW8_akkGiJsmxkbfg@mail.gmail.com' \
    --to=baohua@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=baoquan.he@linux.dev \
    --cc=chrisl@kernel.org \
    --cc=david@kernel.org \
    --cc=jp.kobryn@linux.dev \
    --cc=kasong@tencent.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=nphamcs@gmail.com \
    --cc=rppt@kernel.org \
    --cc=shakeel.butt@linux.dev \
    --cc=shikemeng@huaweicloud.com \
    --cc=surenb@google.com \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=youngjun.park@lge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox