mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Štefan Gula" <steweg@ynet.sk>
To: "Rose, Gregory V" <gregory.v.rose@intel.com>
Cc: David Miller <davem@davemloft.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [patch v1, kernel version 3.2.1] rtnetlink workaround around the skb buff size issue
Date: Mon, 6 Feb 2012 19:32:16 +0100	[thread overview]
Message-ID: <CAGsizzKVMHT2TUK2O0odbpm6tkMHq9isSOZcjEies+fOOkURYA@mail.gmail.com> (raw)
In-Reply-To: <C5551D9AAB213A418B7FD5E4A6F30A0702F806E3@ORSMSX106.amr.corp.intel.com>

2012/2/6 Rose, Gregory V <gregory.v.rose@intel.com>:
> That is exactly my approach.  We currently have a *bug* in the kernel that this patch is addressing.  The kernel is attempting to provide too much information for the netlink interface to handle and it's breaking things.  So what I want to do is fix the immediate problem while still providing a way for folks to get the information they need.  I've accomplished this by doing exactly what Dave asked me to do, provide a filter that defaults to off and then provide a way for the user to request discrete chunks of information in the dump that won't exceed the netlink buffer limits.
>
> The patch is fairly unobtrusive and simple to understand.
>
> I appreciate that it doesn't do all that you'd like to see done and I see no reason why you couldn't go on and develop the extended features that you would like to see, correct?  There's nothing in my patch that would prevent that so far as I can tell, although I'm not that familiar with your requirements or proposals yet.
Greg, your patch is completely ok for filtering. I like that thing. I
am just stating that it doesn't eliminate every possible option that
can happen so I believe we should also have method for using cycles -
that's what my patch is doing. So I believe both approaches should be
applied.

  reply	other threads:[~2012-02-06 18:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5422254.3711328278789768.JavaMail.root@5-MeO-DMT.ynet.sk>
2012-02-03 14:24 ` Stefan Gula
2012-02-04  0:29   ` David Miller
2012-02-06  4:41     ` Rose, Gregory V
2012-02-06  8:53       ` Štefan Gula
2012-02-06 15:15         ` David Miller
2012-02-06 16:56           ` Eric Dumazet
2012-02-06 18:52             ` Štefan Gula
2012-02-06 17:29         ` Rose, Gregory V
2012-02-06 18:32           ` Štefan Gula [this message]
2012-02-06 18:36             ` Rose, Gregory V
2012-02-06 23:50       ` Ben Hutchings
2012-02-07  0:13         ` Rose, Gregory V
2012-02-07 18:26           ` Ben Hutchings
2012-02-07 18:32             ` David Miller
2012-02-07 18:59               ` Rose, Gregory V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGsizzKVMHT2TUK2O0odbpm6tkMHq9isSOZcjEies+fOOkURYA@mail.gmail.com \
    --to=steweg@ynet.sk \
    --cc=davem@davemloft.net \
    --cc=gregory.v.rose@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®