From: Mateusz Guzik <mjguzik@gmail.com>
To: Max Kellermann <max.kellermann@ionos.com>
Cc: slava.dubeyko@ibm.com, xiubli@redhat.com, idryomov@gmail.com,
amarkuze@redhat.com, ceph-devel@vger.kernel.org,
netfs@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] ceph: fix deadlock bugs by making iput() calls asynchronous
Date: Wed, 17 Sep 2025 16:12:26 +0200 [thread overview]
Message-ID: <CAGudoHF0+JfqxB_fQxeo7Pbadjq7UA1JFH4QmfFS1hDHunNmtw@mail.gmail.com> (raw)
In-Reply-To: <20250917135907.2218073-1-max.kellermann@ionos.com>
On Wed, Sep 17, 2025 at 3:59 PM Max Kellermann <max.kellermann@ionos.com> wrote:
> +/**
> + * Queue an asynchronous iput() call in a worker thread. Use this
> + * instead of iput() in contexts where evicting the inode is unsafe.
> + * For example, inode eviction may cause deadlocks in
> + * inode_wait_for_writeback() (when called from within writeback) or
> + * in netfs_wait_for_outstanding_io() (when called from within the
> + * Ceph messenger).
> + */
> +void ceph_iput_async(struct inode *inode)
> +{
> + if (unlikely(!inode))
> + return;
> +
> + if (likely(atomic_add_unless(&inode->i_count, -1, 1)))
> + /* somebody else is holding another reference -
> + * nothing left to do for us
> + */
> + return;
> +
LGTM, I see the queue thing ends up issuing iput() so it's all good, thanks.
No idea about the other stuff it is doing concerning ceph flags so no comment.
> + doutc(ceph_inode_to_fs_client(inode)->client, "%p %llx.%llx\n", inode, ceph_vinop(inode));
> +
> + /* simply queue a ceph_inode_work() (donating the remaining
> + * reference) without setting i_work_mask bit; other than
> + * putting the reference, there is nothing to do
> + */
> + WARN_ON_ONCE(!queue_work(ceph_inode_to_fs_client(inode)->inode_wq,
> + &ceph_inode(inode)->i_work));
> +
> + /* note: queue_work() cannot fail; it i_work were already
> + * queued, then it would be holding another reference, but no
> + * such reference exists
> + */
> +}
> +
next prev parent reply other threads:[~2025-09-17 14:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 13:59 Max Kellermann
2025-09-17 14:12 ` Mateusz Guzik [this message]
2025-09-17 17:55 ` Viacheslav Dubeyko
2025-09-17 19:06 ` Max Kellermann
2025-09-17 19:20 ` Viacheslav Dubeyko
2025-09-17 19:25 ` Max Kellermann
2025-09-17 19:33 ` Viacheslav Dubeyko
2025-09-17 20:20 ` Al Viro
2025-09-17 20:25 ` Max Kellermann
2025-09-17 20:27 ` Max Kellermann
2025-09-18 4:52 ` Max Kellermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGudoHF0+JfqxB_fQxeo7Pbadjq7UA1JFH4QmfFS1hDHunNmtw@mail.gmail.com \
--to=mjguzik@gmail.com \
--cc=amarkuze@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
--cc=netfs@lists.linux.dev \
--cc=slava.dubeyko@ibm.com \
--cc=stable@vger.kernel.org \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®