From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82B153314D7 for ; Mon, 12 Jan 2026 08:57:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768208273; cv=none; b=CRjNd1qK7M/s5ZxpIYt1EsRildW6WRzqdzQ7GHvEr2AaRE8UQay7UTSkyJCGGBdG33iZf7ACMnlJvnGF4Zbh6wMEtOCGoklsiNA5fCv7QVf9hKBlR5KkYSpiZg0C26nuHoP6tELs1PaMLS6AGStoBMBUQY5h/XbqPXagUMDt/ZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768208273; c=relaxed/simple; bh=VaZMiPzlaOln98uHBtXqBDV1bn/cvr20Z/exAarYh18=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=ot0EVbyp917i0PSjqND7Dz2lJugLO/FpWV8yfJK7FwYPHoFIClwHTgVddaTEn8JJTggPyAKT7XMq7xsZghnfYCC0HWFyw1+0ZP4yIibOFo9cBPbmPI/thzZHbvGPqwEJr93YDUYZgXYGVUbKWcE3ZZDm91EFuG24513pgtfnuaY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=Ihw7f/V+; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="Ihw7f/V+" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-78f89501423so53304487b3.1 for ; Mon, 12 Jan 2026 00:57:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1768208270; x=1768813070; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BOTnLPv4tv9bJjvux1j20Y+ExCg3MSBOD5unB3qoASs=; b=Ihw7f/V+yLL71zEImJDYZqffSwY1TvOC27N+bQWd/2r4kJIgAe+m4zPdmVVZ9pMPme AQjM5cVw4HpwStJtzS4rOsNsX7A8q8S3ggCBRmsqncySPMZRyr5PPMdMF2w//jZMegy0 1zXDKm8Xtyf62pUsUy4hIG4Tjtgy21AzaJy3Rk7MGaIOxPOxghW3hUmRzZDDBMaYaJ7A wy1shBVlbLpV/vLT+cIth+6COaWzylw3y6jGDVi3GCUErRR/GQg9XLK18ElFUHN4/P4q L0BNraYeHxtafUBdPkdz+7Z4LUpiahKAYLB8FPuYv+/NG7pTqKNmvwBmzW/pJaaWs7v3 91Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768208270; x=1768813070; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BOTnLPv4tv9bJjvux1j20Y+ExCg3MSBOD5unB3qoASs=; b=lCrweCT84yEj/gbUi0ZQIxa5QujSs28mHB2I+/vbsz6iBxG1LE8DWUqTnyGgY7ZJVn gO7k1zboJcBJD1JtcBDbcxZ4IIUZsBj4eYOv9hJm1tDztRfSDwxvpusoD3B0RayhJsDT zplMTlZFHtMDGxbNk4leyoQNnYxLeXvLgWm6Z6QzIS140cFMSV1A6dIRbASBuV4Q2nw4 IP0TGqmog08XJxmwC2MPA/HVfzo938JcTCJFh/lYDYDJXpMsuxX3cF4WiJRrZOZ7zNjQ SBBd1ITgrixUv6MejI/C4odLbb5BKjtWtTMjcKeaCHpcPvM9Nx63diapZIxCbCaOG/gY l6gA== X-Forwarded-Encrypted: i=1; AJvYcCUVKY++2YCeprPDjS7NtRjDaITBwGWPZjlimyfndZOb34MK719VwEnucQjyzW8fbOy7d/gk4HWiEDnS5j0=@vger.kernel.org X-Gm-Message-State: AOJu0YzYd45c0XmOL3CZaZRa64oOBK33ejndOCB6K7GqexiWyyjFzjYC vfAemGiDLCH7nfnTDkpzGkflyL/w0ivH9WmlSH6lv9r0iCcUjPykTS/k63LT9cD7RlrxLT6+O4w LPjJws8f4Ol9oCXDjGaviOIPQZ//EYvxU/tR3pwetug== X-Gm-Gg: AY/fxX7fLB4VrtXWMMudTSHFuGPvXurqBu3ELraKJfgCtB5GaMIM9xA2PRr6Njb4TQa n9RZQQi8mZpobnyZNXgmQGyAq4aFbcrxt4QTWMk/dtw92fAcNqlW+yM+XVBtpKP3XDQMG14aCuE 6CvgcgxUmCcEI0BG3tJ2hsWst6ZszQfZmXzccNObCgHAnLRvmLzaeaHjtloPXH8XfTwR6uf+xd/ XLFn00daRzCFEYBr0ZPEa/uVR7YmS7Syi9i1Foe005CJ9LvvEiqXX1Tnxg8frUHvm8glk3cqeiB GSPnR2vRL+BSNvX1FM2zL1a2cVBq1MRYGs2jIYNwZfAV X-Google-Smtp-Source: AGHT+IHL6qC6Bkth83Jc0kDsLdGPlb1zjnY+NAdd3aSclQU4CUJsna2Gp1MfFiPTsIdJiiM4QkEp+AQp/YU/RgU4yqo= X-Received: by 2002:a05:690e:1917:b0:644:7ad3:6528 with SMTP id 956f58d0204a3-6471679490amr11838822d50.41.1768208270556; Mon, 12 Jan 2026 00:57:50 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260110-k3-basic-dt-v4-0-d492f3a30ffa@riscstar.com> <20260110-k3-basic-dt-v4-11-d492f3a30ffa@riscstar.com> <20260110095707-GYA12783@gentoo.org> In-Reply-To: <20260110095707-GYA12783@gentoo.org> From: Guodong Xu Date: Mon, 12 Jan 2026 16:57:38 +0800 X-Gm-Features: AZwV_QjrjPKzZ_O6yKHBkitCXrxqQZum-hZ1CkViiN7l5vhVdnYqXq_Ns-pXHZ0 Message-ID: Subject: Re: [PATCH v4 11/11] riscv: dts: spacemit: add SpacemiT K3 Pico-ITX board device tree To: Yixun Lan Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Daniel Lezcano , Thomas Gleixner , Samuel Holland , Anup Patel , Greg Kroah-Hartman , Jiri Slaby , Lubomir Rintel , Yangyu Chen , Paul Walmsley , Conor Dooley , Heinrich Schuchardt , Kevin Meng Zhang , Andrew Jones , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, spacemit@lists.linux.dev, linux-serial@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Yixun On Sat, Jan 10, 2026 at 5:57=E2=80=AFPM Yixun Lan wrote: > > Hi Guodong, > > I have a minor comment for the subject, it's kind of little bit redundant= .. > so, how about (also apply to patch 10): > > [PATCH v4 10/11] riscv: dts: spacemit: add initial support for K3 SoC > [PATCH v4 11/11] riscv: dts: spacemit: add K3 Pico-ITX board support Thanks for the review. Sure, I can do it that way. > > On 13:18 Sat 10 Jan , Guodong Xu wrote: > > K3 Pico-ITX is a 2.5-inch single-board computer equipted with a Spacemi= T > > K3 SoC. > > > > This minimal device tree enables booting into a serial console with UAR= T > > output. > > > > Signed-off-by: Guodong Xu > > --- > > v4: No change. > > v3: No change. > > v2: Add aliases node in this board DT. > > Update the memory node to reflect the hardware truth. Address > > starts at 0x100000000 (4G) boundary. > > --- > > arch/riscv/boot/dts/spacemit/Makefile | 1 + > > arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 38 ++++++++++++++++++++= ++++++++ > > 2 files changed, 39 insertions(+) > > > > diff --git a/arch/riscv/boot/dts/spacemit/Makefile b/arch/riscv/boot/dt= s/spacemit/Makefile > > index 95889e7269d1..7e2b87702571 100644 > > --- a/arch/riscv/boot/dts/spacemit/Makefile > > +++ b/arch/riscv/boot/dts/spacemit/Makefile > > @@ -4,3 +4,4 @@ dtb-$(CONFIG_ARCH_SPACEMIT) +=3D k1-milkv-jupiter.dtb > > dtb-$(CONFIG_ARCH_SPACEMIT) +=3D k1-musepi-pro.dtb > > dtb-$(CONFIG_ARCH_SPACEMIT) +=3D k1-orangepi-r2s.dtb > > dtb-$(CONFIG_ARCH_SPACEMIT) +=3D k1-orangepi-rv2.dtb > > +dtb-$(CONFIG_ARCH_SPACEMIT) +=3D k3-pico-itx.dtb > > diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/= boot/dts/spacemit/k3-pico-itx.dts > > new file mode 100644 > > index 000000000000..037ce757e5bc > > --- /dev/null > > +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts > > @@ -0,0 +1,38 @@ > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > > +/* > > + * Copyright (c) 2025 SpacemiT (Hangzhou) Technology Co. Ltd > > + * Copyright (c) 2025 Guodong Xu > strictly, should update to cover current year - which is 2026 now Yes, that's a mistake. Happy New Year, 2026! I will fix that. > > > + */ > > + > > +#include "k3.dtsi" > > + > > +/ { > > + model =3D "SpacemiT K3 Pico-ITX"; > > + compatible =3D "spacemit,k3-pico-itx", "spacemit,k3"; > > + > > + aliases { > > + serial0 =3D &uart0; > .. > > + serial2 =3D &uart2; > > + serial3 =3D &uart3; > > + serial4 =3D &uart4; > > + serial5 =3D &uart5; > > + serial6 =3D &uart6; > > + serial7 =3D &uart7; > > + serial8 =3D &uart8; > > + serial9 =3D &uart9; > > + serial10 =3D &uart10; > I think we only add aliases for devices which actually enabled Sure. I see your point. There are different styles existing in the kernel dts. like sophgo, and the= ad. I checked th1520-lichee-pi-4a.dts, which has aliases for serial0-5, but only enables uart0 actually. However, for SpacemiT convention, and several others, I see a different sty= le. In k1 boards, both k1-milkv-jupiter.dts and k1-bananapi-f3.dts only have th= e serial0 alias, with only uart0 enabled. For SpacemiT K3 boards, to follow the convention, I will remove the unused aliases and fix that in my next version. Best regards, Guodong Xu > > > + }; > > + > > + chosen { > > + stdout-path =3D "serial0"; > > + }; > > + > > + memory@100000000 { > > + device_type =3D "memory"; > > + reg =3D <0x1 0x00000000 0x4 0x00000000>; > > + }; > > +}; > > + > > +&uart0 { > > + status =3D "okay"; > > +}; > > > > -- > > 2.43.0 > > > > -- > > Yixun Lan (dlan)