From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A99403DB625 for ; Thu, 2 Apr 2026 16:53:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.221.48 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775148841; cv=pass; b=W4/KFI9Rv+GJIqBjPcBy7lo1hGtSp5V7YSC+wgQuElRSf1huyDUgesBY/jfJ2KAZibCTPYxBXz4Zj3dSkALhuJ4AFUmF82lXhjvoGyuv7SzlllOxlvzRDqPUHiOo7cPjOSgdOJK4OiSnj51p18XQwLJaabrP3tfKr1BDrGuBW9w= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775148841; c=relaxed/simple; bh=YQHOj/bnPK/nIDomsOi7P10E15gaCTUx4OYWYgBgufo=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=rYjHQBoBnuRH+cf0b9Z3F1d/wENJGaO8C3lS/NEx2PZiSZaboD3N2IjvWWfQCcj0dRKJzNx2Wse0l6uSOGr4zp1iLW4DRzXQXx8UJlOVn+5+HhFU35BzI8PavbbJa0x79nc9sutt1kiEbAU8V+7eAFeijvyYXBA7hpDfyn23WNY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gQ1qS/1Y; arc=pass smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gQ1qS/1Y" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-43cfbd17589so923290f8f.0 for ; Thu, 02 Apr 2026 09:53:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775148836; cv=none; d=google.com; s=arc-20240605; b=h+LljA6aW62S2TkBevVTrkQVWMiCaHInLqzduB8X1sqR9GLThtptj3d8Wr9qLfEsEe vwMeoAeHdzZX8AfU1CClvb826k82ivX8uQRJtLZSZS/w+CPhphMEg2WRHk53LLQyGRT0 KdnMM7ngoHN2q+BBh0XuYG5qHC+b1FpuO5rEZHSD5oxX2xyIJbVfheaXRBRn0vw5erXP w3QmhDAfgFD5KuQhsViTOKYhPAXoaxFr7dhZOQ5WHWY6pkxDVz19litFbG9ZrcYG1zdm YErJp5Gqjz4yKCB/EYCuvhi/QAyruDpBcebPYw99MdZES/uyi4PA1W+FhWJNXfUS0yf3 Q6/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=YQHOj/bnPK/nIDomsOi7P10E15gaCTUx4OYWYgBgufo=; fh=TTN0oa3WFJUtiiZeLwaUyL4Yx9teiCcGcP3cnCgSJc4=; b=iOHMUgPjJ8SnsrQt8dKBDt7WBzhFL0NnoLnZzddjX3U9L7OfYHNR49io2+FFRsoqa2 u2MyigSaAee6+i3MdrN/7TXYTNdH+GtB+wIdSnUXingqQxcf/IyE+lfHkf4YICtj9ieR BfdFInG4D3lPpEfqoBThF87iDNuAmaEPsMU4OOQnWU0yU9ccq5z9fogtt4YXahICvMTI mJngLnauhqyMgU8UFLVcLN1frCGo2BPIIi4BE3OdAnA5n13pclHLddjFwEAFM599HsMh 98o6iKGpEjHwwBXs654PM++X71CUj5SnDQhLgILQpJVHBCs03Wp4wn3v4ahp5tfHg1zg IvgA==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775148836; x=1775753636; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YQHOj/bnPK/nIDomsOi7P10E15gaCTUx4OYWYgBgufo=; b=gQ1qS/1YA0agK+v2m6lwP9L10tKJmlyVhBVKetXJ0JKx0wwv2Rl/IvvMiYW8JbFRYW luUZbAyVylQjfNUk2JzwzM2ZRxL7RaToiPHhgqhP3StSausa235cDguB+DeID9YzFnBH wiEmtbfImNb4nTQKAebiGvwSe2orLHP0vhd7QaL0MqfgBIgja8iWZ5bWKtIYEetiOQ1S 19f3b+FGePVkW+asHcNVGhkR6d/zC8wBh8Qdo5OnmmDavKbd0T4lzFobkMJ2zVJkxXpX q8eeAL/zijCI98ATxAbdjZGmrWKkmefe7tMn5bDDxj643zlB0iqA6ql8D9tVyn+rKYFS 16QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775148836; x=1775753636; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YQHOj/bnPK/nIDomsOi7P10E15gaCTUx4OYWYgBgufo=; b=cXxSFVlzLf4w7c5+jsl0AiOf7nnEFuIhAN8vS1EYlPV0aFC/HY8fLgYc8nqQMoowx7 oYv/CHPELEkiEuOE5PUFzUV7P348tbkVvWswPwKdrXQHcv86zRe8OqVIHvmEBEaTlWCv j4dvkMC3dToEj1nqkL0QTfJUkw+MjbXX09KnNeVdUIrWaoyRF9mpNO95DNANlH34V7EK rUn8RKs9mnOwRxJQSQ+yEhO76xxHjJAJ3apdlNqtVeMCNXF6NiaFgx+JxTKKhx69CQbc J4LWcwNUNPlE4+tTM75wl9Q9G795eQncvm8LVJ0FrPFWE58r1vhi15RSC/H+rIwW0tnR vU+Q== X-Forwarded-Encrypted: i=1; AJvYcCUPDlrzpW5/aRU7i6sRA3HSRrTU6ic7OgptjtifSoOK13WBwTp68PquOvXm5WSc5QFUp/Bx/gAFtaByzFk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7bjFlgjbpSu/Lprnd1I4oy6FZNgLfQdh/96dZAh0uL2K7sZe0 IuvuvZ1SHmmXqK/Iq/DkuV4B8BWwqDZDEuJjhrAXQH/ULrmIu5jolJQg7ab9IrSkG9UDdP338cr KjrhbkDG7/aPBQROhAw3DdeBGmWugSTw= X-Gm-Gg: AeBDieseD9j81fiielPjp2eRa2mKj5EthMJJlZMqGBbTqj+9Frx5IYRNFGofJMIVi5Z 4thu3Y/ae9mxO+C8C9HKNST/F+ASJSo8jcZk0KmWpxPj9Xo954YApUCHvh89Ln05hmZ4ug8SY0v nwIfvI+3z4AftH8zwIPRAOPIxEXWMvFzRXDstCVWGx9sFX/xmvgLzAIzstKn/rJQoWQ7MdTsJOR g6OHH+flPxEvHdW5M4ehEYfB+P1aClmRHfozoILZX9zi9bkxOeXKgPfJVLLFO4SPeeZ7X/w2Zju w5QEpciOAtVcJdTuZNoPQZup40l5wH+H4zwE2tQ= X-Received: by 2002:a05:6000:15e0:b0:43d:1c75:db70 with SMTP id ffacd0b85a97d-43d1c75dc44mr7692327f8f.15.1775148835462; Thu, 02 Apr 2026 09:53:55 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260401041929.12392-1-CFSworks@gmail.com> <20260402080542.293e8729@kernel.org> In-Reply-To: <20260402080542.293e8729@kernel.org> From: Sam Edwards Date: Thu, 2 Apr 2026 09:53:43 -0700 X-Gm-Features: AQROBzCjWRVG4OPIJXMJdioZXiZLwrE45OlbnJvHM-A6xPnlux3hujAChNQ6Gwo Message-ID: Subject: Re: [PATCH net v4 0/2] stmmac crash/stall fixes when under memory pressure To: Jakub Kicinski Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , "Russell King (Oracle)" , Maxime Chevallier , Ovidiu Panait , Vladimir Oltean , Baruch Siach , Serge Semin , Giuseppe Cavallaro , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 2, 2026 at 8:05=E2=80=AFAM Jakub Kicinski wro= te: > I meant we need both a threshold, and a delay :( Hi Jakub - got it: when the critical threshold is reached, allow the NAPI instance to sleep and start a timer instead. 1) We'd either have to leave interrupts masked or let them race against the timer. Either one is manageable, but I feel like those interactions carry *just* enough regression risk to bump that patch to -next. 2) Could you point out which NAPI driver best handles this situation? I'd like to replicate its approach. Thanks, Sam