From: Paul Moore <paul@paul-moore.com>
To: vbendel@redhat.com
Cc: stephen.smalley.work@gmail.com, eparis@parisplace.org,
omosnace@redhat.com, selinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selinux: fix double free of cond_list on error paths
Date: Wed, 2 Feb 2022 11:04:42 -0500 [thread overview]
Message-ID: <CAHC9VhR4eTEOO2m=HXYdG89mDBOPnd5BcWLwMCO-qZ8BWNMd9Q@mail.gmail.com> (raw)
In-Reply-To: <20220202112511.18010-1-vbendel@redhat.com>
On Wed, Feb 2, 2022 at 6:25 AM <vbendel@redhat.com> wrote:
>
> From: Vratislav Bendel <vbendel@redhat.com>
>
> On error path from cond_read_list() and duplicate_policydb_cond_list()
> the cond_list_destroy() gets called a second time in caller functions,
> resulting in NULL pointer deref.
> Fix this by resetting the cond_list_len to 0 in cond_list_destroy(),
> making subsequent calls a noop.
>
> Also consistently reset the cond_list pointer to NULL after freeing.
>
> Signed-off-by: Vratislav Bendel <vbendel@redhat.com>
> ---
> security/selinux/ss/conditional.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
I just merged this into selinux/stable-5.17 and I'll plan on sending
this up to Linus tomorrow, thanks Vratislav.
--
paul-moore.com
prev parent reply other threads:[~2022-02-02 16:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 11:25 vbendel
2022-02-02 16:04 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhR4eTEOO2m=HXYdG89mDBOPnd5BcWLwMCO-qZ8BWNMd9Q@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=eparis@parisplace.org \
--cc=linux-kernel@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
--cc=vbendel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®