From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BED0346A07 for ; Sun, 12 Jul 2026 16:22:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.214.173 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783873339; cv=pass; b=KBMrSOZEk4OpLAhROIiu0Xf7YSEBKeB8Eewv8v233d9iR3CvAKyOMgSvvaDTBKzzNdflx0NVKIv2ggLfq84oAu9Fiox4Sgeqf/53xO71+epBNe8iao0f/TRaZ1aaCKlH14sovjiy/bEKkYu9q3zq/Aae6KYZtXfpEx6HKJ/xVUI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783873339; c=relaxed/simple; bh=J+iZNQQvMSCXr2hbBHz7Wo3mc0Gi3r0duqYAG2oZu7c=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=IiptjPsE0Ku1thVpaEP+txoyVwRiQiu+ekOwvqLWj3471e3xDmc9Kt842mMcLQLTosTI/lHjWSjwznAyvRLqzP6cItdaeMpfQjsATVvtHvqLePoUZHJtXfSgY8zYmw25L9cW2uCF9uD3TNcJhfiyI1rrM/z3m62YXS7Z4M5xIrk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=RacuGe8L; arc=pass smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="RacuGe8L" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2cc6dd436c6so28166235ad.2 for ; Sun, 12 Jul 2026 09:22:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1783873337; cv=none; d=google.com; s=arc-20260327; b=sL2VurgjLVYevv2tDsRWu5cdpgmonijBtfr/0s6oBqaGNubVvS6TK+WGafIAW0yKtq 8PREiIFaCJz3kUvIFLGk/AHSq4IuOs+eTrBVJmV09wmYNal1HRoGlTbepEaQ0zNsTltN xYP/fvXZSUzilMb4pyDicNgL1tMoQCxoYq0HH1hToKm/XltBFxH6spyCU887SRLiNWwi N9Wem9ocG8FUwPgMSKGSrJJ/r1S0Oud8rI3mRrPVDDTtMZX13VSZTHQEjY7G2m7FN6z0 uwbntSEscA4e1mNwLRx0NzC4PISOal4rW0iNq2aS0ff61wuXw41eXbr6lTSJY+gT3NYB CK3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=wNQFSIoiUS5yps8KC+SWZ1gAvHIjXV4NMadqHQrQOw8=; fh=+QtfZE9UIvCMK+wVF+Ad9zzH66e5kjUDdmd6IU/oFwE=; b=AV+/ctkLLfTFtfI6G/SG6T313X524tdOrO0HcrJpvazya+s9f7NjPp6Oixd31oUrIF r7zs5dBSg++g6+uFnvB3r/n5TZUVSOdGeB6BMJyD8BalQElJC4OIgSLJOEoQQFAiz1nH 0ynHBjNxdFya+KpHLp4FH8xs9US0O9K5CO5jwkW+5q4LG6K9Ru8qkOeayp0wBAl7xagi PIslG/nQ37jgpVajsCR+MQIn2x0swvWr9mh5KyJdFi12gzWLL3UQzKt43eJ92BRArGfu KtD+ZnujTMWKRKmBvavCmmjX76kma2YLEcRmrMW+TVsO8o67c60jb0JlgrYYVd4YmSgb bWPg==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1783873337; x=1784478137; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=wNQFSIoiUS5yps8KC+SWZ1gAvHIjXV4NMadqHQrQOw8=; b=RacuGe8LN4plnA3Xo9TIQCTzwQDNnp6xMSC0wc9wW1zydSoq46Rz/4tcx4cc/paW1M foJEUEpl8KDGifywcNLPBrHUaBXperRJBeavl2NA9e1Qmi2SOnvWTCF+gEP0gtw44fuq U9wR9IcP4dVNglv3a55eluPRqyojM0A18tmXSQOEqi+mdK5WKvw4LVpPK7h8vMV+h2NH ePzOZHWyBcRSfjk2z956w5cD4wn7ROrQjtfSZ14R2486Tp3roKrerqHvaNOPq0gO+IAm dVuQI/oQEsFmrXJa4+3aCGSo4vDJXf76rkR0jDTDonTylX+vsatHMYIkC7SoBlzFkLS0 Hd7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783873337; x=1784478137; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wNQFSIoiUS5yps8KC+SWZ1gAvHIjXV4NMadqHQrQOw8=; b=P24Ugl8YGhJP/nfPMRhLYU6QC4uwv6L+vw2T773jCCf7oVZwxu+HvKegYCbwJp/MV2 f00abiuPMZfM/cCJTXmMJmWnUgPGS7+ZzNnTFknY75YyPoqVf/+8LS7kbTrgij8QHyp1 0AqxWv68qpguchJZtWYB7LRutpT7J/EGPV+TtvO70Nt9cGv+9IejHxAwXt81fuoSMBee Yvt8xFsqfYpes4Mz566Pavherbe8fxMVlDcjLCMLJcoK/6tNAvJ0b34Yn+H4yXMubS+M Mw4EUQW9D4b4ZorGdPEVBsxWi3O8vrL1svOZ7kC/jEqbkEj9vwKNY4fukJqoOtfFDgp6 twNg== X-Forwarded-Encrypted: i=1; AHgh+RpY7tTyO7mfnMsLMDuizRzS5VLQaoONIHHkE0SkkDxKbAB7BWQ7SDc3NlK6VJ6g6wcOabq+EeR66pw3Xz0=@vger.kernel.org X-Gm-Message-State: AOJu0YwTWXVGp/FoNCaEh0lXDZqBaJo6YJTOZ6w8gcfNZYWt9DQAsJAh jEmTm0q8/zm3yy58J3f1/nUiys0LDeHuNTgKl6WO8zsrVnbPw/8Aafrg+hQ6Xeqy52S4X5muldl iWBPWVlUqt+ozB1W58sZ0ODutVpupceNCokhRnOat X-Gm-Gg: AfdE7clOb2nAWy6rjQ+fgQOsC1SgGLjXGfMov4Fuw7Xx0MNh/e7m98miMFRywjlvFth NwD/YgG0mNTN1cBZ4YST8qEBhFBbn3WNhbHIDpnr30FDPZ4b9IqSgqCLBrgi/6SD7H92OMFVQcM U7Qva2bcMkzIp0l7HWmnpztF+ACLhYcGjhalxRqAjHI74Wk4ncJyPorpySI9BhraOMNnGGNA5LT sMJaibNnuO7WTZYpcWNvb5RokbFnDdqh1IGh/jT3xUN0Y3zZJ94fMwgDFm2IKeCNUgPtqzFygrD y03ZMrk= X-Received: by 2002:a17:902:f706:b0:2c9:97a8:afef with SMTP id d9443c01a7336-2ce9f3c2c44mr56463405ad.40.1783873337523; Sun, 12 Jul 2026 09:22:17 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260712013941.4570-1-fmancera@suse.de> <20260712013941.4570-12-fmancera@suse.de> In-Reply-To: <20260712013941.4570-12-fmancera@suse.de> From: Paul Moore Date: Sun, 12 Jul 2026 12:22:04 -0400 X-Gm-Features: AVVi8CeR6p9IFdHxiLZpYHAlyp8c47JdAudStQqM7LnXYkS82gL2ns4MbJCsLNc Message-ID: Subject: Re: [PATCH 11/13 RFC net-next] net: cipso: guard IPv4 packet manipulation functions To: Fernando Fernandez Mancera Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, dsahern@kernel.org, horms@kernel.org, idosch@nvidia.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Jul 11, 2026 at 9:41=E2=80=AFPM Fernando Fernandez Mancera wrote: > > To enable compiling the network stack without IPv4, the CIPSO functions > that manipulate IPv4 options and generate ICMP errors must be bypassed. > > Ideally, CIPSO should not be compiled when IPv4 is disabled but > currently it is too integrated within netlabel, so let's just bypassed > the relevant functions. > > Signed-off-by: Fernando Fernandez Mancera > --- > net/ipv4/cipso_ipv4.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) I think I would prefer to make CONFIG_NETLABEL dependent on CONFIG_IPV4 at this point in time. This will keep the code cleaner and allow time to do the proper work of wrapping the CIPSO code with CONFIG_CIPSO (or similar) and making that dependent on CONFIG_IPV4. --=20 paul-moore.com