From: Paul Moore <paul@paul-moore.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: Linux-Audit Mailing List <linux-audit@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Eric Paris <eparis@redhat.com>, Steve Grubb <sgrubb@redhat.com>,
Kees Cook <keescook@chromium.org>
Subject: Re: [RFC PATCH ghak21 3/4] audit: add refused symlink to audit_names
Date: Thu, 8 Mar 2018 19:33:58 -0500 [thread overview]
Message-ID: <CAHC9VhTdG9imxWx_3eRPtv0Az79GBTtCy2P5EOgiXMDNB2SyMw@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhQDLuJ-T9=4YR_vrch-KqAGC+54ZVMsb84yNZpHCrj8bw@mail.gmail.com>
On Thu, Mar 8, 2018 at 7:30 PM, Paul Moore <paul@paul-moore.com> wrote:
> On Wed, Feb 14, 2018 at 11:18 AM, Richard Guy Briggs <rgb@redhat.com> wrote:
>> Audit link denied events for symlinks had duplicate PATH records rather
>> than just updating the existing PATH record. Update the symlink's PATH
>> record with the current dentry and inode information.
>>
>> See: https://github.com/linux-audit/audit-kernel/issues/21
>> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
>> ---
>> fs/namei.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Merged.
Scratch that, not merged, although only because I think we need to
refactor patch 4/4 and the refactoring can/should encompass this
patch.
See my comments on 4/4.
>> diff --git a/fs/namei.c b/fs/namei.c
>> index 9cc91fb..0edf133 100644
>> --- a/fs/namei.c
>> +++ b/fs/namei.c
>> @@ -945,6 +945,7 @@ static inline int may_follow_link(struct nameidata *nd)
>> if (nd->flags & LOOKUP_RCU)
>> return -ECHILD;
>>
>> + audit_inode(nd->name, nd->stack[0].link.dentry, 0);
>> audit_log_link_denied("follow_link", &nd->stack[0].link);
>> return -EACCES;
>> }
>> --
>> 1.8.3.1
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2018-03-09 0:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 16:18 [RFC PATCH ghak21 0/4] audit: address ANOM_LINK excess records Richard Guy Briggs
2018-02-14 16:18 ` [RFC PATCH ghak21 1/4] audit: make ANOM_LINK obey audit_enabled and audit_dummy_context Richard Guy Briggs
2018-02-14 17:51 ` Kees Cook
2018-02-15 2:33 ` Richard Guy Briggs
2018-02-15 6:16 ` Kees Cook
2018-02-15 22:51 ` Paul Moore
2018-03-09 0:23 ` Paul Moore
2018-02-14 16:18 ` [RFC PATCH ghak21 2/4] audit: link denied should not directly generate PATH record Richard Guy Briggs
2018-03-09 0:26 ` Paul Moore
2018-03-12 8:01 ` Richard Guy Briggs
2018-02-14 16:18 ` [RFC PATCH ghak21 3/4] audit: add refused symlink to audit_names Richard Guy Briggs
2018-03-09 0:30 ` Paul Moore
2018-03-09 0:33 ` Paul Moore [this message]
2018-02-14 16:18 ` [RFC PATCH ghak21 4/4] audit: add parent of " Richard Guy Briggs
2018-02-15 23:34 ` Paul Moore
2018-02-16 2:59 ` Richard Guy Briggs
2018-02-16 18:56 ` Paul Moore
2018-03-09 0:50 ` Paul Moore
2018-03-12 7:59 ` Richard Guy Briggs
2018-03-12 15:47 ` Paul Moore
2018-02-14 16:49 ` [RFC PATCH ghak21 0/4] audit: address ANOM_LINK excess records Steve Grubb
2018-02-15 3:46 ` Richard Guy Briggs
2018-03-08 11:47 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhTdG9imxWx_3eRPtv0Az79GBTtCy2P5EOgiXMDNB2SyMw@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=eparis@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rgb@redhat.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®