From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20C081917CE for ; Thu, 8 Aug 2024 17:19:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723137584; cv=none; b=OnzSFZ+RLNNF2VfpMldw8ZeKe5X5f15vU9G3dm18wgBezjymmIkf0oVfsU2guszQtMfc71Lq62kWI0TAaJcuS6Dj5aNi8/rXP6IAoK+srJbuz3iDdh9PxvgGO1FJ3/4lJzWfBInWnPJ2pW2onhWCyrE9Xo98mpMQ/SABricMKSk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723137584; c=relaxed/simple; bh=UTK3MbTaCL1n1/5i9jTkY9GsZk+1O6VCjq62oiu9i98=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=DFzujKoyNTkjr25hyVuSjUbk5+lIdB9nzH/Yc89r7fFDkGPCrj3ddvWeNGWJOvKfE4ZbQA5oUpjvqrK8SQbUhaSuqzhoE3SwXtYMybM9Q/wu4XauqiY/t+THpPv8+f5NyfiNszwdCEUriiO9CFCazZ7C5htKuKL/JwC6X7TVmm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=BMlXRMmq; arc=none smtp.client-ip=209.85.219.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="BMlXRMmq" Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-dff17fd97b3so1155527276.2 for ; Thu, 08 Aug 2024 10:19:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1723137582; x=1723742382; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=k7j4id+E0N59hINJSa1Ik/tq6mBYW9RIP0gt258DV/U=; b=BMlXRMmqo3nNOfPAuzmFLhr9ar++2lcMfEqHyuhNHE7SUrvLeRzim3yjIlMKSJYiMl s4U+1ufIfxI36brhEFrbDuFjQDN7f74tgPtVzcSui2gYT6OOXV+8f2udORV4fR2wQ9qH Ee8glQm+tdYhbi7uNqvGCwnvR3q04eGqqZSIWktZtFpFskFjmb5kfXfNN5OillaJ43xa caHxH/8HsPl9WtTXHiQZ6r2ugZV0vNWctSNdiQu5Qm6reEWZzc3+Vf34FU9HHlSav2vk Cii2qi0g5VBy5o99YjTGC4gr3rckcEBtUOLTuqdUCUZgb0sIal2ZQMlWKOe36RLI/TG4 XA+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723137582; x=1723742382; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k7j4id+E0N59hINJSa1Ik/tq6mBYW9RIP0gt258DV/U=; b=HWXYi5+JnSI8vd7bCet3cS4JiYpCytX/goaUGFY7pMSWE6HZiGxVNwEYO1dvw0A3pz qCW/1KXxV6saKsuTgvNbbAPh5BTIRhMst2ClI1HhEYQCPoSh/kRMEpUn5MykrEVpDSHW XtIdQffm/BYQKty4sguQzGHsxmJdU/15mExFBTX/uCasG+lrj4E8TmzZyiwqMV2XMLcq v77gkPjup6fyx4zpfvX2KWZQ3weok311eoxktUno11jpFWdemOLMJzs1wTSAfEhDnBNl p8t++/HWvlICDFuC/PgQynMUyKM4cJTO4QV0LMpYLCXLD2/YQ2R3aPw9FVsmV6G5r2NV rSwA== X-Forwarded-Encrypted: i=1; AJvYcCVy5Mx1K0mhdt5q38JkeKOtPtNpzjQDsQXSWNCvlSHw2ShvQz9ybmVLtq0KPnE0UxqdoqtFxjcCZoTbnOiNvHjV+tR7TwcwmiVt/AIr X-Gm-Message-State: AOJu0YzYQJ30xBBRF2lat+WCAfnRn0IW63YvNhUvKmCH1BgCv+3Hbkhn tGQS280pBBhHaN6CmnjEF/1ZJTjF6X7u2k6qCQoJdPYJPQOaWk5rmTGaC/Jy//n6a4OLRiwJNyj BzlGjFrNIiMLNfo0Gi4CFECxipYfcn6UV6rhX X-Google-Smtp-Source: AGHT+IGFllm8smp8j3SS8Lkq9w2mfD8VByKiAxaIaEgk87F2tTSALoLQCwnk+1HhpjXBLzVARdifZYrNQLu26MduEDo= X-Received: by 2002:a05:690c:f83:b0:65f:7ac6:7f69 with SMTP id 00721157ae682-69bf7353562mr34263017b3.6.1723137582068; Thu, 08 Aug 2024 10:19:42 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240801171747.3155893-1-kpsingh@kernel.org> <20240806022002.GA1570554@thelio-3990X> <873b04da-7a1e-47b9-9cfd-81db5d76644d@roeck-us.net> <779dfb7f-d690-432e-8461-b26935974ac6@roeck-us.net> <0673d2b2-ad78-46f4-93b2-73ea3acd70f7@roeck-us.net> In-Reply-To: From: Paul Moore Date: Thu, 8 Aug 2024 13:19:31 -0400 Message-ID: Subject: Re: [PATCH] init/main.c: Initialize early LSMs after arch code To: KP Singh Cc: Guenter Roeck , Nathan Chancellor , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, bp@alien8.de, sfr@canb.auug.org.au, peterz@infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Aug 8, 2024 at 5:57=E2=80=AFAM KP Singh wrote: > > This seems very odd for especially ARM as I don't see this error when > I do it on the next branch. Possibly something in setup_arch is > initializing jump_tables indirectly between v6.11-rc2 and linux-next > and/or this is a warning that does not immediately splash up on the > dmesg. > > Both ARM64 and x86 (the architectures I really have access to) > initializes jump_tables and x86 is the only architecture that does an > explicit static_call_init is x86 and it's already in the setup_arch > code. > > https://elixir.bootlin.com/linux/v6.11-rc2/source/arch/arm64/kernel/setup= .c#L295 > https://elixir.bootlin.com/linux/v6.11-rc2/source/arch/x86/kernel/setup.c= #L783 > > Guenter, I have updated my tree, could you give it another run please? KP, once we've got the ordering/fix sorted out, can you make sure the reasoning is well documented in the commit description? From what I'm reading here it doesn't seem like it's something obvious, so providing a detailed description will help us several years down the road when someone changes something and it breaks again :) --=20 paul-moore.com