From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C59E8FA372A for ; Thu, 17 Oct 2019 14:42:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9972421D7D for ; Thu, 17 Oct 2019 14:42:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TJ7k3wmZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440331AbfJQOmj (ORCPT ); Thu, 17 Oct 2019 10:42:39 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:34103 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437444AbfJQOmj (ORCPT ); Thu, 17 Oct 2019 10:42:39 -0400 Received: by mail-io1-f67.google.com with SMTP id q1so3342426ion.1; Thu, 17 Oct 2019 07:42:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yZfbOZSDn+GBucwbwmrlt57XdpVLll7ReX3tKoRiDII=; b=TJ7k3wmZkSmZRGwxzXl8ni5apLcRVgyHgXlVZmTN853xTgCywU/jS0DRpyulXktKFA Wp5w0u7G+QgTFBqleHVpdPHvgKQw8R/XFCh+6Aaryw5X//uTOMzLki38ytR1UJuFoq+C 3g0hW5wewWMw4tgNkkLZTLKUqgtUXoi66j6vHQn1vIu6wOChW22lKO84gWBbDo/wWpe2 1mdY3E1meYerma5fd4CpxB9XcYkjqRuqVXmcn7SoTH+6V5tFUbn095naw9fDWlnv3y49 nS/tHvzPsGSsWryqvHENpkEL2d0Doru2/Z10qEJnaJN2n7qglLiQ1KcLwGkPhcs0YyMd /sqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yZfbOZSDn+GBucwbwmrlt57XdpVLll7ReX3tKoRiDII=; b=FGoYEhAPJfi1CRKp+yQSirErGNcpNX3mcAzH+wm7aU8Lu78y2tZwvG0qwBaGCD171d 6UmWq8/pkpfuw09y6ISSWVO3ipxGndSAnMSPXsCuYbpU3mPKlFgLiKopJ5scqJlii6zP 02wswYSDtNYmCjW85IW3RpH62aIZ/wFcJ+3LgzDkfPCtAR6q771r7mNflG7THbzWqEko aOkL3y5a5W01CE9EJAp04f8vFuDcLqMzLy8PgNX9ih12wx/ebED05OwXExKwBsIqp8Ji 3da1Y9c4gISQZh1yEYS8GSsfIZQjS0iR7J00RE8WmR0PmMwzlofXdX0sM1+JhyPzDizZ 9Edw== X-Gm-Message-State: APjAAAVRiOVTS8hAzTFLcHq79AbitSZzCAac347Tzq1V0UjQhg6nbUhO IYTratwtiTbToaJW3F5vdmUsScTOW5eP3gTAz/g= X-Google-Smtp-Source: APXvYqxLMVhS21hkfBuFNR8qm6HuMhexXhE0GwnhHg2kroaMYxz+FIVQK8husib62kCR6sWcwBK85nJh3Drpu3O6VnU= X-Received: by 2002:a5d:83c1:: with SMTP id u1mr3466467ior.78.1571323357719; Thu, 17 Oct 2019 07:42:37 -0700 (PDT) MIME-Version: 1.0 References: <20191016135147.7743-1-aford173@gmail.com> <20191016135147.7743-2-aford173@gmail.com> <20191016144018.GG5175@pendragon.ideasonboard.com> <20191017143738.GA10960@bogus> In-Reply-To: <20191017143738.GA10960@bogus> From: Adam Ford Date: Thu, 17 Oct 2019 09:42:25 -0500 Message-ID: Subject: Re: [PATCH V5 2/3] dt-bindings: Add Logic PD Type 28 display panel To: Rob Herring Cc: Laurent Pinchart , dri-devel , Linux-OMAP , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Mark Rutland , Sebastian Reichel , Tomi Valkeinen , devicetree , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 17, 2019 at 9:37 AM Rob Herring wrote: > > On Wed, Oct 16, 2019 at 09:55:11AM -0500, Adam Ford wrote: > > On Wed, Oct 16, 2019 at 9:40 AM Laurent Pinchart > > wrote: > > > > > > Hi Adam, > > > > > > Thank you for the patch. > > > > > > On Wed, Oct 16, 2019 at 08:51:46AM -0500, Adam Ford wrote: > > > > This patch adds documentation of device tree bindings for the WVGA panel > > > > Logic PD Type 28 display. > > > > > > > > Signed-off-by: Adam Ford > > > > --- > > > > V5: Replace GPIO_ACTIVE_HIGH with 0 to fix make dt_binding_check -k > > > > V4: Update per Rob H's suggestions and copy other panel yaml example from 5.4-rc1 > > > > V3: Correct build errors from 'make dt_binding_check' > > > > V2: Use YAML instead of TXT for binding > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml > > > > new file mode 100644 > > > > index 000000000000..2834287b8d88 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml > > > > @@ -0,0 +1,42 @@ > > > > +# SPDX-License-Identifier: GPL-2.0 > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/display/panel/logicpd,type28.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Logic PD Type 28 4.3" WQVGA TFT LCD panel > > > > + > > > > +maintainers: > > > > + - Adam Ford > > > > + > > > > +allOf: > > > > + - $ref: panel-common.yaml# > > > > + > > > > +properties: > > > > + compatible: > > > > + const: logicpd,type28 > > > > + > > > > + power-supply: true > > > > + enable-gpios: true > > > > + backlight: true > > > > + port: true > > > > + > > > > +required: > > > > + - compatible > > > > > > Should the port be required too ? Apart from that, > > > > I supposed that's true, but I used ampire,am-480272h3tmqw-t01h.yaml as > > the example, and it doesn't list it as a required item. > > Is there anything else I need to address? I feel like I'm trying to > > hit a moving target. > > 'port' can be omitted because the panel can be a child node of > the display controller instead. That's decided by the display controller > binding, not the panel binding. > > Reviewed-by: Rob Herring Thank you. Sorry it took a while to get there. adam > > Rob