From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B702DC4708C for ; Wed, 30 Nov 2022 19:45:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229499AbiK3Tpt (ORCPT ); Wed, 30 Nov 2022 14:45:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbiK3TpX (ORCPT ); Wed, 30 Nov 2022 14:45:23 -0500 Received: from mail-ua1-x936.google.com (mail-ua1-x936.google.com [IPv6:2607:f8b0:4864:20::936]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FE1886583 for ; Wed, 30 Nov 2022 11:45:17 -0800 (PST) Received: by mail-ua1-x936.google.com with SMTP id m5so6572437uah.3 for ; Wed, 30 Nov 2022 11:45:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=d74Ux9XASnvU3YsAvcNYJRwNMvF0Ld8sCW80w/+NTE4=; b=j28NVgl4hCm++QbB7qCOUtkzWy/v59pO1/o+zat2KKRnzaBDA9auy79+yMFyfeHozY O8UmY73hAZaYuSwradcNQVtE4HbpFPjTDxkLSMq2YdoDkO1lcoXgQJTyH2fUudSZJgC5 VBP5QabgJfTAUoei4mABHncJJGGGRi7anWkbVLpi0E+yzvQZdpwDlqKaUa4Q92t4IsZD o2C2j/dJoOSZ1dbwUISLxLapwtivpEougXjZlEMs1BWXkT5fhryOWhhCVvL25ogAsvfp ruTQESZWjtyVnOb/ieUzCNZaW6+5QIOKKytt/WwI2PjwBI2ERZzex4Em7IVovUebkd4c 7J2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d74Ux9XASnvU3YsAvcNYJRwNMvF0Ld8sCW80w/+NTE4=; b=vhuLJaiUcvNqhANE0bvi/IlhgywvVb9ahU0ry/i8ty+J9jFi6ksNEthpxurN4E5pLi R8Ilfl1CLe0IDigQv5XbtVOFPtXGUdrvlKx8kyeLm5+awZhu+S+bOSQMJ1talaTXdump lbfTww+sDl327y9PurxeFRQxPB4fjXTx0WYrXeGPIZAeF8ZM5ljg1BIcTplymUru7E59 PnJaCvnlWzc/M94WAiljdrvBZJd6Td9Lxj7L0WtgxeErmAqzj2drJ5FmHjaVkQe2mZtz T77jt1NeVVITGnXyU6MK4/ZuTVutHRU9VHVVI5z9TB0IGEHpJa7BSW+/SQYuFot7mNZU AUSg== X-Gm-Message-State: ANoB5pkHuwEViW0kQReccTWQA2WibAKeHuNahgl9Ui+e9LzwcVqpvY4T bntfuWUYGxL0zZwrxivCV0moqTz9eFQDJ3SyEtSVnQ== X-Google-Smtp-Source: AA0mqf5KD4A8huxx7YUTV1uBRe6MiSEHlskOPgRJdmk6Dpy74DbA4bP6E6IUjfKwIreVf8z7VpdE6ptsp6B7u2VZpQA= X-Received: by 2002:ab0:7283:0:b0:414:43e4:b32f with SMTP id w3-20020ab07283000000b0041443e4b32fmr36770854uao.18.1669837516463; Wed, 30 Nov 2022 11:45:16 -0800 (PST) MIME-Version: 1.0 References: <20221130020328.1009347-1-almasrymina@google.com> <7c5e0ca5-0ad1-452d-60b9-50dbb63d2dee@gmail.com> In-Reply-To: <7c5e0ca5-0ad1-452d-60b9-50dbb63d2dee@gmail.com> From: Mina Almasry Date: Wed, 30 Nov 2022 11:45:05 -0800 Message-ID: Subject: Re: [RFC PATCH v2] mm: Add nodes= arg to memory.reclaim To: Bagas Sanjaya Cc: Huang Ying , Yang Shi , Yosry Ahmed , Tim Chen , weixugc@google.com, shakeelb@google.com, gthelen@google.com, fvdl@google.com, Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 30, 2022 at 12:44 AM Bagas Sanjaya wrote: > > On 11/30/22 09:03, Mina Almasry wrote: > > - This file accepts a single key, the number of bytes to reclaim. > > - No nested keys are currently supported. > > + This file accepts a string which contains the number of bytes to > > + reclaim. > > > Amount of memory to reclaim? > I want to have the word 'byte' in there somewhere to make that clear. I guess maybe 'the amount of memory to reclaim in bytes'. Although as written it seems more concise. > > + This file also allows the user to specify the nodes to reclaim from, > > + via the 'nodes=' key, example:: > > + > > "..., for example" > Will do in the next version. Thanks for taking a look, Bagas. > > + echo "1G nodes=0,1" > memory.reclaim > > + > > + The above instructs the kernel to reclaim memory from nodes 0,1. > > + > > Thanks. > > -- > An old man doll... just what I always wanted! - Clara >