From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D941CC76196 for ; Thu, 6 Apr 2023 22:57:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239376AbjDFW56 (ORCPT ); Thu, 6 Apr 2023 18:57:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232836AbjDFW54 (ORCPT ); Thu, 6 Apr 2023 18:57:56 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A2D959D8 for ; Thu, 6 Apr 2023 15:57:55 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id j14-20020a17090a7e8e00b002448c0a8813so2629989pjl.0 for ; Thu, 06 Apr 2023 15:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680821875; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JXgNfES2xPmLIzA9XQu7yHUn8Ass15lCW/P1iL99/uE=; b=HR7UuBf4gWbhbVlkBYitBViCVWlQ/s3oikpp4qMOZGC23Wn7C+/HAg9G3DJaHwPKjI /4kFwj7mU8d768xogqeRJbJXcsUQ7YOFigy3I3fttmqsZdBwQy5P68Ti18yaKUjvNx8E ob9nwpa2t3NZCxfEdG89sJjAPcVWust+QqYLfTetUNrgsSuZzuGeR6ylQQKpy5hwLbMx YCvjNrTV5e4AeS5RG4HlfE8fh78Tz32Dy6s+gbvkufNeO+GORoX7obpDKuap4MLo9ael R+A+INy2D5jQTW85sR97Sd5j8GPJX6pdhXUYVbLyPPn91497VoWvQ55Vqt3Ox+HsPl8Y l8KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680821875; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JXgNfES2xPmLIzA9XQu7yHUn8Ass15lCW/P1iL99/uE=; b=bpybsfauoOZKg+09vkvLsgG/CMX3D4Qhll54avDZAbECg4hQuz4fEsx2cHDhk3qyaW r+xuBF4bW14CDjks+yQtkDlBeBp0kDR2YVHyo9Cfj5di3uKks868DaTyahfZlVaN124y ZJxmhkkXlCrL8VhGwv/HfM0IZmiuqK/OQzB60vjEQmPY33nsx+WbC2cf4qdii/OH9mnW RLIK6hkUtu40H5PIPCWc42I8HpbFyUWzLYb4cV1nOWVQdyg94mxAuvbu/XGqAtQMkLZS +PitoBlaN/zpdEaEuDxAgQguu4/aXQrTQqucuCfO1Mx+oHCRbHOiLmK8h7saIjM8GFDh tBxA== X-Gm-Message-State: AAQBX9c6tJtkxC4M4sbutK2Nacg7gQ/oihFHgfpV8QR+c3C1jJOtXSDS cOsizoWthaijOEbGGwe3z+7k2vpxyYYO6Hm50XvFJdjQ X-Google-Smtp-Source: AKy350Yh8xcHrviJawO8dzK8guWnatfjmYEClFJYOUxp53fgYbHjXiICm9F7JoMQh0LwehWyiEjx8T3vVLTGlkq9LzY= X-Received: by 2002:a17:903:2449:b0:1a0:1f4e:a890 with SMTP id l9-20020a170903244900b001a01f4ea890mr266381pls.1.1680821875058; Thu, 06 Apr 2023 15:57:55 -0700 (PDT) MIME-Version: 1.0 References: <20230406082004.2185420-1-naoya.horiguchi@linux.dev> In-Reply-To: <20230406082004.2185420-1-naoya.horiguchi@linux.dev> From: Yang Shi Date: Thu, 6 Apr 2023 15:57:43 -0700 Message-ID: Subject: Re: [PATCH v1] mm/huge_memory.c: warn with pr_warn_ratelimited instead of VM_WARN_ON_ONCE_FOLIO To: Naoya Horiguchi Cc: Andrew Morton , Miaohe Lin , Xu Yu , Tetsuo Handa , Naoya Horiguchi , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 6, 2023 at 1:20=E2=80=AFAM Naoya Horiguchi wrote: > > From: Naoya Horiguchi > > split_huge_page_to_list() WARNs when called for huge zero pages, which > sounds to me too harsh because it does not imply a kernel bug, but just > notifies the event to admins. On the other hand, this is considered > as critical by syzkaller and makes its testing less efficient, which > seems to me harmful. > > So replace the VM_WARN_ON_ONCE_FOLIO with pr_warn_ratelimited. Makes sense to me. Reviewed-by: Yang Shi > > Fixes: 478d134e9506 ("mm/huge_memory: do not overkill when splitting huge= _zero_page") > Reported-by: syzbot+07a218429c8d19b1fb25@syzkaller.appspotmail.com > Link: https://lore.kernel.org/lkml/000000000000a6f34a05e6efcd01@google.co= m/ > Signed-off-by: Naoya Horiguchi > Cc: stable@vger.kernel.org > --- > mm/huge_memory.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 81a5689806af..06bcdd6f5060 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2649,9 +2649,10 @@ int split_huge_page_to_list(struct page *page, str= uct list_head *list) > VM_BUG_ON_FOLIO(!folio_test_large(folio), folio); > > is_hzp =3D is_huge_zero_page(&folio->page); > - VM_WARN_ON_ONCE_FOLIO(is_hzp, folio); > - if (is_hzp) > + if (is_hzp) { > + pr_warn_ratelimited("Called split_huge_page for huge zero= page\n"); > return -EBUSY; > + } > > if (folio_test_writeback(folio)) > return -EBUSY; > -- > 2.25.1 >