From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E20344AB84 for ; Mon, 24 Aug 2026 15:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=170.10.129.124 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787586356; cv=pass; b=Yj1Xcd0odHClGS6AfzLC0HGeexC8+OJ5797ZuyW6uwK9pn5g6gKg+7dzBbY35rtHa+OXXaRhH0hI29QmriVg9mqEG3ZXIRI2ezCaAcitXj5jlMUACO35nroBVB6JcF+cU5rK9B4uKup+tQqh1PG1d0zuiW9RkTRwb6LOEK6HUxk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787586356; c=relaxed/simple; bh=UInqlXNgzhrb7ad8QRZi8Gy1n6MNT5fZ8Q/MycMYy/g=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=FN1ii2BUJgBRXgTN+5UHwJavBNBPJlbNmQ7S2tcNYaGrVsq4gKIQbwQZVtvDhn4c8Wz7c+n1I1vG6KSwuCnRM9u9wywGmYTm9JUFhhLPOjclF0MWrpePgwS+wZKUzNLk4+JoBhQ8XLXOSo44T/p4bt5rwgDk//40OfKcBBSMKeo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AuhDpwdx; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZZKIgzVf; arc=pass smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AuhDpwdx"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZZKIgzVf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787586352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lJThwG3P8wPC5qmnmtgUc4+AUWw/9ToUlOyTB7RPu8k=; b=AuhDpwdxwiRGeb6gJof+Gz4zjpEO8rLciD9PuC07CjfZsaZtcT/AoVxrWtDEDQRPaQ6bCl BMbeEz9YVVNsX3QeUC9ROyfPsMJfNCGOjy4QeyL/sNss7Whx44LBSftv8XlevHUFQf5Sgd 3b1sQyv9qaaWiqzAfHlf9cfadpc4wE8= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-eTr9pyDtOpCoBagD0ZEWMw-1; Mon, 24 Aug 2026 11:45:51 -0400 X-MC-Unique: eTr9pyDtOpCoBagD0ZEWMw-1 X-Mimecast-MFC-AGG-ID: eTr9pyDtOpCoBagD0ZEWMw_1787586351 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-836c4a54cbcso151085997b3.0 for ; Mon, 24 Aug 2026 08:45:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1787586351; cv=none; d=google.com; s=arc-20260327; b=em8gLMrXYG5Y25MA16Ey+moJEuP58qf5dybyd/Cxw2lquHpUGEYB1bmgd28A9smAUz 28+FFyqbrLmhEu3PJUcn9RroepkUicvRRUnvAulgXpjwuX2svlV72iBzlvMyerUiJVEH OyhbQ2GsPHlYnC0fsyWMJFQgHEL5jb1eoKXJFCXVhHwLzc9gvehDQNgMv0ET8xJB9kgI wekNNzpA4PjYoaErc6JnQZLJA1G4yTTvpAEJnwL5aUtpAwIk2m+J5i1MzHUfDNmwMug9 YXnCSWYqEI+iI3QiM/5Dekp553GPyDDm1HpjSm65ipGrEjJn02OzBcwM14P0Ee6r3O4w z9/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=lJThwG3P8wPC5qmnmtgUc4+AUWw/9ToUlOyTB7RPu8k=; fh=SCT30NRRx3a8BQA1O06erLCL8hwvXpVc6MuyzqD9C44=; b=bmOe4FS/3H6V4Prq2S+r2YutbDC8Q0dDPxYbbmHe9F9l7XEttAd+dR3fiyyvG2EIxP wfkn+yYriYswZ/AV/mYV7+HNbEWJqOzjuYJ/1J9Z+S1R1FNzH7dCxtnCGLTipA8ZvPh4 74vjz86IuazedKoLkgUaqGEMW3YdANVDRCMxxRId5EirL+4MPOZOYWF1Ja6BgiPcuqak Wcu8UYhF4Cj8T7TGZhlGPHORTGLybrWBo2XkMVkDnBU7SvAt9Ze/jmz9iSlQSDQjeogS g9Tigr24i9V7ynbFK2Y88e3UeLE8OqMwwzuURGIv82xxR9mRfzUcZfw/xfXFaNcZ1Tpr vlMA==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787586351; x=1788191151; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=lJThwG3P8wPC5qmnmtgUc4+AUWw/9ToUlOyTB7RPu8k=; b=ZZKIgzVf2mauy0amnjta04kLRQ+e6x22rmlnsDGJtOi5/63cfmuNzJEvFOUaV7Q7Ff 8tbAQeZbUpqDJhoCw9P/P3PMSKw+SqHJIXHnowygEfkivxUTD/YipQrUZMSlwMZg9Fbs +Alm6A2V62nx6QmqQXpTsolvDJ1FLF322Oly0HNi6sPX5BKNdSGfoVorZW3TD+lxKXhT hd2Sx4IP7k4AN/nOKfTV1S5MWsZCB+u/wz9gPiLsgWNHvrbTCurkT2zADWMo1V2rfa8Y ubp85bnU2P5eR74TM7aXSwSz4hhQrfvJV38srmFnhMewiCA3aoTkzw+nvSRwMQLG8ZGZ Xcag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787586351; x=1788191151; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lJThwG3P8wPC5qmnmtgUc4+AUWw/9ToUlOyTB7RPu8k=; b=PQeqIr93kRHeUDXMGbCSKP3nNzy+iT3eawrX1GnvCe9DzcZSV1IBniD0S15bRdCcVa tI/hPEFOAl3Ed4E2RyINLvZ24Xyp6rZj5WE6pcrby1Z63wPkUwAGfw0f8HYuglgumX3J E7Wu433KIhnT4yxazKwEGLvKAlKKiG3sI/zaZVyBaZmtVG87GSAUQC7kU1Qd0l8/4mkH cfE6oN9hqLibDusrazrtIU/mKt01FSVstWm1zXqRgAcSx6ywhnW1WijAPrsuto0N1+ZC ekMEoUjVkg27aIE9aHLHVtNJ47mxRIlyU3MmwgnqIhzMldhWsuTqVB6YXza8VtIj8/PS RtGg== X-Forwarded-Encrypted: i=1; AHgh+Ro2QmXMkeytHR4C1KybYDxW9/0ISwIvC7MiRmChKxpq95HwdYMVu05pUrV/AZBUzLYjNEWE/bVQmtvWnrU=@vger.kernel.org X-Gm-Message-State: AFuF++n4A2sUpP/7OJ+qALrlBg097iQnUdpFW17C33j9/dQ7jjCh5WcR PReA3A4DXuADEmKuxKX7W+u8V4CAL8O8YO3JvMBvIwd4AL3rPQvc+nDq6olDK1v1M/VNsQl/DFd FXybjukReG9Mlx8Q3F4RhLTKQXuJrijSl6gI41uUrUjlWvSvUdPQFn/K+fmYtRKUjsqbL9qvoRU ZMUD+ttuln3+UTXeGj0Bv5hfOxVgsQtQIvvYGyf+Ub5nK8MmGONG4= X-Gm-Gg: AR+sD112KcAHsnXaPv71MqWxmVsnKdJdJFtf3BC0DsRq2OhX94TG62QlNfVDhHWehno iG1UWW19fFeetcNaAeyQ8WemZCe1yn6uAG5049WtDkV+lrXcL1CL166R2wuOHPYrk6BmSfRRVAa Zy+T66Mxc4kT6fGGXOzBB1yrBgKiyk6/wUmQMr1VY5XAqRNav6fYVDMnrpMyleVLGm9/3Uu3cyi dcI7IIwqBCcVVqwd1hvDkLbbTzzGsWlS9XBKowJjqd4 X-Received: by 2002:a53:afce:0:b0:66b:3c3c:c89e with SMTP id 956f58d0204a3-66ce4b4ae1dmr8668559d50.44.1787586350945; Mon, 24 Aug 2026 08:45:50 -0700 (PDT) X-Received: by 2002:a53:afce:0:b0:66b:3c3c:c89e with SMTP id 956f58d0204a3-66ce4b4ae1dmr8668536d50.44.1787586350347; Mon, 24 Aug 2026 08:45:50 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260617090143.735219-1-zenghongling@kylinos.cn> In-Reply-To: <20260617090143.735219-1-zenghongling@kylinos.cn> From: Andreas Gruenbacher Date: Mon, 24 Aug 2026 17:45:39 +0200 X-Gm-Features: AcwNN1VnN-ubuZro-Q0sxvU9as55cDmM0fFbTOUQLBDEK-akDtZ-rHK8G7fzWEs Message-ID: Subject: Re: [PATCH] gfs2: Fix use-after-free in gfs2_remove_from_journal() To: Hongling Zeng Cc: swhiteho@redhat.com, gregkh@linuxfoundation.org, rpeterso@redhat.com, gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, zhongling0719@126.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jun 17, 2026 at 11:02=E2=80=AFAM Hongling Zeng wrote: > The function calls brelse(bh) but then continues to access > the buffer head through bh->b_private, clear_buffer_dirty(), > and clear_buffer_uptodate(). > > After brelse() decreases the reference count, the buffer head > may be freed, making the subsequent accesses use-after-free. > > Fix by moving the brelse(bh) call to the end of the function, > after all accesses to bh have been completed. > > Fixes: e93b100931a4 ("GFS2: Fix slab memory leak in gfs2_bufdata") That commit by Bob looks suspicious: bh->b_private data is usually freed by the ->release_folio address space operation, so there should be no need for freeing bufdata objects here. (That has little to do with your commit, of course.) > Signed-off-by: Hongling Zeng > --- > fs/gfs2/log.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c > index 78bba8cc10b8..a92c84146de9 100644 > --- a/fs/gfs2/log.c > +++ b/fs/gfs2/log.c > @@ -1038,7 +1038,6 @@ void gfs2_remove_from_journal(struct buffer_head *b= h, int meta) > set_bit(TR_TOUCHED, &tr->tr_flags); > } > was_pinned =3D 1; > - brelse(bh); > } > if (bd) { > if (bd->bd_tr) { > @@ -1056,6 +1055,8 @@ void gfs2_remove_from_journal(struct buffer_head *b= h, int meta) > } > clear_buffer_dirty(bh); > clear_buffer_uptodate(bh); > + if (was_pinned) > + brelse(bh); > } > > /** > -- > 2.25.1 >