From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5BCE1F30BB for ; Sun, 1 Mar 2026 18:17:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772389065; cv=none; b=G8rcd+wOV9kPXV640Pzqo3hPGIbILuZ2zjHbxPw1k4Zuzk3NrBv6Ba8aRpeRvQ5f/Vr0bLOiuxEbaSoo7c/219um6/xUCOXIOx3qXYf3kI/xmzcBr5x9pPlWwUTy5rF/ebQBSovrlWCaPbz+gpUo7Bqnqv064g5QECdkcIWfoa4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772389065; c=relaxed/simple; bh=i3Coe7mHx/1q/bt1lktQ43Lv+RICmHSAbEawJT6BFLs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=TEaB8WcBhNRqg4SDJ3a2fd3eos7tlC17Z2sOmzZAQulRk0cNLsu5Fj25QBPPieuqrIUblpgFq4ugsLoL1Mh1T9UUsb0qRG/N3/+0j7PM3/MAsmdkhWgVS7Jyog27L3eK6WR422Hc2o6+LgXxAoj+3vpqnMO2UU7/LBEPBPvgbPY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=KzrIxBk5; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="KzrIxBk5" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-65faaa8b807so6801081a12.3 for ; Sun, 01 Mar 2026 10:17:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1772389062; x=1772993862; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5qhGyGsXJ9/tAFMFzwHRznymGmjUNcVZ9ynpOMQhLUU=; b=KzrIxBk5Elkyl1foUErLJ8p5iT5vhc8SUX1uTdn0S7DHc1jZvHTus1nitRy25/6e+n THq6qp2c3T4qoU2Bju7U2kA05CMNcuKTDMMUSGjeiY7wOgqCbXeH539jc0j09K3tc/9u aor64BqJCI6qmFvP4X+SwKBOWtfRsAR2dhxY8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772389062; x=1772993862; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5qhGyGsXJ9/tAFMFzwHRznymGmjUNcVZ9ynpOMQhLUU=; b=T9O3YeJXte723D8NL1K1VmSk9q4n3GWEI83s3QJDL/pkvKGL5M4haQs6vOmKIskgnb Utnk7s9OyDXH1yBnmzyhZQQFj31FUtTbIUpXOKnHdyK5bXRsrkDf843RjRS4hYrAVzn0 VZ6SDFt0VFgCWhXbXD+XuXoi2x9IN+nKPweUqBBbtuaGki9qLCPnAIy/yrYp7ugkfn00 efPA29TL+AhUFp6VakLPs42al94h7WRvvnXsejUwQV5XjWyba1h4/QMkb1Kk4AxaESPn lEywbaVJac61GEweTmsNUFb5mZWBhkgnNKSfa8Lei9Z3b7oilMBKuWpsMHv/uX8XzOnu cPDw== X-Forwarded-Encrypted: i=1; AJvYcCWW5+l4Kr84mFKgm5twJ0MMX6nMBpKLPMAvxzuVjvkrvaOEHlAKacIxJ92hJicb4QSSHC+IwmSsdWND8q0=@vger.kernel.org X-Gm-Message-State: AOJu0YwofV1ayvcKzZuFI9/0FsmwehLrobTX6wCbvRu0eIrY/BBOYoLr nl8N8e8sKEDgOO1GtJf9vsFPa+Zz4G0+MDUEATU8Dt48I3aCNeNfOBoaFVGRhqL0mxy3EckojkV PqIbo+9M= X-Gm-Gg: ATEYQzzr+vb4fGGjIM7eaVMTfg4waMIJR7SEgvaK8tpvWhCxI3ZbdeWBHsFuaiYyAks gpB8HWZmQceHYh3ROFkJ/OhiWWbA+ifDfeao90Xw04CZgUOSmVwCmXdgb0VCHInr6IZf+OGaDq+ ofMzgfgacyIJx0eeD8qEbofcaGd5t2TAnArWJIyWpEffyh2IIRTuhT3M7z2LVweMNj0EpNCBaYB kSXvkJ8qNuONL2cbqj7Gk8XduG11CdszDfpxauEeDouXCFE446JZgRd0TTFxm1eOd2vEvRM67+c 22MMcjECIqXZa2H7GX0fKMDmw/p5RTnKVNWbHFq71u/LZFo/jQHvLgTSMKR2p0W5tQqU2rvX9Xd 3XVb1YihGfmM30jCdSNhZ7oI9mrug4H6tOrn9sghtySItMTZ5Ss2rVgWVlIJiP4eg0k3k9Pczx2 lu/+mclQ0v0dYWDmGUG2C6flHtFRcq9oPGG4cnE388V0S1z3kEupXab80bY/78B0dU4dnBIthD X-Received: by 2002:a17:907:847:b0:b8f:99c2:1a99 with SMTP id a640c23a62f3a-b937636cdf3mr583859266b.9.1772389061655; Sun, 01 Mar 2026 10:17:41 -0800 (PST) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com. [209.85.218.49]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b935ac513acsm384938566b.18.2026.03.01.10.17.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Mar 2026 10:17:41 -0800 (PST) Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b9382e59c0eso326179366b.0 for ; Sun, 01 Mar 2026 10:17:41 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWQQv0Ou7GvBIFAS9z1RbW0P45FnWGJNNzOTQYjcss0RYMAa24p+xfY06wkHxPtQS78gm0O1NXaYYOxJi0=@vger.kernel.org X-Received: by 2002:a17:907:6d11:b0:b87:7485:b4bf with SMTP id a640c23a62f3a-b9376180f60mr604929966b.0.1772389060956; Sun, 01 Mar 2026 10:17:40 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Sun, 1 Mar 2026 10:17:24 -0800 X-Gmail-Original-Message-ID: X-Gm-Features: AaiRm52NQg0Dq8eSC_WI0O8y8HVmFVEoA2whrGx34VJgXkMjnIUoMhKJPi6tm48 Message-ID: Subject: Re: [GIT PULL] Driver core changes for 7.0-rc1 To: Danilo Krummrich Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Saravana Kannan , Andrew Morton , driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Sun, 1 Mar 2026 at 05:04, Danilo Krummrich wrote: > > It happens that quite a few busses rely on this, and there is a possible race > condition that can lead to UAF bugs in the context of driver_override. > > I think it is rather unlikely to happen though, as it would require a user to > change a device's driver_override field through sysfs while the device is > matched with a driver. > > In any case, this can easily be solved with a separate lock. Yes, if it's literally just about driver_override, please just fix the locking. Use some really simple local spinlock lock to just copy the string into a local copy when accessing it - it's not like it's even some arbitrarily long string afaik (how long can driver names be?) Don't use a huge sleeping lock that has other semantics for something trivial like this. (Or is there some other driver_override thing I'm not aware of?) Linus