From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 685D42DF3FD for ; Wed, 5 Nov 2025 11:52:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762343559; cv=none; b=YhlaWMNLMQYnDJUm8VYXYsapkPx7Z6HJdNyLYnuextJZbZvhtjwYr+2YG87wwcpnT+HQkffe0WBDhKWy4iNiPRVPWfdkl002v37uXlj9DKj/CVj2sbVQmG596i8X97Ngzf1IXwoLLdRei/aLdpzbZq5GZBr8MefM5dFxn2pV9T8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762343559; c=relaxed/simple; bh=0gaX/c8zQfx44tSR/MSzqkw90P3yVYkFR83Mp3kzZfs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=EroOHoGv0bmdr/+ZOjHvtrCP6mMgWiF24FBZp8+yGb76Ze6LHnYteNz/K0s7xp5RasBy6poDZ7MX+Nw8SpYV2Q1zY5osQtQhHpW67O8NKMx2qX9C5RXVYf/L+M0yY4SIFokPMuQLYt384yhGVQU2UXx+Max4my+9T8bM1mLLHqY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YPKEWJU+; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YPKEWJU+" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-641018845beso1658047a12.3 for ; Wed, 05 Nov 2025 03:52:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762343556; x=1762948356; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iedBfjMEI/BD2OKkcDXb/6esIeABFAFipHLCvBMMLYo=; b=YPKEWJU+C7AqAr9dGp2m9epNa1vPnWgPzUHuZJ/SSAMQog/jOaBOW47FKPlCrp2wnf rasTWld3p/OiMNHNJ7g0k2vJ7Evm3Y/Eh+o626jDEN5ut+qJKFnSdMNRWE41gpsNsUuY pdpbKKpnwwlqlDet4qAUyngYCiMIsJl6sTAVBGaVorv1B9dAkb2LkK/A+T2CgqV7tP/5 +X7DH0RpQbb1LTr60YBT6v7YUccmExyvma85N5s3vxL4/UQRppdjIgahTMC1j7TbI9f0 7SzDI25HJRXKpnKQykl1nDvmXLEl4pl6EEzLmKGILe5GtTb9yJtv7g0Xdz5pXLPxRaA9 Bmdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762343556; x=1762948356; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iedBfjMEI/BD2OKkcDXb/6esIeABFAFipHLCvBMMLYo=; b=W0iQSaktfVNCeEFKRGxPqdtymQ33u3sbznPOzvcrtnHI2bToUR0DedA/D3eQJzpFP3 bsgtLGSdq+CyPm68WaLSIFTp8zO8MCYH9goAaSPviDJCr/KJCaNBVY8hngu0JICPLsn7 ZR5zEICV+/HMH9lw4pdeuHcgRC0muP4JoBBvAtPGCMzVA/C6uZB7qbOr/VWj3226kE3X V1jyerGHs4k1gtkXaJCiIXJ+XhaP0w1/yTllfZlbqEhzr2CtF1fIn/pjmAiO1SB9Wfxh ZPJssZK2zQRLyHUyQ4V09G+SwD+LJXNfz+h36+xZYfqv/ukH8oXZHzfVzgmghpRvD8tg UafQ== X-Forwarded-Encrypted: i=1; AJvYcCULbHyr9edsXC2k9vcCq7cGUFEkUU2fqw/evJgFYgYBXZ9//V1dbHeskmuiN7ToC8xtMGdVn86tatb9taA=@vger.kernel.org X-Gm-Message-State: AOJu0YwF8ycnee8ZYtzZB90A/iDogP/bSxK2wmBZFUWrb9HWrFy6HO8u Jcntv+Z398YeivxodxMWoda30vdzniPm1aRQtKx5H5AwgRsAJlLQawMGxO6wKmIudCKw0No1UyV DZsn5ue4EOeQ2c2ohNfYFOyN/HRABHNY= X-Gm-Gg: ASbGncugrrM0dANT7ItOiqbNYjrnqnTJdvP0VxC0Rt0rglUWTywLyzt9+Pu3NYw++f4 8HtIvTAoynwzZZvEpXoMV/dNg4+OpR0/cPT/PozW6Ne4bcwaU5eAARtEqf0/kdWGKxRnmdThis4 gy1E1zs/097yxLuGjBzxTgnZA0IpG8eagqhMuvR0Nl0e4f4nTXiSyVOALwXqr7YGzlGqYiKR0Xg 5xR5+rGvBHt80EWgdktRoBKBIIXA0TsSP1FgF8SmuyOHop+8yzlevc9JRc= X-Google-Smtp-Source: AGHT+IGoygrIy70PnDbuCu7xRhMXI84nNHjqgH0yxEIwACdXUcARjlwvw2mLsCIXLb4xjM/BO2FWbv7wlW3GA0/LjXQ= X-Received: by 2002:a17:907:1c2a:b0:b70:b98a:278b with SMTP id a640c23a62f3a-b72654f6507mr251548066b.38.1762343555520; Wed, 05 Nov 2025 03:52:35 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251104145814.1018867-1-andriy.shevchenko@linux.intel.com> <20251104145814.1018867-3-andriy.shevchenko@linux.intel.com> <20251105103122.GL2912318@black.igk.intel.com> <20251105115041.GM2912318@black.igk.intel.com> In-Reply-To: <20251105115041.GM2912318@black.igk.intel.com> From: Andy Shevchenko Date: Wed, 5 Nov 2025 13:51:58 +0200 X-Gm-Features: AWmQ_bkmPnmrwZbGmhE1N0VXqG2zD080rJlzcWK6qJRP7OzdovZ0V10GbhzH4ws Message-ID: Subject: Re: [PATCH v1 02/10] pinctrl: alderlake: Switch to INTEL_GPP() macro To: Mika Westerberg Cc: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Linus Walleij Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Nov 5, 2025 at 1:50=E2=80=AFPM Mika Westerberg wrote: > On Wed, Nov 05, 2025 at 01:40:06PM +0200, Andy Shevchenko wrote: > > On Wed, Nov 05, 2025 at 11:31:22AM +0100, Mika Westerberg wrote: > > > On Tue, Nov 04, 2025 at 03:56:36PM +0100, Andy Shevchenko wrote: > > > > Replace custom macro with the recently defined INTEL_GPP(). ... > > > > -#define ADL_GPP(r, s, e, g) \ > > > > - { \ > > > > - .reg_num =3D (r), \ > > > > - .base =3D (s), \ > > > > - .size =3D ((e) - (s) + 1), \ > > > > - .gpio_base =3D (g), \ > > > > - } > > > > > > I wonder if simply doing this: > > > > > > #define ADL_GPP(r, s, e, g) INTEL_GPP(r, s, e, g) > > > > We can, but it will give a couple of lines in each driver still be left= . > > Do you think it's better? > > I think that's better because it is less changed lines but I'm fine eithe= r > way. Okay, I will try it and see how it looks like and then I'll either send a v2 or ask for a tag for this one. Sounds good? --=20 With Best Regards, Andy Shevchenko