From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Cosmin Tanislav <cosmin.tanislav@analog.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] serial: max310x: Add error checking in probe()
Date: Thu, 7 Aug 2025 23:30:34 +0200 [thread overview]
Message-ID: <CAHp75VcVA+yARTBvcOiKYdhgxtS_YQ82Xd-R4o98OTGp167ZQw@mail.gmail.com> (raw)
In-Reply-To: <aJTMPZiKqeXSE-KM@stanley.mountain>
On Thu, Aug 7, 2025 at 5:54 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> Check if devm_i2c_new_dummy_device() fails.
...
> port_client = devm_i2c_new_dummy_device(&client->dev,
> client->adapter,
> port_addr);
> + if (IS_ERR(port_client))
> + return PTR_ERR(port_client);
I'm wondering if this is indeed a critical error in this case, but okay.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-08-07 21:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 15:54 Dan Carpenter
2025-08-07 21:30 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcVA+yARTBvcOiKYdhgxtS_YQ82Xd-R4o98OTGp167ZQw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=cosmin.tanislav@analog.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®