From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752683AbdARSEB (ORCPT ); Wed, 18 Jan 2017 13:04:01 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:34041 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752422AbdARSD7 (ORCPT ); Wed, 18 Jan 2017 13:03:59 -0500 MIME-Version: 1.0 In-Reply-To: <20170118162009.24763-1-paul.gortmaker@windriver.com> References: <20170118162009.24763-1-paul.gortmaker@windriver.com> From: Andy Shevchenko Date: Wed, 18 Jan 2017 20:03:57 +0200 Message-ID: Subject: Re: [PATCH] lib: sort: make it explicitly non-modular To: Paul Gortmaker Cc: "linux-kernel@vger.kernel.org" , Kostenzer Felix , Andrew Morton Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2017 at 6:20 PM, Paul Gortmaker wrote: > The Makefile currently controlling compilation of this code is: > > lib/Kconfig.debug:config TEST_SORT > lib/Kconfig.debug: bool "Array-based sort test" > > and... > > lib/Makefile:obj-y += bcd.o div64.o sort.o [...] > > ...meaning that it currently is not being built as a module by anyone. Perhaps allow it to be a module? Besides that perhaps rename to something like test_sort.c ? -- With Best Regards, Andy Shevchenko