From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED003C43334 for ; Wed, 15 Jun 2022 11:24:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345753AbiFOLYr (ORCPT ); Wed, 15 Jun 2022 07:24:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343678AbiFOLYp (ORCPT ); Wed, 15 Jun 2022 07:24:45 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C82F35A8A; Wed, 15 Jun 2022 04:24:45 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id y19so22569080ejq.6; Wed, 15 Jun 2022 04:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RcIsYZgQ3wffpFYTz+tQ8CrN5DLnWI36Wvm6m89SFMM=; b=YM/ce9swQN4g8I1u1q6a1V4OKZjzVZmw9/Lzud1xRfdDGqAdVXgVvb8RNZrmUO4noG YutZlktsKUDVlu9OIVwIrrYscHWPfUp8e7GxTQ6GoQS+zV0GRkyAYdXDZiQ86h0lC+tG MLe5gXSFrOe7QGcLz4MlrPq/jMziLb/hnYxE4IL/T4htOG1NUGgNwgk61FKx/voICzk6 OlkRnHWtH/lzxWtkJj/37f5oG8xp2fnUxFC3dc4DvUKnNl33tfz3+kCGVhClCTFByh3a GUaCO7jjngZR/WU7ij2Bdio0jDCHm6lKO7ctDZMLXo9tXrf6n4bNspNRmarWuw+MguEE 9+vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RcIsYZgQ3wffpFYTz+tQ8CrN5DLnWI36Wvm6m89SFMM=; b=zGIM39w4uSt6UIsSNq4wJPgGdyVJ2EJuUJjeo7CDKm/ehzRzagGGJMxbNF/TYKwkVh 36xo3m2JYdjBEjY9/UqYJYsO8ubz3lMrHd5vkrqACcsG/mg4hTndH510PNHHIleZbccG BPTZGcKuFSg80arW9wQjgsnL/UTxACI6yuC7QI/x2u8oEfQElbLI8V/2uNqibXEs0KZl DRS2NN4xBDOD8RXSj1kyqmlF3nvYl87cHu+dj5CuZ3VoOil61JGRDTaxRm31zKvlExuX 00SF+EnrOgLxKe6CP9v+Att9VA/SPtBGBhVtFGtyB7kE4FAZ5jPeSThVmJzpK+3LhCTM IlHA== X-Gm-Message-State: AOAM531C0mGGe2Rdt8u7N6ODs3HV403ja+1X0pn4904oem30/kamO2Yy wk+OjpcFHWiD4IcKOFoqmfPx34TCWucqKTRPUXxAyqlx9YoxeQ== X-Google-Smtp-Source: AGRyM1u167zDbthEdeQw+IsWWuX6OC89LCdIsKeXieMsDx1ZnUZgNc/sQmyoQ6YL9HT+xU9hiTBfz3Kxbr5V84JHmhw= X-Received: by 2002:a17:907:9721:b0:70c:65e7:2aa5 with SMTP id jg33-20020a170907972100b0070c65e72aa5mr8385497ejc.132.1655292284501; Wed, 15 Jun 2022 04:24:44 -0700 (PDT) MIME-Version: 1.0 References: <20200821181433.17653-8-kenneth.t.chan@gmail.com> <20220612090507.20648-1-stefan.seyfried@googlemail.com> <20220612090507.20648-3-stefan.seyfried@googlemail.com> In-Reply-To: From: Andy Shevchenko Date: Wed, 15 Jun 2022 13:24:06 +0200 Message-ID: Subject: Re: [PATCH 2/2] platform/x86: panasonic-laptop: allow to use all hotkeys To: stefan.seyfried@googlemail.com Cc: Kenneth Chan , Platform Driver , Linux Kernel Mailing List , Stefan Seyfried Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 15, 2022 at 1:21 PM Andy Shevchenko wrote: > On Sun, Jun 12, 2022 at 3:54 PM wrote: > We usually add module options in very bad cases where it's very useful > for debugging or when some devices require the opposite settings while > can't be distinguished automatically. Here I do not see either of such > cases. Hence, I would prefer to see a DMI based quirk as it's done a > lot in the PDx86 drivers. Can you do that? Looking into the code of the culprit patch, have you tried to add a debug pr_info() and see what value is in the result? Perhaps you may just sort out by correcting that. -- With Best Regards, Andy Shevchenko