mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: edumazet@google.com, Pravin Shelar <pshelar@nicira.com>,
	Mel Gorman <mgorman@suse.de>, David Miller <davem@davemloft.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	Ben Hutchings <bhutchings@solarflare.com>
Subject: Re: [PATCH v2] include/linux/skbuff.h: using '(u16) ~0U' instead of '~0U'
Date: Mon, 3 Jun 2013 14:34:42 +0300	[thread overview]
Message-ID: <CAHp75VdSFRO2T_2Z1cVw_2Frk5MNLUBKd+p8S1sw_MBM+pyu=g@mail.gmail.com> (raw)
In-Reply-To: <51AC7CD4.2060801@asianux.com>

On Mon, Jun 3, 2013 at 2:24 PM, Chen Gang <gang.chen@asianux.com> wrote:
>
> Both 'transport_header' and 'mac_header' are u16, which are never equal
> to '~0U'.
>
> So need use '(u16) ~0U' instead of '~0U'.
>
> The related warning (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig)
>   include/linux/skbuff.h:1587:2: warning: comparison is always true due to limited range of data type [-Wtype-limits]
>   ...
>
> Use meaningful macro instead of hard code number, and better to
> initialize 'skb->transport_header' in __alloc_skb_head(), too.

Looks okay. Couple of questions below.

> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -40,6 +40,8 @@
>  #define CHECKSUM_COMPLETE 2
>  #define CHECKSUM_PARTIAL 3
>
> +#define SKB_HEADER_UNSET_16    ((unsigned short) ~0U)

Isn't better to use the same type as used in the structure description?

> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -200,7 +200,8 @@ struct sk_buff *__alloc_skb_head(gfp_t gfp_mask, int node)
>         atomic_set(&skb->users, 1);
>
>  #ifdef NET_SKBUFF_DATA_USES_OFFSET
> -       skb->mac_header = (__u16) ~0U;
> +       skb->mac_header = SKB_HEADER_UNSET_16;
> +       skb->transport_header = SKB_HEADER_UNSET_16;

Is it correct to assign transport_header here as well?

--
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2013-06-03 11:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30  6:03 [PATCH] include/linux/skbuff.h: using '0xffff' " Chen Gang
2013-05-30  9:55 ` Chen Gang
2013-05-30 15:30 ` Ben Hutchings
2013-06-03  8:52   ` Chen Gang
2013-05-31 21:05 ` Andy Shevchenko
2013-06-03  9:23   ` Chen Gang
2013-06-03 10:14     ` Andy Shevchenko
2013-06-03 10:51       ` Chen Gang
2013-06-03 11:24         ` [PATCH v2] include/linux/skbuff.h: using '(u16) ~0U' " Chen Gang
2013-06-03 11:34           ` Andy Shevchenko [this message]
2013-06-03 11:46             ` Chen Gang
2013-06-03 12:26           ` David Laight
2013-06-03 12:47             ` David Laight
2013-06-05  0:44               ` Chen Gang
2013-06-05  0:54                 ` [PATCH v3] include/linux/skbuff.h: using '(__u16) " Chen Gang
2013-06-05  8:36                   ` David Miller
2013-06-05 11:15                     ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75VdSFRO2T_2Z1cVw_2Frk5MNLUBKd+p8S1sw_MBM+pyu=g@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gang.chen@asianux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@nicira.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®