From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E607E3E9C00 for ; Fri, 15 May 2026 07:31:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.208.54 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778830318; cv=pass; b=uqOb4LBHj0aywHLItNpkbDr169SCsZ1XW8KU7h6rST4wy6r5kQdgjxLTPMZj7+YVRI1xffE3yIIvQFS/pcNBBCuQAkVpl5XywtiUmg8LRvgvA86eXkM/6XcDQlIc7jA5+qIFhAR8AgIBFts6NijC4sRgLcTbxqoY2uutC2u1wsg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778830318; c=relaxed/simple; bh=A/SsPiVJtDZ72Sr+gRIQuTO1NvYWy3UPeoA4P6g0JsU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=ktxSotFwuS7c1ELImzvcQWW3YlT9O7HNyEnIt9HOSIbwR+cIeMxAJuYakUIVceqqp4z2nHs4ogkJe1D0uw4jRDIfUK7b0V9tjlLB8J2PyHJxxwxqthy8sTEvzYJal0YQg07/mJ5XOtOXblUdMGM73IlD9zmlW9wpPCF/AOfaHAI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AXoYYfV0; arc=pass smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AXoYYfV0" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-67c1e0229acso13761593a12.1 for ; Fri, 15 May 2026 00:31:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778830315; cv=none; d=google.com; s=arc-20240605; b=KoV1EWakHFXynA1uD0sibpdG18+BLT+alZB+5qNnFO9c/W0d7IUDqnqwg0lL8S6aYX 7ZHOp6pnN+BzqF8vUzwgq6DPaKUdyu/nUnj9SM/Z3H20CEQvkacBPsEoXp3PVmsVyLlB tO2wjiP4JpaWvmcZrEUaQ+9BX9Q85d4fEhJ5x5ytwKz+W7eMSGGUwZN6KgatsjE5S60T yR/fr5CUO6P5xQnlhmjlVZp37Gd1y+KelIaKKxIRj9U7ZANUKLMqXB55vnALAWOe04L5 kqrj/RGWvNyoYhIipRsBWfGGQkbvK/Dz74TpVpw9W3rJ+ui/u9JQDC9u/eYDdmDkPKAz QiNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=A/SsPiVJtDZ72Sr+gRIQuTO1NvYWy3UPeoA4P6g0JsU=; fh=WZ/JN9D8b0P2zfuJvwR+xFZzS/nFJeoQbLMN/siLVcw=; b=M/xhpQIvW+C1bEXgQeYIi6tUo0I24X52NZs2WzcE4GeXff2gd9LbiJMkQmm9MkxEvv Aa8165VcIyehBHYhVqvx6TWtHHhsfWxFegbIcI55b4glfgnlxuaayEbOjbGoxbw7u5cY 3JpwXQJGBV6HGqQX1sVpynZSzz/sqA6BhQ2ljhkHL+PZyN5sFaSG0UNndx66Z5PyOsbS k3dlyZc1zfU2JdhbugExaEY6+tr1JHq4gJEeH2J+LqwnraTs5Vrl7QudhmXlBt8Cbx+G huzlnpzd/oiLd5huWRIquANzHNsYNIiZ/e+4vKfVeF+yq/tc8pyk8vL+foIJ3x1aIYEj A/ig==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778830315; x=1779435115; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=A/SsPiVJtDZ72Sr+gRIQuTO1NvYWy3UPeoA4P6g0JsU=; b=AXoYYfV0xdQL2EvM6lCogOlDWNQaeGF6nGq0rbBC2KD/F9/y+MTmaXgoA7LKsFuErm SwZz2/xIRXO9eIjHlWf89zUzVPGmkE4Hq1ADw3VdwdQiPaurNRIE0YYW0Qi8wD3wMHn2 c2uk3rFQDKPDmEFbI/HYDC/W0nMtjsXFQLi3exTGjDV6hqgyCfcmDi9SUedm5zd2Z01T 86zYgQkwWPuiR9zX4w50fBsVdpA44lc2j4OeDbmNOmz8LRoS7bdhjM3mFoXMC2HedO/t 0uMk0ZJVnZZSwYP5WVmwqVoE3Wjxwzad8c2ftykQDvPkgDBNaAWaicoHDpok4ELi9JvW OpyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778830315; x=1779435115; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=A/SsPiVJtDZ72Sr+gRIQuTO1NvYWy3UPeoA4P6g0JsU=; b=Ue3z9FmkQZqCLNbhKEqOjrtkXXTazgmLDUgAwOwSLaYf/aE0SM5ypVQgk+iTA8Qy/y 6LMapTgiOFszgZT080TsYP/kl6TPffgsZNh14yToT4uh+1y8zMUTWV5FgYfR3BUV+wHL TUOoKDE/g8hdYkqoiCNaiMCQGkp5OjfVBzNvSnwMOhAmmaW5P1JHWesbru+amHSEn8D+ 2Tb++MdV1BBBSaliTkKQwt4eI0qKXma35Nhx1XbYZ1G0e06IkrrMANZnm+0A6Yn03+S9 3uL9xRL+Dx0Kxu1utVjx/vGrQAZhqzndSu4aRwmJlhtMJHQlkBhpDTavv8yVVCJq7/3L aRag== X-Forwarded-Encrypted: i=1; AFNElJ/GgoFKzr0DJIKqQAO0hjTL5T/zgBj1xrMgsJfqxu4f0HkVL+T5xfN+nKGgm3Mb0Ve39KwfWdjse/14IIg=@vger.kernel.org X-Gm-Message-State: AOJu0YzFjLxurM78IC2W3ynr3KyxxTiAAfG8Dlf0MiUSmgDNFr0RfosB 1SZPColou7eUHQkx1bDwvtP1T/eDycWFv5uaLumg+tO86LtG3MOwfIYEqFtCLBfp9UGVrqFg5h5 +zzSE54vhOl71dR76tq5U0oxElm6tt4I= X-Gm-Gg: Acq92OFJA4YnfH6PZs3CA/Zkrzc4xxJy7+pdhg8djhL6WdUx0OU6Jb+IkGlQKRsyjHz GXgr39Lzz1HmmlgCtnCk7mcWpyCC0x4uDPbqL8BnQ6e/HX4JnuroG/AVZS3HvsW1EMXef188SNe cf6jNex/e8F5LXDRyp9r/joiUFAkST0p42tIgEcRqjb3sQ8+PfaFecO3VqdBsljc10Fj27O58co WLxqikUbD15L+eDdb/H2MERzVz7vXH0fwFKo+CIRtcw21bCNJTAARA0f1GgBO+jUMiuzRwiHgXN B+hIQndhyTqEzuN5q4jYrClDfVqL9MhO/TKK6jfHj2EupXXIz8Ek3VLwPbJRhiN5bEjcaLWKE4V QVKZ4528= X-Received: by 2002:a17:907:9802:b0:bce:804f:f199 with SMTP id a640c23a62f3a-bd517aaf35emr124360466b.40.1778830315236; Fri, 15 May 2026 00:31:55 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260514160719.105084-3-manuelebner@mailbox.org> <20260514163033.108009-2-manuelebner@mailbox.org> In-Reply-To: From: Andy Shevchenko Date: Fri, 15 May 2026 10:31:19 +0300 X-Gm-Features: AVHnY4K3RmWomzVU2dlVSzNVcpQvqzGa2-vhlNceUIfF6GpAdlsduEN_ocTMzyM Message-ID: Subject: Re: [PATCH v2 3/3] drivers: add deprecated remarks to strlcat() To: Geert Uytterhoeven Cc: Manuel Ebner , Kees Cook , Jonathan Corbet , Shuah Khan , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , David Laight , Randy Dunlap , Jani Nikula , Heiko Carstens , "open list:DOCUMENTATION PROCESS" , "open list:DOCUMENTATION" , open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, May 15, 2026 at 10:30=E2=80=AFAM Andy Shevchenko wrote: > On Fri, May 15, 2026 at 10:23=E2=80=AFAM Geert Uytterhoeven > wrote: > > On Thu, 14 May 2026 at 18:32, Manuel Ebner wr= ote: > > > add kernel-doc comment to strlcat() function definitions ... > > > +/** > > > + * strlcat - Append a string to an existing string > > > + * > > > + * @dest: pointer to %NUL-terminated string to append to > > > + * @src: pointer to %NUL-terminated string to append from > > > + * @count: Maximum bytes available in @dest > > > + * > > > > Missing "Returns ...". > > Documentation says "Return:" as I mean the kernel-doc documentation. Here the section is missed and needs to be added, indeed. > - the section (note important colon) > - the singular (however plural is undocumented and supported) > > > > + * Do not use this function. Prefer building the string with > > > + * formatting, via scnprintf(), seq_buf, or similar. > > > + * > > > + */ --=20 With Best Regards, Andy Shevchenko