From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751830AbdIUQob (ORCPT ); Thu, 21 Sep 2017 12:44:31 -0400 Received: from mail-qt0-f182.google.com ([209.85.216.182]:57101 "EHLO mail-qt0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751605AbdIUQo3 (ORCPT ); Thu, 21 Sep 2017 12:44:29 -0400 X-Google-Smtp-Source: AOwi7QDgssPwxLntlfsL5EWO41FJeyns66y6XpW8EnXvcAUBBT3emxqjbzLB7QWpKPh3FjC9qtf6p56VsX6VRkE4M3E= MIME-Version: 1.0 In-Reply-To: <1001812b63d73bf3ccd5ea6c76604cae0fa1525a.1505999739.git.mario.limonciello@dell.com> References: <1001812b63d73bf3ccd5ea6c76604cae0fa1525a.1505999739.git.mario.limonciello@dell.com> From: Andy Shevchenko Date: Thu, 21 Sep 2017 19:44:28 +0300 Message-ID: Subject: Re: [PATCH 07/12] platform/x86: dell-wmi-smbios: Use Dell WMI descriptor check To: Mario Limonciello Cc: "dvhart@infradead.org" , LKML , Platform Driver , quasisec@google.com, =?UTF-8?Q?Pali_Roh=C3=A1r?= Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 21, 2017 at 4:57 PM, Mario Limonciello wrote: > The Dell WMI descriptor check is used as an indication that WMI > calls are safe to run both when used with the notification > ASL/GUID pair as well as the SMBIOS calling ASL/GUID pair. > > As some code in dell-wmi-smbios is already a prerequisite for > dell-wmi, move the code for performing the descriptor check into > dell-wmi-smbios and let both drivers use it from there. > + desc_buffer = (u32 *)obj->buffer.pointer; > + > + if (desc_buffer[0] != 0x4C4C4544 && desc_buffer[1] != 0x494D5720) I was thinking about strncmp() here for a full line, though decide not to push it anyhow. Those IDs is binary data, can be anything and you have comment of what is expected here. But I think it would be nice to create a separate definitions and make comments there. > + dev_warn(&wdev->dev, "Dell descriptor buffer has invalid signature (%*ph)\n", > + 8, desc_buffer); %8ph ? > + > + if (desc_buffer[2] != 0 && desc_buffer[2] != 1) > + dev_warn(&wdev->dev, "Dell descriptor buffer has unknown version (%d)\n", > + desc_buffer[2]); %u ? u32 can't be negative and you basically allow it. > + > + if (desc_buffer[3] != 4096) > + dev_warn(&wdev->dev, "Dell descriptor buffer has invalid buffer length (%d)\n", > + desc_buffer[3]); Ditto. P.S. I noticed this all in old code, so, you can address my comments in a separate patch if you find them useful. -- With Best Regards, Andy Shevchenko