From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966661AbdACXi3 (ORCPT ); Tue, 3 Jan 2017 18:38:29 -0500 Received: from mail-qk0-f195.google.com ([209.85.220.195]:35291 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935259AbdACXhY (ORCPT ); Tue, 3 Jan 2017 18:37:24 -0500 MIME-Version: 1.0 In-Reply-To: <1483391271-17304-2-git-send-email-steve_longerbeam@mentor.com> References: <1483391271-17304-1-git-send-email-steve_longerbeam@mentor.com> <1483391271-17304-2-git-send-email-steve_longerbeam@mentor.com> From: Andy Shevchenko Date: Wed, 4 Jan 2017 01:37:23 +0200 Message-ID: Subject: Re: [PATCH] gpio: pca953x: Add optional reset gpio control To: Steve Longerbeam Cc: Linus Walleij , Alexandre Courbot , Rob Herring , Mark Rutland , "linux-gpio@vger.kernel.org" , devicetree , "linux-kernel@vger.kernel.org" , Steve Longerbeam Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 2, 2017 at 11:07 PM, Steve Longerbeam wrote: > Add optional reset-gpios pin control. If present, de-assert the > specified reset gpio pin to bring the chip out of reset. > --- a/drivers/gpio/gpio-pca953x.c > +++ b/drivers/gpio/gpio-pca953x.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include Please, try to put it somehow alphabetically ordered (yes, I see it's not in general, but try to squeeze it into longest part which is ordered). > > #define PCA953X_INPUT 0 > #define PCA953X_OUTPUT 1 > @@ -754,8 +755,18 @@ static int pca953x_probe(struct i2c_client *client, > invert = pdata->invert; > chip->names = pdata->names; > } else { > + struct gpio_desc *reset_gpio; > + > chip->gpio_start = -1; > irq_base = 0; > + > + /* see if we need to de-assert a reset pin */ see -> See > + reset_gpio = devm_gpiod_get_optional(&client->dev, "reset", > + GPIOD_OUT_LOW); Shouldn't be _optional_exclusive? See this recent discussion https://patchwork.ozlabs.org/patch/706002/ > + if (IS_ERR(reset_gpio)) { > + dev_err(&client->dev, "request for reset pin failed\n"); > + return PTR_ERR(reset_gpio); > + } > } -- With Best Regards, Andy Shevchenko