From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752481AbdBPBTG (ORCPT ); Wed, 15 Feb 2017 20:19:06 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:32784 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750902AbdBPBTE (ORCPT ); Wed, 15 Feb 2017 20:19:04 -0500 MIME-Version: 1.0 In-Reply-To: <20170215222948.21030-2-zajec5@gmail.com> References: <20170215222948.21030-1-zajec5@gmail.com> <20170215222948.21030-2-zajec5@gmail.com> From: Andy Shevchenko Date: Thu, 16 Feb 2017 03:19:02 +0200 Message-ID: Subject: Re: [PATCH 2/2] brcmfmac: don't warn user if loading firmware file with NVRAM fails To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Ming Lei , "Luis R . Rodriguez" , Greg KH , Linux Kernel Mailing List , Kalle Valo , Arend van Spriel , "open list:TI WILINK WIRELES..." , brcm80211-dev-list.pdl@broadcom.com, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1G1JB93018965 On Thu, Feb 16, 2017 at 12:29 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > This isn't critical as we use platform NVRAM as fallback and it's very > common case of all Broadcom home routers. Thanks for the new firmware > loading function we can achieve this by simply passing FW_OPT_NO_WARN. > What kind of warning you are talking about? On Intel Edison brcmfmac isn't backed up by NVRAM (there no such) and the platform is not ACPI-based. The warning might be crucial for debugging Wi-Fi issues on such platforms. > Signed-off-by: Rafał Miłecki > --- > Kalle, Arend: this patch is strictly related to the bigger 1/2. Could you ack > this change as I expect this patchset to be picked by Ming, Luis or Greg. > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c > index c7c1e9906500..26ec445a8d2d 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c > @@ -504,9 +504,9 @@ static void brcmf_fw_request_code_done(const struct firmware *fw, void *ctx) > return; > } > fwctx->code = fw; > - ret = request_firmware_nowait(THIS_MODULE, true, fwctx->nvram_name, > - fwctx->dev, GFP_KERNEL, fwctx, > - brcmf_fw_request_nvram_done); > + ret = request_firmware_async(THIS_MODULE, FW_OPT_NO_WARN, > + fwctx->nvram_name, fwctx->dev, GFP_KERNEL, > + fwctx, brcmf_fw_request_nvram_done); > > if (!ret) > return; > -- > 2.11.0 > -- With Best Regards, Andy Shevchenko