From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jonathan Woithe <jwoithe@just42.net>
Cc: "Micha?? K??pie??" <kernel@kempniu.pl>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>, Harvey <harv@gmx.de>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection
Date: Mon, 30 Oct 2017 16:13:53 +0200 [thread overview]
Message-ID: <CAHp75Vf-kohM2sTeDsoT2dPbHSQDd0eGU0FDA9Ua+CXrxvzigg@mail.gmail.com> (raw)
In-Reply-To: <20171030121257.GA28737@marvin.atrad.com.au>
On Mon, Oct 30, 2017 at 2:12 PM, Jonathan Woithe <jwoithe@just42.net> wrote:
> On Mon, Oct 30, 2017 at 01:21:50PM +0200, Andy Shevchenko wrote:
>> On Sun, Oct 29, 2017 at 11:28 PM, Micha?? K??pie?? <kernel@kempniu.pl> wrote:
>> >> On Wed, Oct 25, 2017 at 7:29 AM, Micha?? K??pie?? <kernel@kempniu.pl> wrote:
>> >> > Radio LED detection method implemented in commit 4f62568c1fcf
>> >> > ("fujitsu-laptop: Support radio LED") turned out to be incorrect as it
>> >> > causes a radio LED to be erroneously detected on a Fujitsu Lifebook E751
>> >> > which has a slide switch (and thus no radio LED). Use bit 17 of
>> >> > flags_supported (the value returned by method S000 of ACPI device
>> >> > FUJ02E3) to determine whether a radio LED is present as it seems to be a
>> >> > more reliable indicator, based on comparing DSDT tables of four Fujitsu
>> >> > Lifebook models (E744, E751, S7110, S8420).
>> >> >
>> >>
>> >> Pushed to my review and testing queue, thanks!
>> >
>> > I forgot that this patch can also be tagged with:
>> >
>> > Fixes: 4f62568c1fcf ("fujitsu-laptop: Support radio LED")
>>
>> Added.
>>
>> Do you consider this an important fix? We are at -rc7 now, I'm not
>> sure it's so critical. Tell me if you consider otherwise.
>
> I agree - from my perspective I wouldn't have thought it so critical as to
> push it out this late in the development cycle. It's not a regression as
> such and is largely cosmetic. Others may argue differently though.
>
Got it!
> BTW, it looks like you may have missed my Reviewed-by tag on this patch,
> sent on 25 Oct. There was also a Tested-by added by Heinrich Siebmanns on
> the same day:
>
> Reviewed-by: Jonathan Woithe <jwoithe@just42.net>
> Tested-by: Heinrich Siebmanns <harv@gmx.de>
The first one is indeed missed and sorry, can't touch the change
anymore (it is published now).
The second one is there.
So, I applied a patch with tags that were parsed by patchwork at that time.
Since Heinrich's ones are there, perhaps something happened to your
tag that it wasn't recognized, sorry.
> Or perhaps such peripheral tags aren't carried forward on patches like this,
> in which case it's a moot point.
It's okay to have them.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-10-30 14:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 4:29 Michał Kępień
2017-10-25 6:33 ` Jonathan Woithe
2017-10-25 13:11 ` Harvey
2017-10-27 16:49 ` Andy Shevchenko
2017-10-29 21:28 ` Michał Kępień
2017-10-30 11:21 ` Andy Shevchenko
2017-10-30 12:12 ` Jonathan Woithe
2017-10-30 14:13 ` Andy Shevchenko [this message]
2017-10-31 4:20 ` Michał Kępień
2017-10-31 10:54 ` Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vf-kohM2sTeDsoT2dPbHSQDd0eGU0FDA9Ua+CXrxvzigg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=harv@gmx.de \
--cc=jwoithe@just42.net \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®