From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751208AbdFANQJ (ORCPT <rfc822;w@1wt.eu>);
        Thu, 1 Jun 2017 09:16:09 -0400
Received: from mail-qk0-f180.google.com ([209.85.220.180]:32883 "EHLO
        mail-qk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751058AbdFANQI (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Jun 2017 09:16:08 -0400
MIME-Version: 1.0
In-Reply-To: <20170601150839.08fdb556@endymion>
References: <20170601150839.08fdb556@endymion>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Thu, 1 Jun 2017 16:16:05 +0300
Message-ID: <CAHp75Vf7R_GeFhA5c2PR42K=cp-UbK4u2o7B5N9Ceu_NdFXmzg@mail.gmail.com>
Subject: Re: [PATCH] firmware: dmi: Check DMI structure length
To: Jean Delvare <jdelvare@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Linus Walleij <linus.walleij@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 1, 2017 at 4:08 PM, Jean Delvare <jdelvare@suse.de> wrote:
> Before accessing DMI data to record it for later, we should ensure
> that the DMI structures are large enough to contain the data in
> question.

> -       const u8 *d = (u8 *) dm + index;
> +       const u8 *d;

> +       d = (u8 *) dm + index;

I think you may leave this as is and make it compiler's burden to optimize.

> -       const u8 *d = (u8 *) dm + index;
> +       const u8 *d;

> +       d = (u8 *) dm + index;

Ditto.

> -       int i, count = *(u8 *)(dm + 1);
> +       int i, count;

> +       count = *(u8 *)(dm + 1);

Ditto.

-- 
With Best Regards,
Andy Shevchenko