From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1029251-1517413434-2-2039200851410006820 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, FREEMAIL_FORGED_FROMDOMAIN 0.195, FREEMAIL_FROM 0.001, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='UTF-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517413434; b=ediQdKtaqAUCvBXKOG0p7ZGo7crEmjATb8t+YWEQ5cQa2IV XTr9G07x/ikrtT5zAVnWESNGiewOq6/EZLLvdX5TUhHBSfeMO8H9KwOxNHXxieXn fKVpjpd5d8nObqJ6dfCINi+e6LL6g+r4wvR12NaLoWGrRdK55NVCsWPmBvsRH5zu oGn8Xped7f5/qMgjeBWbtNb+Vj167SOaVqT/yUy1zESZVaCUJKDqGZ81v3TBMy75 IOH3G5UPbRO41XDvQ0TnzXdDRPuho9V5v9WxSRSj5sxs/VRlSo3DJ/tt2xFTUcbh b6Jz1tzLRDk+8JDjKL3qv+ZPUvWdrFTSKUNm6aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=mime-version:in-reply-to:references:from :date:message-id:subject:to:cc:content-type:sender:list-id; s= arctest; t=1517413434; bh=c1Glr3TT2I0H51gMfTbyEs3jVFwh+nyH81TgST I1GSY=; b=o8VdApbRZXjhtediBwU0swZDUxohjzf0yZTwtrsznqs/b3XtngiV2C wCaSFiQzITBwafXB7N7iSUjKfO4BLNY1edBngFdwgMRgOLdlkYwi3tcRze6dZx47 U+vYamGWxn8WtJIykmIu63iOASFAkk1dxir0rRebQK89oYKDIlMNm0VyCuETpSTX UXy3JOJLiLsiXfOEc9zW4cOifP4RRFia0EX4MMxFTbL8kwSWuyDHywE1ImJnOqJU AnUU8H9X51p+1I/5XnT8tAOGUShkbLq3iemKdXis4FlV14fU0azyYU2iw/1vVB9L WOiv6WMPKWI1f+KcbJrf08AMgXYM4QUA== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=pass (2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=QIXHuWd4 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=pass (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=n3S4PGw2; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=gmail.com header.result=pass header_is_org_domain=yes Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=pass (2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=QIXHuWd4 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=pass (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=n3S4PGw2; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=gmail.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932213AbeAaPno (ORCPT ); Wed, 31 Jan 2018 10:43:44 -0500 Received: from mail-qt0-f196.google.com ([209.85.216.196]:35051 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932087AbeAaPnl (ORCPT ); Wed, 31 Jan 2018 10:43:41 -0500 X-Google-Smtp-Source: AH8x227a5q92iz7btr3yHP3BKjvuAGV3u4dQgrgfULQOWVEB5FsFcCF0uR0ECajtFJgVk+spxGebYeaMStGH5Fbvlt8= MIME-Version: 1.0 In-Reply-To: References: <20180125143639.9969-1-jgross@suse.com> <20180125143639.9969-2-jgross@suse.com> From: Andy Shevchenko Date: Wed, 31 Jan 2018 17:43:40 +0200 Message-ID: Subject: Re: [PATCH v2 1/2] x86/acpi: add retrieval function for rsdp address To: "Rafael J. Wysocki" Cc: Juergen Gross , Linux Kernel Mailing List , ACPI Devel Maling List , xen-devel@lists.xenproject.org, Len Brown , "Rafael J. Wysocki" , Ingo Molnar , Boris Ostrovsky , Stable Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, Jan 29, 2018 at 5:02 AM, Rafael J. Wysocki wrote: > On Sun, Jan 28, 2018 at 4:04 PM, Andy Shevchenko > wrote: >> On Fri, Jan 26, 2018 at 8:21 PM, Juergen Gross wrote: >>> On 26/01/18 19:08, Andy Shevchenko wrote: >>>> On Thu, Jan 25, 2018 at 4:36 PM, Juergen Gross wrote: >>>> The problem with weak functions that we can't have more than one >>>> implementation per kernel while we would like to built several code >>>> paths. >>>> >>>> I have stumbled on the similar stuff and realize that. >>>> >>>> Perhaps, one of the solution is to have an additional struct under >>>> x86_init to alternate ACPI related stuff. >>> >>> I think we can go that route when another user of that interface is >>> appearing. >> >> Why not to establish the struct? At least this route I would like to >> go with [1]. >> >> [1]: https://lkml.org/lkml/2018/1/17/834 > > Maybe I'm a bit slow today, but care to explain what exactly you mean? Instead of declaring function as __weak, establish a new struct for ACPI related stubs and incorporate it into x86_init. That is my proposal. I think I would go this way in my case where I need to treat differently ACPI HW reduced initialization of legacy devices. -- With Best Regards, Andy Shevchenko