From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933485AbdC3LJg (ORCPT ); Thu, 30 Mar 2017 07:09:36 -0400 Received: from mail-qt0-f177.google.com ([209.85.216.177]:33716 "EHLO mail-qt0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932541AbdC3LJe (ORCPT ); Thu, 30 Mar 2017 07:09:34 -0400 MIME-Version: 1.0 In-Reply-To: <58DCE46C.3060501@samsung.com> References: <1490863178-12782-1-git-send-email-cw00.choi@samsung.com> <1490863178-12782-2-git-send-email-cw00.choi@samsung.com> <58DCCEBE.8040401@samsung.com> <58DCE46C.3060501@samsung.com> From: Andy Shevchenko Date: Thu, 30 Mar 2017 14:09:32 +0300 Message-ID: Subject: Re: [PATCH 2/2] extcon: Add new extcon_register_notifier_all() to monitor all external connectors To: Chanwoo Choi Cc: "linux-kernel@vger.kernel.org" , Hans de Goede , chanwoo@kernel.org, MyungJoo Ham Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2UB9jor021764 On Thu, Mar 30, 2017 at 1:56 PM, Chanwoo Choi wrote: > On 2017년 03월 30일 19:42, Andy Shevchenko wrote: >> On Thu, Mar 30, 2017 at 12:24 PM, Chanwoo Choi wrote: >>> On 2017년 03월 30일 18:05, Andy Shevchenko wrote: >>>> On Thu, Mar 30, 2017 at 11:39 AM, Chanwoo Choi wrote: >>>>> +/** >>>>> + * extcon_register_notifier_all() - Register a notifier block to get the noti >>>>> + * of the status change for all supported external >>>>> + * connectors from extcon. >>>>> + * @edev: the extcon device that has the external connecotr. >>>>> + * @nb: a notifier block to be registered. >>>>> + * >>>>> + * Note that the second parameter given to the callback of nb (val) is >>>>> + * the current state and third parameter is the edev pointer. >>>>> + */ > If you metioned the following guide on Line 111 > in the Documentation/doc-guide/kernel-doc.rst, Yes, that's one. > OK. I'll modify it. Thanks. > > Example kernel-doc function comment:: > > /** > * foobar() - Brief description of foobar. > * @arg: Description of argument of foobar. > * > * Longer description of foobar. > * > * Return: Description of return value of foobar. > */ > int foobar(int arg) > > -- > Best Regards, > Chanwoo Choi > Samsung Electronics -- With Best Regards, Andy Shevchenko