From: Per Forlin <per.forlin@linaro.org>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linaro-dev@lists.linaro.org,
Nicolas Pitre <nicolas.pitre@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-doc@vger.kernel.org, Venkatraman S <svenkatr@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Arnd Bergmann <arnd@arndb.de>,
Sourav Poddar <sourav.poddar@ti.com>, Chris Ball <cjb@laptop.org>,
J Freyensee <james_p_freyensee@linux.intel.com>,
Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: [PATCH v3 2/3] mmc: core: add random fault injection
Date: Mon, 25 Jul 2011 21:19:21 +0200 [thread overview]
Message-ID: <CAJ0pr1_rL8rsEbDR-PL6fs9EzyGfUMbmeUjTGk=WspvrAkdy+g@mail.gmail.com> (raw)
In-Reply-To: <CAC5umyg44tQxrFEYRL-tjzBMA2+KNXjB+nQveH3KcB_LPmYVHw@mail.gmail.com>
On 25 July 2011 17:58, Akinobu Mita <akinobu.mita@gmail.com> wrote:
> 2011/7/21 Per Forlin <per.forlin@linaro.org>:
>> This adds support to inject data errors after a completed host transfer.
>> The mmc core will return error even though the host transfer is successful.
>> This simple fault injection proved to be very useful to test the
>> non-blocking error handling in the mmc_blk_issue_rw_rq().
>> Random faults can also test how the host driver handles pre_req()
>> and post_req() in case of errors.
>
> Looks good to me.
>
Thanks,
>> @@ -82,6 +87,66 @@ static void mmc_flush_scheduled_work(void)
>> flush_workqueue(workqueue);
>> }
>>
>> +#ifdef CONFIG_FAIL_MMC_REQUEST
>> +
>> +static DECLARE_FAULT_ATTR(fail_mmc_request);
>
> I think the fail_attr should be defined for each mmc_host like make_it_fail
> in struct mmc_host and debugfs entries should also be created in a
> subdirectory of mmc host debugfs.
>
I looked at blk-core.c and used the same code here. Current code
creates the entry under the debugfs root. This means one fail_attr for
all hosts.
I agree, it's more clean to move the fail_attr to the
host-debugfs-entry which require the fail_attr to be stored same way
as make_it_fail.
> And I know that init_fault_attr_dentries() can only create a
> subdirectory in debugfs root directory. But I have a patch which
> support for creating it in arbitrary directory. Could you take a look
> at this? (Note that this patch is based on mmotm and not yet tested)
>
Thanks, I will check it out.
Regards,
Per
next prev parent reply other threads:[~2011-07-25 19:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 22:01 [PATCH v3 0/3] Make fault injection available for MMC IO Per Forlin
2011-07-20 22:01 ` [PATCH v3 1/3] fault-inject: make fault injection available for modules Per Forlin
2011-07-20 22:02 ` [PATCH v3 2/3] mmc: core: add random fault injection Per Forlin
2011-07-25 15:58 ` Akinobu Mita
2011-07-25 19:19 ` Per Forlin [this message]
2011-07-25 21:20 ` Per Forlin
2011-07-26 1:41 ` Akinobu Mita
2011-07-26 20:01 ` Per Forlin
2011-07-26 20:08 ` Per Forlin
2011-07-20 22:02 ` [PATCH v3 3/3] fault injection: add documentation on MMC IO " Per Forlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ0pr1_rL8rsEbDR-PL6fs9EzyGfUMbmeUjTGk=WspvrAkdy+g@mail.gmail.com' \
--to=per.forlin@linaro.org \
--cc=akinobu.mita@gmail.com \
--cc=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=james_p_freyensee@linux.intel.com \
--cc=kyungmin.park@samsung.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=rdunlap@xenotime.net \
--cc=sourav.poddar@ti.com \
--cc=svenkatr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®