From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50177C43334 for ; Mon, 27 Jun 2022 16:29:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239233AbiF0Q3x (ORCPT ); Mon, 27 Jun 2022 12:29:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239196AbiF0Q3v (ORCPT ); Mon, 27 Jun 2022 12:29:51 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DBF3B7C7 for ; Mon, 27 Jun 2022 09:29:50 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id v65-20020a1cac44000000b003a03c76fa38so5203844wme.5 for ; Mon, 27 Jun 2022 09:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kCgDBgQt6lsYAKDyUa0fPFsfL97zuKyIxwCybKNVm6o=; b=IuiG/blkJ7gXjOQhLgtlkFYoJRK5r8pgakqSWN1/zlxqf40s05Q2KxgVLRnXAzs+fg ulTgDq4Xa1IQ2RvaytKxJcvgFOnViaFiqQeqoT8bFMwQmOfmx5WYvBOMGbjbujaxBKq2 ZxRw26go6NuTS6kLvJS34xZfj51gNbDxnvzESq7KPA+97DIORIk3qqV6wvZaFYlRyp37 iYjN5F2Fx3qCzsMwgAJwoELntygw5WoMYjcgqI9vY49AS4kLGOtkbsV2NX3QusZYb24t UMBgY7EFeybOiOqeaEkIwXo3wZRzJbzLQJE66d9iQWRd6teu2XSLOdmiKZKg0XoS0prd qUlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kCgDBgQt6lsYAKDyUa0fPFsfL97zuKyIxwCybKNVm6o=; b=tqIcpVtDHpGBtwZe39UVng1s7CYSTjq2hCgLRmgZEPWN2ZnJgXprWtKoFpGmDCmAil gudbOl9do1t2HkPHzPRR1wIaES3WU9VTOImwTfF3cSYUBxssHiTvG99pvCHDIcnSX55s fERim8Kvy1YUi3VVhsoEn+S5P84d+cjmF52271e0Njv39LpzLrOCIaiOazJYWJI2RLmw yxzVPNSmRBMS+LYk5D3H/BJPNCgKm+ubnTKpPzypuK1xiOK/BScOKj/1kY6GIfvK3Vaq DD81BazAhdeqi/pGdmDIXL5cXZwUdFBuufqJWlHJ76bTcWX39khgicsXP8jLE5RzGQCh 6Ueg== X-Gm-Message-State: AJIora/0zthVpVigZw1qJ1Q7fcxefvQdefv+QCCeaL9CvnSMnsc2gXLp Z9BQOCn9/YyOi8qXuu/08K4+GXOlao9QLy7tkANhfw== X-Google-Smtp-Source: AGRyM1vrDRm9Dztps4OpWjfEHDZNDaLLcMTy/XMsmuqPQoMJ/tNBlVur8bjCqgfF0MDzD0AVg6RDeZvfzsVoc13BMio= X-Received: by 2002:a05:600c:34cc:b0:39c:832c:bd92 with SMTP id d12-20020a05600c34cc00b0039c832cbd92mr16254989wmq.24.1656347388958; Mon, 27 Jun 2022 09:29:48 -0700 (PDT) MIME-Version: 1.0 References: <20220606222058.86688-1-yosryahmed@google.com> <20220606222058.86688-4-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Mon, 27 Jun 2022 09:29:12 -0700 Message-ID: Subject: Re: [PATCH v5 3/4] KVM: x86/mmu: count KVM mmu usage in secondary pagetable stats. To: Sean Christopherson Cc: Tejun Heo , Johannes Weiner , Zefan Li , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Oliver Upton , Cgroups , Linux Kernel Mailing List , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Linux-MM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 27, 2022 at 9:22 AM Sean Christopherson wrote: > > On Mon, Jun 06, 2022, Yosry Ahmed wrote: > > Count the pages used by KVM mmu on x86 for in secondary pagetable stats. > > "for in" is funky. And it's worth providing a brief explanation of what the > secondary pagetable stats actually are. "secondary" is confusingly close to > "second level pagetables", e.g. might be misconstrued as KVM counters for the > number of stage-2 / two-dimension paging page (TDP) tables. > > Code looks good, though it needs a rebased on kvm/queue. Will rebase and modify the commit message accordingly, thanks!