mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Anup Patel <apatel@ventanamicro.com>
Cc: "Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Jassi Brar" <jassisinghbrar@gmail.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Uwe Kleine-König" <ukleinek@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Alexandre Ghiti" <alex@ghiti.fr>, "Len Brown" <lenb@kernel.org>,
	"Sunil V L" <sunilvl@ventanamicro.com>,
	"Rahul Pathak" <rpathak@ventanamicro.com>,
	"Leyfoon Tan" <leyfoon.tan@starfivetech.com>,
	"Atish Patra" <atish.patra@linux.dev>,
	"Andrew Jones" <ajones@ventanamicro.com>,
	"Samuel Holland" <samuel.holland@sifive.com>,
	"Anup Patel" <anup@brainfault.org>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-acpi@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 15/24] ACPI: property: Add support for cells property
Date: Wed, 2 Jul 2025 12:20:55 +0200	[thread overview]
Message-ID: <CAJZ5v0iYYuK2GF2Pg3NiO4vLFzoYm6Q3Dnk5O2DkMJm1R3qSfQ@mail.gmail.com> (raw)
In-Reply-To: <20250702051345.1460497-16-apatel@ventanamicro.com>

On Wed, Jul 2, 2025 at 7:16 AM Anup Patel <apatel@ventanamicro.com> wrote:
>
> From: Sunil V L <sunilvl@ventanamicro.com>
>
> Currently, ACPI doesn't support cells property when
> fwnode_property_get_reference_args() is called.

What exactly do you mean by "cells property" here and below?

> ACPI always expects
> the number of arguments to be passed. However, the above mentioned
> call being a common interface for OF and ACPI, it is better to have
> single calling convention which works for both. Hence, add support
> for cells property on the reference device to get the number of
> arguments dynamically.
>
> Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> Signed-off-by: Anup Patel <apatel@ventanamicro.com>
> ---
>  drivers/acpi/property.c | 22 ++++++++++++++++++----
>  drivers/base/property.c |  2 +-
>  2 files changed, 19 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
> index d4863746fb11..d08b0ea5c915 100644
> --- a/drivers/acpi/property.c
> +++ b/drivers/acpi/property.c
> @@ -882,6 +882,17 @@ static struct fwnode_handle *acpi_parse_string_ref(const struct fwnode_handle *f
>         return &dn->fwnode;
>  }
>
> +static unsigned int acpi_fwnode_get_args_count(const struct acpi_device *device,
> +                                              const char *nargs_prop)
> +{
> +       const union acpi_object *obj;
> +
> +       if (acpi_dev_get_property(device, nargs_prop, ACPI_TYPE_INTEGER, &obj))
> +               return 0;
> +
> +       return obj->integer.value;
> +}
> +
>  static int acpi_fwnode_get_reference_args(const struct fwnode_handle *fwnode,
>                                           const char *propname, const char *nargs_prop,
>                                           unsigned int args_count, unsigned int index,
> @@ -892,6 +903,7 @@ static int acpi_fwnode_get_reference_args(const struct fwnode_handle *fwnode,
>         const struct acpi_device_data *data;
>         struct fwnode_handle *ref_fwnode;
>         struct acpi_device *device;
> +       unsigned int nargs_count;
>         int ret, idx = 0;
>
>         data = acpi_device_data_of_node(fwnode);
> @@ -960,11 +972,12 @@ static int acpi_fwnode_get_reference_args(const struct fwnode_handle *fwnode,
>                         if (!device)
>                                 return -EINVAL;
>
> +                       nargs_count = acpi_fwnode_get_args_count(device, nargs_prop);

I think it should work the same way as it used to for the callers that
pass args_count, so maybe

if (!args_count)
        args_count = acpi_fwnode_get_args_count(device, nargs_prop);

>                         element++;
> -
>                         ret = acpi_get_ref_args(idx == index ? args : NULL,
>                                                 acpi_fwnode_handle(device),
> -                                               &element, end, args_count);
> +                                               &element, end,
> +                                               nargs_count ? nargs_count : args_count);

And this change would not be necessary?

And analogously below.

>                         if (ret < 0)
>                                 return ret;
>
> @@ -978,11 +991,12 @@ static int acpi_fwnode_get_reference_args(const struct fwnode_handle *fwnode,
>                         if (!ref_fwnode)
>                                 return -EINVAL;
>
> +                       device = to_acpi_device_node(ref_fwnode);
> +                       nargs_count = acpi_fwnode_get_args_count(device, nargs_prop);
>                         element++;
> -
>                         ret = acpi_get_ref_args(idx == index ? args : NULL,
>                                                 ref_fwnode, &element, end,
> -                                               args_count);
> +                                               nargs_count ? nargs_count : args_count);
>                         if (ret < 0)
>                                 return ret;
>
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index f626d5bbe806..6a63860579dd 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -578,7 +578,7 @@ EXPORT_SYMBOL_GPL(fwnode_property_match_property_string);
>   * @prop:      The name of the property
>   * @nargs_prop:        The name of the property telling the number of
>   *             arguments in the referred node. NULL if @nargs is known,
> - *             otherwise @nargs is ignored. Only relevant on OF.
> + *             otherwise @nargs is ignored.
>   * @nargs:     Number of arguments. Ignored if @nargs_prop is non-NULL.
>   * @index:     Index of the reference, from zero onwards.
>   * @args:      Result structure with reference and integer arguments.
> --

  reply	other threads:[~2025-07-02 10:21 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02  5:13 [PATCH v7 00/24] Linux SBI MPXY and RPMI drivers Anup Patel
2025-07-02  5:13 ` [PATCH v7 01/24] dt-bindings: mailbox: Add bindings for RPMI shared memory transport Anup Patel
2025-07-02  5:13 ` [PATCH v7 02/24] dt-bindings: mailbox: Add bindings for RISC-V SBI MPXY extension Anup Patel
2025-07-02  5:13 ` [PATCH v7 03/24] RISC-V: Add defines for the SBI message proxy extension Anup Patel
2025-07-02 12:03   ` Andy Shevchenko
2025-07-02 12:06   ` Andy Shevchenko
2025-07-03  5:16     ` Anup Patel
2025-07-02  5:13 ` [PATCH v7 04/24] mailbox: Add common header for RPMI messages sent via mailbox Anup Patel
2025-07-02  5:13 ` [PATCH v7 05/24] mailbox: Allow controller specific mapping using fwnode Anup Patel
2025-07-02 12:32   ` Andy Shevchenko
2025-07-02  5:13 ` [PATCH v7 06/24] byteorder: Add memcpy_to_le32() and memcpy_from_le32() Anup Patel
2025-07-02 11:30   ` Andy Shevchenko
2025-07-04  8:16   ` Linus Walleij
2025-07-02  5:13 ` [PATCH v7 07/24] mailbox: Add RISC-V SBI message proxy (MPXY) based mailbox driver Anup Patel
2025-07-02 12:50   ` Andy Shevchenko
2025-07-03  6:52     ` Anup Patel
2025-07-02  5:13 ` [PATCH v7 08/24] dt-bindings: clock: Add RPMI clock service message proxy bindings Anup Patel
2025-07-02  5:13 ` [PATCH v7 09/24] dt-bindings: clock: Add RPMI clock service controller bindings Anup Patel
2025-07-02  5:13 ` [PATCH v7 10/24] clk: Add clock driver for the RISC-V RPMI clock service group Anup Patel
2025-07-02 13:08   ` Andy Shevchenko
2025-07-04  4:15     ` Anup Patel
2025-07-02  5:13 ` [PATCH v7 11/24] dt-bindings: Add RPMI system MSI message proxy bindings Anup Patel
2025-07-02  5:13 ` [PATCH v7 12/24] dt-bindings: Add RPMI system MSI interrupt controller bindings Anup Patel
2025-07-02  5:13 ` [PATCH v7 13/24] irqchip: Add driver for the RPMI system MSI service group Anup Patel
2025-07-02  5:13 ` [PATCH v7 14/24] ACPI: property: Refactor acpi_fwnode_get_reference_args() Anup Patel
2025-07-02 10:07   ` Rafael J. Wysocki
2025-07-02 14:45     ` Sunil V L
2025-07-02 17:01       ` Rafael J. Wysocki
2025-07-02  5:13 ` [PATCH v7 15/24] ACPI: property: Add support for cells property Anup Patel
2025-07-02 10:20   ` Rafael J. Wysocki [this message]
2025-07-02 11:37     ` Andy Shevchenko
2025-07-02 11:39       ` Andy Shevchenko
2025-07-02 12:39       ` Rafael J. Wysocki
2025-07-02 12:56         ` Andy Shevchenko
2025-07-02 13:16           ` Rafael J. Wysocki
2025-07-02 15:06         ` Sunil V L
2025-07-02 16:56           ` Rafael J. Wysocki
2025-07-03  9:31             ` Sunil V L
2025-07-02 11:44   ` Andy Shevchenko
2025-07-02  5:13 ` [PATCH v7 16/24] ACPI: scan: Update honor list for RPMI System MSI Anup Patel
2025-07-02 10:21   ` Rafael J. Wysocki
2025-07-02 11:45   ` Andy Shevchenko
2025-07-02  5:13 ` [PATCH v7 17/24] ACPI: RISC-V: Create interrupt controller list in sorted order Anup Patel
2025-07-02  5:13 ` [PATCH v7 18/24] ACPI: RISC-V: Add support to update gsi range Anup Patel
2025-07-02  5:13 ` [PATCH v7 19/24] ACPI: RISC-V: Add RPMI System MSI to GSI mapping Anup Patel
2025-07-02  5:13 ` [PATCH v7 20/24] irqchip/irq-riscv-imsic-early: Export imsic_acpi_get_fwnode() Anup Patel
2025-07-02  5:13 ` [PATCH v7 21/24] mailbox/riscv-sbi-mpxy: Add ACPI support Anup Patel
2025-07-02 12:28   ` Andy Shevchenko
2025-07-03 10:54     ` Sunil V L
2025-07-03 13:54       ` Andy Shevchenko
2025-07-03 14:26         ` Anup Patel
2025-07-03 14:32           ` Andy Shevchenko
2025-07-02  5:13 ` [PATCH v7 22/24] irqchip/riscv-rpmi-sysmsi: " Anup Patel
2025-07-02  5:13 ` [PATCH v7 23/24] RISC-V: Enable GPIO keyboard and event device in RV64 defconfig Anup Patel
2025-07-02  5:13 ` [PATCH v7 24/24] MAINTAINERS: Add entry for RISC-V RPMI and MPXY drivers Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJZ5v0iYYuK2GF2Pg3NiO4vLFzoYm6Q3Dnk5O2DkMJm1R3qSfQ@mail.gmail.com \
    --to=rafael@kernel.org \
    --cc=ajones@ventanamicro.com \
    --cc=alex@ghiti.fr \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=anup@brainfault.org \
    --cc=apatel@ventanamicro.com \
    --cc=atish.patra@linux.dev \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lenb@kernel.org \
    --cc=leyfoon.tan@starfivetech.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=mturquette@baylibre.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=rpathak@ventanamicro.com \
    --cc=samuel.holland@sifive.com \
    --cc=sboyd@kernel.org \
    --cc=sunilvl@ventanamicro.com \
    --cc=tglx@linutronix.de \
    --cc=ukleinek@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®