From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933304AbdKOR6y (ORCPT <rfc822;w@1wt.eu>);
        Wed, 15 Nov 2017 12:58:54 -0500
Received: from mail-ot0-f195.google.com ([74.125.82.195]:50418 "EHLO
        mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753456AbdKOR6p (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 15 Nov 2017 12:58:45 -0500
X-Google-Smtp-Source: AGs4zMZhubp/THDogmldJrDF1t0PnuTH4YFs4pbdSkyQoBbumJgX/vqNNeQzayw06d1CpHhjV1O+oL3Sv4L+6SvNPzU=
MIME-Version: 1.0
In-Reply-To: <CS1PR8401MB05189C5186CD6E4B6509EAD5D9290@CS1PR8401MB0518.NAMPRD84.PROD.OUTLOOK.COM>
References: <1510306686-18230-1-git-send-email-vikas.cha.sajjan@hpe.com>
 <CAJZ5v0g8d=q1TZvacBZ_EDMjAnufQdHYkfbnkhv4kSH_FNOhDg@mail.gmail.com> <CS1PR8401MB05189C5186CD6E4B6509EAD5D9290@CS1PR8401MB0518.NAMPRD84.PROD.OUTLOOK.COM>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Wed, 15 Nov 2017 18:58:44 +0100
X-Google-Sender-Auth: LB3r1Lblazy-AQ34gQaFch3l1X0
Message-ID: <CAJZ5v0jQErbC729H0JCjO-RqJRYZ8P2zHdJm0HopXNB781G_aw@mail.gmail.com>
Subject: Re: [PATCH] x86/acpi: Fix improper handling of SCI INT for platforms
 supporting only IOAPIC mode
To: "Sajjan, Vikas C" <vikas.cha.sajjan@hpe.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Seunghun Han <kkamagui@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>,
        "Lakshminarasimha, Sunil Vishwanathpur" <sunil.vl@hpe.com>,
        "Attar, Abdul Lateef" <abdul-lateef.attar@hpe.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vAFHx0L8023636

On Wed, Nov 15, 2017 at 6:30 PM, Sajjan, Vikas C
<vikas.cha.sajjan@hpe.com> wrote:
> Hi Rafael,
>
> -----Original Message-----
> From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of Rafael J. Wysocki
> Sent: Wednesday, November 15, 2017 10:51 PM
> To: Sajjan, Vikas C <vikas.cha.sajjan@hpe.com>
> Cc: Linux PM <linux-pm@vger.kernel.org>; ACPI Devel Maling List <linux-acpi@vger.kernel.org>; Rafael J. Wysocki <rjw@rjwysocki.net>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Seunghun Han <kkamagui@gmail.com>; Thomas Gleixner <tglx@linutronix.de>; Ingo Molnar <mingo@kernel.org>; Lakshminarasimha, Sunil Vishwanathpur <sunil.vl@hpe.com>; Attar, Abdul Lateef <abdul-lateef.attar@hpe.com>
> Subject: Re: [PATCH] x86/acpi: Fix improper handling of SCI INT for platforms supporting only IOAPIC mode
>
> On Fri, Nov 10, 2017 at 10:38 AM, Vikas C Sajjan <vikas.cha.sajjan@hpe.com> wrote:
>> The platforms which support only IOAPIC mode and whose SCI INT is
>> greater than 16, passes SCI INT via FADT and not via MADT int src
>> override structure. In such cases current logic fails to handle it and
>> throws error "Invalid bus_irq %u for legacy override". This patch
>> handles the above  mentioned case. While at it, also modify function
>> mp_override_legacy_irq() to use the newly introduced function mp_register_ioapic_irq().
>
> Actually, is it necessary to make this extra change here?
>
> How complicated would it be to separate it out?
>
> I can move these extra changes into a separate patch and keep only the fix in this patch.

That would be useful I think in case someone wants to backport your
fix, for example.

Thanks,
Rafael