mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki (Intel)" <rafael@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>,
	Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: zero-initialize policy cpumask before sysfs publication
Date: Fri, 4 Sep 2026 17:49:39 +0200	[thread overview]
Message-ID: <CAJZ5v0jdhLSaRrrOTmpKcop47i_8G1UMFZOMEhmdDMvaivkTug@mail.gmail.com> (raw)
In-Reply-To: <apemScUaVXUn8sR6@vireshk-B250M-D3H>

On Wed, Sep 2, 2026 at 6:30 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 01-09-26, 22:36, Zhongqiu Han wrote:
> > cpufreq_policy_alloc() allocates policy->cpus with alloc_cpumask_var(),
> > i.e. without __GFP_ZERO, unlike the sibling related_cpus and real_cpus
> > masks. With CONFIG_CPUMASK_OFFSTACK=y the mask is a separate
> > kmalloc_node() allocation, so its bitmap holds whatever the slab allocator
> > left behind:
> >
> >   cpufreq_online()
> >     cpufreq_policy_alloc()
> >       alloc_cpumask_var(&policy->cpus)    /* bitmap is uninitialized */
> >       kobject_init_and_add()              /* policy%u/ appears in sysfs */
> >     cpufreq_policy_online()
> >       cpumask_copy(policy->cpus, cpumask_of(cpu))  /* first valid value */
> >
> > This leaves a window in which the sysfs attributes are already reachable
> > while policy->cpus is still garbage. show()/store() gate on
> > policy_is_inactive(), i.e. cpumask_empty(policy->cpus), so a non-zero
> > bitmap makes them run the attribute callbacks on a policy that is not
> > initialized yet.
> >
> > Fix this by using zalloc_cpumask_var() for policy->cpus.
> >
> > Fixes: 2fc3384dc75b ("cpufreq: Initialize policy->kobj while allocating policy")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
> > ---
> > This patch is based on https://lore.kernel.org/all/83f87db8-fa13-41d0-ae52-544d22e228e6@oss.qualcomm.com/
> >
> >  drivers/cpufreq/cpufreq.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > index 0d0df986fa3d..3b1b2ed86cc3 100644
> > --- a/drivers/cpufreq/cpufreq.c
> > +++ b/drivers/cpufreq/cpufreq.c
> > @@ -1249,7 +1249,7 @@ static struct cpufreq_policy *cpufreq_policy_alloc(unsigned int cpu)
> >       if (!policy)
> >               return NULL;
> >
> > -     if (!alloc_cpumask_var(&policy->cpus, GFP_KERNEL))
> > +     if (!zalloc_cpumask_var(&policy->cpus, GFP_KERNEL))
> >               goto err_free_policy;
> >
> >       if (!zalloc_cpumask_var(&policy->related_cpus, GFP_KERNEL))
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> --

Applied as 7.3-rc material, thanks!

      reply	other threads:[~2026-09-04 15:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01 14:36 Zhongqiu Han
2026-09-02  4:30 ` Viresh Kumar
2026-09-04 15:49   ` Rafael J. Wysocki (Intel) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJZ5v0jdhLSaRrrOTmpKcop47i_8G1UMFZOMEhmdDMvaivkTug@mail.gmail.com \
    --to=rafael@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=viresh.kumar@linaro.org \
    --cc=zhongqiu.han@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®