Re: [PATCH v1 0/4] ACPI: Use named initializers for acpi_device_id arrays

["Rafael J. Wysocki (Intel)" <rafael@kernel.org>]

On Fri, Nov 13, 2026 at 9:04 PM Uwe Kleine-König (The Capable Hub)
<u.kleine-koenig@baylibre.com> wrote:
>
> On Fri, Nov 13, 2026 at 05:17:30PM +0100, Rafael J. Wysocki (Intel) wrote:
> > On Fri, Nov 13, 2026 at 12:14 PM Uwe Kleine-König (The Capable Hub)
> > <u.kleine-koenig@baylibre.com> wrote:
> > >
> > > From: Uwe Kleine-König <ukleinek@kernel.org>
> > >
> > > Hello,
> > >
> > > this series is about preparing drivers/acpi for a change to struct
> > > acpi_device_id. The idea is to replace .driver_data by an anonymous
> > > union, see
> > > https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.com/
> > > for more details. (The linked example is about platform_device_id, I
> > > intend to apply it acpi_device_id and several others, too.)
> > >
> > > Before this union can be added, all initializers must use named
> > > initializers (C99 calls them designated initializers), which IMHO is a
> > > nice cleanup that can stand for itself as it makes the code easier to
> > > read.
> > >
> > > Pawel sent a similar series earlier, find it at
> > > https://lore.kernel.org/all/20260727-acpi-refactor-v1-0-ff900aa326ee@thegoodpenguin.co.uk/.
> > > Compared to that the patch splitting is done differently and the base
> > > here is newer.
> > >
> > > I checked for the other *_device_id and for these there is nothing to do
> > > below drivers/acpi because the few instances already use named
> > > initializers.
> > >
> > > The last patch in this series is just some cosmetic to align the coding
> > > style. If you consider it churn, just drop it.
> > >
> > > It would be great to get this series in soon, as keeping it up to date
> > > for a later resend is an annoying effort. Thanks for your cooperation.
> > >
> > > Best regards
> > > Uwe
> > >
> > > Uwe Kleine-König (The Capable Hub) (4):
> > >   ACPI: Unify acpi_device_id list terminators
> > >   ACPI: Drop unused .driver_data initializers in acpi_device_id arrays
> > >   ACPI: Use named initializers for acpi_device_id arrays
> > >   ACPI: Unify *_device_id list terminators
> >
> > All patches applied as 7.5 material, thanks!
>
> That's great, thank you.
>
> I fatfingered my author address in patch 2, so if someone wails that the
> author S-o-b is missing and your tree isn't set in stone yet, something like:
>
>         git filter-branch -f --env-filter 'if test "$GIT_AUTHOR_NAME" = "Uwe Kleine-König (The Capable Hub)"; then GIT_AUTHOR_EMAIL=u.kleine-koenig@baylibre.com; fi' next/master..
>
> should fix it. Sorry!

Thanks for the heads-up, I fixed it up.