From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDC6137E5FD for ; Fri, 17 Jul 2026 20:58:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.208.41 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784321923; cv=pass; b=WwmQiI0pXxx0ViUOy2ls6YWVMdM+EnKdQv07oOQW74CqDvrW8oer5Fu36lms5ac0mMIZ+xPeZYEuULTBRyYo/vTy6fOjfbAMFL+/DknxbMQdBx8nTL4Gj7I0jdDT5/IOrfG41AE0wboNILYlzHldBHPfYtcxI3wV83PN3wlGNRM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784321923; c=relaxed/simple; bh=AaHe0iwVYVtFnnVoU1xS/Nv4RLKGQrG7mpCjW+za+D0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=NXAGSNeT43qWoIN80rSc8BRMEcMET2N5m8J+0NMXQxVkmeWzz0DQfkfwSX3icJd7sqEqjdtuTxA6GYVWPkVMo1MB7ixHpCjdCD9sFvfu0hKUYm7lAJjUI7qz+7crSlebhjyn/wRQJXl6cfXf9eCqlrUPpSHsrE+I3Fa2tBLK3pI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RVpeC9nd; arc=pass smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RVpeC9nd" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-69e5f8a193bso1985999a12.2 for ; Fri, 17 Jul 2026 13:58:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1784321920; cv=none; d=google.com; s=arc-20260327; b=Pa677dppohinRCXIfWFohTdH0eQaeeChjxEqMfXtmG+S/S200pSxrrTPpKL0+ZhKbM IIE4oXAvEDM35XfkS4/W/UHzsoWqxF6NK5UVwCfaz+vquknji9M4prlShjoY7p5rbz+n z3so//YmShMtEXAMxryQk1fnrqCA4hhSs3wRYterBjIrZgiUeA7H034BiaaShLqVrho+ jr9qvIbWm/dgZRWWUdKN8nA4sf3sLVhLg1kEb6x1svK7YSlbJ/VaXliTt+iJMh7C/xjD y9Z152XeU3slkmLWuDqqBHaFTsxNvC2GhBvyvPZVe+8fxLNsXD3Vz/i92jTAjZ7Tinwg oJ1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=AaHe0iwVYVtFnnVoU1xS/Nv4RLKGQrG7mpCjW+za+D0=; fh=VyzqH/qB/NhaUqk3UQH8YeP7vF7Y6qDdmTb4c6ilM3I=; b=CPoVpZiMub4Eoxw0BkCGLQf6+JI1V9iA/3hERpf9rlhNv3mJRisvv0DHmmyctdG+P5 Fk7wwk0sektD1PqyDjjuJfIcAzdJzOXAc8AtRsMG+YfvfCJT80LYKgbicqXRUu2fboEP NxgSsf4PS3NL8aLR/NxvDmlutdFgHhFKpQczPTA0skYDQ7XLdtbNeZP/Ym8Fm72Tt424 zqkUO+kwfjXhCSizcAB+kYEb6onnR5qKSZ7P7HblasHQFGYiRyHaygRuh7iPeEcxvkL7 kxITNebiK1SdGyy3uW9hlJyoMizQ1fI+SlKW2gDCjI9ZajsjNh9gNIQQA4+lEPz4wnWz hBSg==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784321920; x=1784926720; darn=vger.kernel.org; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AaHe0iwVYVtFnnVoU1xS/Nv4RLKGQrG7mpCjW+za+D0=; b=RVpeC9ndGQDpzZfDpKyYMtGrZtjpJBZ94QRdXTHCTGgwVoZr+T0js/EvFsRQcjO9XQ LMXq7Dsezne9S3fLoKwn7NLsnr/aGxgTSI0y9l8hMXaCuacRiQic5ZP/MmaUvATT3Rq5 DA5bXUVIVFwrHJYwviag556pXKmLA7V2en/lT0QrUhwIGSlhnM55n+jQXNmZVIxWu0Oc QhMUKV1S83Tv97PLkjvq2wvwIUHxg49l4X0EPvXKwSLzYOMQe23/PtaBwZE/gpE0JqTP vTJ3s0Z5L27/meSZdssRIinHYs9cby+VH6g1oLyPP8LgctvyUo83Gkq1tNDodM0i3+3f 7GeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784321920; x=1784926720; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=AaHe0iwVYVtFnnVoU1xS/Nv4RLKGQrG7mpCjW+za+D0=; b=ByvjMC5loVcLgZtAgp4opiU3RBKc4dIC6frOIhtt2UdE4h6dlQgZne3BsbA6tJWjvZ SazAsmaI3cbkDU2uoM8ZZeK1KDXOGerS51waLjTmHG8fc4L51KdjEBjX7831v2nKEr0x lmkbZB3aITbtKvC6BvuNICdgBA7Ws3f17zvFA6oDZgts/R4oIeXb8Se6cnjQPbXAbBij 6lngHaDf2atx2gKLwY7tEvtuSCyfjQitv9LS0dAVtaEHu+QJMizbJCt8R4DF2+LbFoN3 cd+0hdqcDAHSDj097JxBlxYS+v8aV9Yl/vCzIzny7XBbHpyp3BBbJCw2O4vcIAqt789n G6Ig== X-Forwarded-Encrypted: i=1; AHgh+RqK4Jairq6+mSkw0FhpEbPOfU5y3sL3oM17syal6NXVaZ67YlCdHVgJOibWuPxafYt7BzFsFWfWqKAm9IE=@vger.kernel.org X-Gm-Message-State: AOJu0YyyDQfjBhwuXVBpW/Xr30eocCj47RKgmYscAQabCAX2oy8QQtqw +V9iq3OZPg21QpJnPcv8AVW8CxadtK2VBJ8bwv+LN3twtmb0f12HWzkyeTSzh+4XPkIBP53/ykN sCJ4dMzbjdsOysdcgB2BAmVfF1LjZjwI= X-Gm-Gg: AfdE7cmZ8zbdLizYo9vARFu7dB66t0/C09mV2mvIrmK3EC18DtsaMTsy5RWeKz6IIPA FI+8rx0Bm20ynMhebpmvTKP1Gx1bK6XlaSBWwCJQgFnIgPl3qfrgTE61U9ldLDTjgmY6htNWfXq AcjOQKTET46qv/PUbDnjvb7qZQDf2pE5smqIwiR2F7PH5Jo+AmL7B34CbtF1/fOefTIhKJgF7Mt IkNjIaLKj6BKRzEDWF3IuvOo2tiEJaT0zPtney+6a3LI6MGM3I54ARHvLApO1DL X-Received: by 2002:a17:907:e84a:b0:c16:e3b:7d6 with SMTP id a640c23a62f3a-c16b4807dfbmr161386766b.54.1784321919929; Fri, 17 Jul 2026 13:58:39 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260717190544.257306-2-main.kalliope@gmail.com> <730b11181226fe2aa47c5add541431bb8bd4b4fa6af6e3b41bd8a09161d2f51c@mail.kernel.org> In-Reply-To: <730b11181226fe2aa47c5add541431bb8bd4b4fa6af6e3b41bd8a09161d2f51c@mail.kernel.org> From: Nicholas Dudar Date: Fri, 17 Jul 2026 16:58:27 -0400 X-Gm-Features: AUfX_mw5OXvfAs5aw8AM7JmHJ5eQ_cpkeps9DzlUhM-9RWXoRJOLw6wcPpuOJ-w Message-ID: Subject: Re: [PATCH bpf-next 1/2] bpf, parisc: Add support for BPF_SDIV and BPF_SMOD in the parisc64 JIT To: bot+bpf-ci@kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com, deller@gmx.de, James.Bottomley@hansenpartnership.com, bpf@vger.kernel.org, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, visitorckw@gmail.com, martin.lau@kernel.org, yonghong.song@linux.dev, clm@meta.com, ihor.solodrai@linux.dev Content-Type: text/plain; charset="UTF-8" On Fri, Jul 17, 2026 at 19:16 UTC, sashiko-bot@kernel.org wrote: > [High] The patch implements BPF_SDIV and BPF_SMOD for the 64-bit > PA-RISC JIT but omits the 32-bit JIT, causing signed divisions to be > silently miscompiled as unsigned. This is a 2-patch series, and patch 2/2 ("bpf, parisc: Add support for BPF_SDIV and BPF_SMOD in the parisc32 JIT") is the one that modifies bpf_jit_comp32.c. It threads is_signed = (insn->off == 1) through emit_alu_r32()/emit_alu_r64() and uses the $$divI/$$remI signed millicode (ALU32) and the hppa_sdiv64()/hppa_sdiv64_rem() helpers (ALU64) on the signed path instead of $$divU/$$remU/hppa_div64(). Patch 1/2 adds those shared helpers in bpf_jit_core.c, which is why it does not touch bpf_jit_comp32.c. With both patches applied the parisc32 JIT returns the signed result the verifier and interpreter compute; the ALU32/ALU64 SDIV/SMOD test_bpf cases pass. Nicholas