From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEC8B331230 for ; Fri, 17 Jul 2026 08:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.160.170 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784278596; cv=pass; b=mwYugZy/bScbdQY2MvXDWX8+MKUGJg8hCDM72s3cefB5S0MtWoKMGVWEeaEOeXp9CGJEl8bK5sb0h6WVCQoleZYMgrS6Owma4Sd01FQcv0/m2IMTryGSGuMl05regaEMC0UqOerclWOYQr0Vn8qI+6PkHsVmjNSAvYcJwQrNQ78= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784278596; c=relaxed/simple; bh=DiOnusxEQLtTiYWWGUCZdXu8RBl5ajSqJtBR9WFr32A=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=C4mG8yUDoQg4yC7pP2l6hj4e2tueQkAohr9stbWJyARneJz05clrRgJ3iIX9T1xo0DlcyoRuK8LBy4LlLDIBQ5K2dMoVeAWu6yY2FEdc4LZDHBcZgLr6W9Z0L8rN2GNzIef0nKWFbBgmlPrXDXrCA7OBvN6VlVrEGLlz1MswAEo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=szeredi.hu; spf=pass smtp.mailfrom=szeredi.hu; dkim=pass (1024-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b=Elav5zOU; arc=pass smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=szeredi.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=szeredi.hu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b="Elav5zOU" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-51c2a818fc4so62767141cf.2 for ; Fri, 17 Jul 2026 01:56:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1784278592; cv=none; d=google.com; s=arc-20260327; b=OhLjyH/GfCtfzRth4IXIvlWaZNNAssenLmxr2tehdxAOWlYUS7PfO5G4DEOe8LPLAY ftzSR91yq5yml+EC9SquIsiviRpveEON/tvcyIwItfwxSXKAhv4mpYBre0sNYj6o8dCT kvvDU0kJfPbwiQGG1dgNiVq/0YJq7PxlfmjK8Cf1679GDQGnyeJ+Vct3z2UGjjSoOPOj WwG/wqFstjvviotH9jxrftBMx75v3WP4oME9O4ln5xYyLyKomDL8zi7IhwXGD0IqLSj2 P0wqZJ3g3YAkoxmROOe3LRFuDD4yiguCIfE+UXG528r7ORFfqJpzsDtikVK8QbiWgzOW d7Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=+qrDm2HKWMzXxqOdrcl7BD6yjvjHMYMS5+TqLdn0I2Q=; fh=rv85HwCsNHnVbLnP2fXOSUXwHmWVN6hMGkCcwrfNdsg=; b=SKEBoPh3xXIct6GrcwNO6dhYMKBo6qYmbvQ0QIaFk2KfIibBe10qornC/ziTxbRSpE kvvNcM1LmPMKuccDkjIo61mzm+Suq48jvc4AaNJfhLEok1RbB7ZRnpwo2QhnQCfCkkcq 3KnLn6AEycVbf+IxhjRFA+O7+cnZwRpJEzP3qMkeRhg0zAW+T3woldp2UEfEBJF4bDj+ zqw+bfRpm6GsRA89VFBjZXwCVQW6rasKidGkSqZfk3u39YRP5CDqWDKH9p+cQgkJmw7d UFKm0WMJzTS67vdMGqcnpzjwq1CHYgh3PnTnoYAKwSaK84BY7SPE4pob7RQvnBL6OSYr nBog==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; t=1784278592; x=1784883392; darn=vger.kernel.org; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+qrDm2HKWMzXxqOdrcl7BD6yjvjHMYMS5+TqLdn0I2Q=; b=Elav5zOUT26bCjE0i/9eXLshvuj44Yi1emTj4mmVku2lh29ETVF0kY8StrRkoB4tDN x47AlrKyxcfeY5gB12cDdJhVmx0M6B1FNNXQyQMveyMsncjflIC8pJc6NFe63ceSRz3Y 6OgMtesk6aedC6ygNrlPUY7XOmxq3cGnTz0TA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784278592; x=1784883392; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=+qrDm2HKWMzXxqOdrcl7BD6yjvjHMYMS5+TqLdn0I2Q=; b=Qd0C5oFZY+c98Tr7ILLy/6FKZ/uqgO1mL29MhcBA9wQBSjUOc8srABoeIRVfydoKWz nxFd1tlqqYecrIahff+3nhwG21gPX/hS2Zjj1mEq+tL4+seSzKOpTlB7Di2Bb5iXfSX5 zH9iSK5dQjIkLX6gslDeKijbVl+bcoRCDOP2akLkcTPUvLdN8PZdUlmT31HYHfs0k8Yo qEenkaIq/ANeO/7cRJlMBoh9V5jtMG/eBIvQ3+HGicMcroCmlPQkm5Kc2+DWX4hL8Qa7 CquCUWSvNfkFADuMMBLdoCCtKeIq9WeTFfSRnZ+7jqj17Ai+nIS/F6MasbpIKTezDAPl /DFg== X-Forwarded-Encrypted: i=1; AHgh+RrwsD6vBiwPRTqbPghHYCEgtZ0I6J0nzsayONNimUZFsSJqjmhR6JOhrWo0WIn6Z/wwqJHYzpoY7f9ovH4=@vger.kernel.org X-Gm-Message-State: AOJu0YyDUJex0CeT7l7UZnq8vMo/huS0dP4ztpQFWpH6x+4DNo1l6Y8Q g3XBW3oOLRucg6AE2PYP5Dw814UwMpJUVVSGUgDsca65taM92fj3SSKskkV0GqkCeMp1PpEBD6+ Tpke2MWFJuTljdwoOrS+5rrcFbzD05BDxEW4pG4Wtpw== X-Gm-Gg: AfdE7ckLSsNZYb/59NwpEuiiyu4UtBRMirI4O67sWOcueYghRKm6G4rSpUbQog/bLhO aKrolc+b42QoRwJixEJeTV0NDDtNaXa6IKTC57qoaOotAf7LVVC1lLbBq9XfY81BDDMmgBkCIW1 vujJ5x4xLEWdji0l2Pri4TKwvfBLZwllZrIGVzgo3Th8n1Cxh/zV0zh37cbNbK5+YTX/AIfH5Yg WHeV0n5e5lqHqQWfXFOBAb1JgU1s+KP5Kf8Jdd+RBgjF6aR83HHpJrkjOCOb1BEXcN+BflJTDNH gCNQ9HkCrV2XQVs= X-Received: by 2002:a05:622a:206:b0:517:8f98:aaff with SMTP id d75a77b69052e-5213daa206emr13449681cf.49.1784278592479; Fri, 17 Jul 2026 01:56:32 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260717032835.922433-1-lihaofeng@kylinos.cn> In-Reply-To: <20260717032835.922433-1-lihaofeng@kylinos.cn> From: Miklos Szeredi Date: Fri, 17 Jul 2026 10:56:20 +0200 X-Gm-Features: AUfX_mzASs-EDrh0VB5BZaCBvD9fFJ2-S-mmpIaqZwvl7JdqsRLojMHJfiB55QU Message-ID: Subject: Re: [PATCH v2] fuse: honor desc offset in readahead reads To: Haofeng Li Cc: joannelkoong@gmail.com, fuse-devel@lists.linux.dev, linux-kernel@vger.kernel.org, djwong@kernel.org, brauner@kernel.org Content-Type: text/plain; charset="UTF-8" On Fri, 17 Jul 2026 at 05:28, Haofeng Li wrote: > > fuse_handle_readahead records non-zero descs[].offset when > iomap skips leading uptodate blocks in a folio, but > fuse_send_readpages built FUSE_READ from folio_pos() alone. > The reply was still copied at descs[0].offset, so wrong > file data was placed into the page cache. > > Add descs[0].offset to the request position. Apply the > same correction in fuse_short_read for EOF size updates. > > Fixes: 4ea907108a5c ("fuse: use iomap for readahead") > Signed-off-by: Haofeng Li > Reviewed-by: Joanne Koong Sashiko founds some more cases: https://sashiko.dev/#/patchset/20260717032835.922433-1-lihaofeng%40kylinos.cn This is a large folio issue, right? I do wonder why fsx-linux missed these with the large folios enabled. Thanks, Miklos