mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: majianpeng <majianpeng@gmail.com>
Cc: fuse-devel <fuse-devel@lists.sourceforge.net>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fuse: Consider the ->big_writes for allocing fuse_req when do writing
Date: Thu, 2 May 2013 17:05:25 +0200	[thread overview]
Message-ID: <CAJfpegvYY_fUMOA_CE1vg849Jga_iSvaswVs2Fb6EUJPH2f0uw@mail.gmail.com> (raw)
In-Reply-To: <51525328.2070407@gmail.com>

On Wed, Mar 27, 2013 at 3:02 AM, majianpeng <majianpeng@gmail.com> wrote:
> If fc->big_writes == 0, for write-operation it only do 4k in func fuse_fill_write_pages.
> So when alloc fuse_req,we should consider this restrict in order to
> do additional operations.
> The additional operations are memset-opeartion in func fuse_requenst_alloc and alloc more space if nr_pages is larger than FUSE_REQ_MIN_PAGES.

Your mailer is removing whitespace from the patch.   Anyway, I applied
it by hand, thanks.

Miklos

>
> Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
> ---
> fs/fuse/file.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 34b80ba..c584a31 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -912,8 +912,13 @@ static ssize_t fuse_perform_write(struct file *file,
> do {
> struct fuse_req *req;
> ssize_t count;
> - unsigned nr_pages = fuse_wr_pages(pos, iov_iter_count(ii));
> + unsigned nr_pages;
>
> + if (!fc->big_writes)
> + nr_pages = 1;
> + else
> + nr_pages = fuse_wr_pages(pos, iov_iter_count(ii));
> +
> req = fuse_get_req(fc, nr_pages);
> if (IS_ERR(req)) {
> err = PTR_ERR(req);
> --
> 1.8.2.rc2.4.g7799588
>

      reply	other threads:[~2013-05-02 15:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27  2:02 majianpeng
2013-05-02 15:05 ` Miklos Szeredi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJfpegvYY_fUMOA_CE1vg849Jga_iSvaswVs2Fb6EUJPH2f0uw@mail.gmail.com \
    --to=miklos@szeredi.hu \
    --cc=fuse-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=majianpeng@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®