From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65B3732571A for ; Tue, 18 Nov 2025 09:39:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763458777; cv=none; b=hNB/p0tGhkP0xlKAOtu5k4ZZjeeex6rk2vcZB76CWKqj7N1UST5gbGI8FvS9bqCoqqAPhWrJgZfk6DREa95oRbfl5VwZt2py7odEoLknx7fAOIcWO5DbWu5287OzcQx63FvbIU+eHm/MVtJ7ayqlzNwCrHGiGFjMptvnjOMjQns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763458777; c=relaxed/simple; bh=eKii84sZuCbOZehtCFe2VL91rbzXbwWcUtpf6P1gXt0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=fEZkPO2upHMs71ZuF36D7eWLVpmdy5P33WVenEWEgoSVdXRDJouwzT74AT2mgJmb9j9qO02VmQlUhadI0Ncn2iQGmQJ1JsD+K9utLryt122nj6iM+mAPOiWRS9Rs39gV1g26vLIRWLmWG0qjPlBAInqC8EvwLWPYmcJnJFV+2O8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Mk5Kj9WW; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Mk5Kj9WW" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-88056cab4eeso40777686d6.2 for ; Tue, 18 Nov 2025 01:39:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763458774; x=1764063574; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MKAxePNU4fTqri5FLR+p3cyVn/rDtl58Kp5Sn3kdFVs=; b=Mk5Kj9WWwYAEtCFjONZuX+Ik7QWZL+zunAPARL+zyltr2MaizM8710J309CL15dAz6 AHVklcHJeoFPaIRt4XuYrN4/1xwxeE84ablopa+nzQNPtZJ+LBTlcdbvfSrzNQaX8Lr0 fXulTg6Lqf5eMzxpiQ3fNwwbnOky+mt12gGXFsjd+y8mWav6QZ/LsEVR1NQ1VMve+FKV ttMlKslZ6Vkar+a63fJjvUNTHzAOISY1H5H3glp+QsHfuWgp2OuiyR7dC41x1hLXJMkt c3+OsQ3sRav/8C1w676nbwoAVkwf5VMCSFOGMd4XQiEBjsUvsoB73Vq6Dg3f5UR7zdtO nMpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763458774; x=1764063574; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MKAxePNU4fTqri5FLR+p3cyVn/rDtl58Kp5Sn3kdFVs=; b=ukviQNW6QaaZiqPUWP4OfoMxEn5+Bx2/E9IQHRoJ8jmzKvi1wTdolohXTXlz5/XX1V diygE1BN7M/8Su8oeFhG2grn3jJ78LGIx3W9Uq2wtlzKdjcyoAmQWrRDJ/PHewsUKiCs WMKfhPcwf7fR+wqIWmDYid9WTYm/RZ/LAyrIhoiWESJfz5WZMDAaszDkb4Cpm2AudNta 2HBGMbqOA+hQnx0F3wzU26bPLlEojM0PgEFHIoXQ3nao79i8cN+Fa5fgAAQS/GKKs2jP NxPs8v0JLVmC5sswwhoJaM5TlZNhFo+/f4iAtt75JMIaJfozFOdY4nFgxmmFHFjmeKku TYsw== X-Gm-Message-State: AOJu0Yx7NUWhKIxuBet2l3YcX1FUhCqAfn1dbHj5rIUI6WymiceaGC1N ntUeIIfcBRdBEuULvmq6lenQTUDdGTyL0XN0tAVszOdc1TRKYMqMgHIlqVjEBgAOg2xb3XtwNWN 06PKla9c+868MQpfgN2f0drUjvxyzZqGhFxbNIfW4MQ== X-Gm-Gg: ASbGncve+TZYpQpVDS4l+sZC7xUdhK3VIRfVOxsXlHaI/WAY9AQSFOQe70ww6InG94Q 1nD3hpFGlEO+FSd+yPfgOY+oU6ZVFBVrEk3zxTkyR76NKnBXKBL0TkCAN5JFKiNxbTliVGaL5wm Vq52SH9pdYAtRlb2TFuxGwuw1jVoI2fjUPKA37h7IBi2S1e5AZUOlvXTQ0WN2dOj7/BDZnAknHL gtvdF3Cn7FYKQ466z8XfROGVE4OT0YcaVOtrcNHfKNJhhNud/+p0Cuy6mCNyVT11UXxq5yI+LUj 1Ki+zPfdFUG07WJKBgp+Vyn8YWLPnLEw/bji X-Google-Smtp-Source: AGHT+IEbTb5LG2MsHR55qG2AWmDx6IWmEA4Wa+6vuuh9pVWxXnlntZoSpeYByVRMkxkDTTlPajbKAb29/opUM2l79lc= X-Received: by 2002:a05:6214:21e2:b0:880:4fff:7c5 with SMTP id 6a1803df08f44-88292686b89mr224821286d6.41.1763458774070; Tue, 18 Nov 2025 01:39:34 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251118093832.81920-1-jiangshanlai@gmail.com> In-Reply-To: <20251118093832.81920-1-jiangshanlai@gmail.com> From: Lai Jiangshan Date: Tue, 18 Nov 2025 17:39:22 +0800 X-Gm-Features: AWmQ_bk6EnFiOkE63nhQZSbo2E7C5UmnwbcmVdr7OOXjyvMHDdyM8o-X1fQ2KHo Message-ID: Subject: Re: [PATCH V2] workqueue: Process rescuer work items one-by-one using a positional marker To: linux-kernel@vger.kernel.org Cc: Lai Jiangshan , ying chen , Tejun Heo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello On Tue, Nov 18, 2025 at 5:34=E2=80=AFPM Lai Jiangshan wrote: > --- > Changed from v1: > > Insert the marker and use it purely as iteration marker as Tejun > request. > It is hard to maintain the proper state of it, expecially maintaining > it only in pool->worklist which also requires an unlikely path in the > worker_thread() path. It is hard to maintain the proper state of it if it is treated as a work item as V1, especially maintaining it only in pool->worklist which also requires an unlikely path in the worker_thread() path to defeat the collision requeuing. Thanks Lai > > Add an unlikely path in the worker_thread() path(in assign_work()). > > Add other code in other place to make it not be treated like a work > item. I'm sure all the paths have been covered now, but I still feel > a bit nevous about it for future changes. > > Extra the code to assign work in the rescuer_thread() out as > assign_rescue_work(). > > V1: https://lore.kernel.org/lkml/20251113163426.2950-1-jiangshanlai@gmail= .com/ >