From: Xie He <xie.he.0141@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Krzysztof Halasa <khc@pm.waw.pl>
Subject: Re: [PATCH net-next] net: dlci: Deprecate the DLCI driver (aka the Frame Relay layer)
Date: Sat, 31 Oct 2020 10:24:06 -0700 [thread overview]
Message-ID: <CAJht_EP5njqgcLBq1x_-6BidtgFbfBTYXtM5AgPDLqsMLESA4A@mail.gmail.com> (raw)
In-Reply-To: <20201031095146.5e6945a1@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
On Sat, Oct 31, 2020 at 9:51 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> > > The usual way of getting rid of old code is to move it to staging/
> > > for a few releases then delete it, like Arnd just did with wimax.
> >
> > Oh. OK. But I see "include/linux/if_frad.h" is included in
> > "net/socket.c", and there's still some code in "net/socket.c" related
> > to it. If we move all these files to "staging/", we need to change the
> > "include" line in "net/socket.c" to point to the new location, and we
> > still need to keep a little code in "net/socket.c". So I think if we
> > move it to "staging/", we can't do this in a clean way.
>
> I'd just place that code under appropriate #ifdef CONFIG_ so we don't
> forget to remove it later. It's just the dlci_ioctl_hook, right?
Searching "dlci" (case insensitive) in "net/socket.c", I found there
were 3 areas with "dlci.c" related code. I also found there were 2
macro definitions in "include/uapi/linux/sockios.h".
> Maybe others have better ideas, Arnd?
next prev parent reply other threads:[~2020-10-31 17:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 7:05 Xie He
2020-10-31 3:07 ` Jakub Kicinski
2020-10-31 5:10 ` Xie He
2020-10-31 16:51 ` Jakub Kicinski
2020-10-31 17:24 ` Xie He [this message]
2020-10-31 21:41 ` Arnd Bergmann
2020-10-31 22:03 ` Jakub Kicinski
2020-11-08 5:28 ` Xie He
2020-10-31 23:35 ` Xie He
2020-11-01 10:29 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJht_EP5njqgcLBq1x_-6BidtgFbfBTYXtM5AgPDLqsMLESA4A@mail.gmail.com \
--to=xie.he.0141@gmail.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=gustavoars@kernel.org \
--cc=khc@pm.waw.pl \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®