From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98DCC1F1537 for ; Sat, 4 Jul 2026 00:35:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.128.53 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783125314; cv=pass; b=ZJdxuH7qxgTufzeAldkEc1+nfJ7tzWW+JuJFvHl4jzbmI19fMKH05Qc/0YGFtlxf0S+7Q0aOH+Vv+gF6+9jBhe8QIRxa1Ns+WJ3JxvS85iYLgLt722SghpEjdbYKCFb32HpxQrxUlr5x3qZM3zOnW+/KEgBKhgTL4qhXPamRdm8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783125314; c=relaxed/simple; bh=clrDD96YBt5A3a2Rvc28rREplTx9fw9n1eB41uH1mEU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Lkz41KDr3HKfKi9AbSgbJpySSE92FkxolOrTg2h2LqlOXJum3MN9gicSyr+qCu9aaYrpkk6l6NN3tmeJhEoTsZUQOwHZYUKOG8ezERT+8SeDtMAQlNgr4ql5SHl+ZnhrraSPUrTvytuySOt9tzj75e2le7GA2JVSpz1DzusOA5Y= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pSnUN7Z1; arc=pass smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pSnUN7Z1" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-493ba701891so7655105e9.3 for ; Fri, 03 Jul 2026 17:35:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1783125311; cv=none; d=google.com; s=arc-20260327; b=MZFFhg/212neiBBqUrNUtcn3dNjR/1w+iB97Z6EwnazsANA85IHuPA62kaelcCl4K8 pG+UQBNpb+V5kdBCaVnkGNLYGxpLIPLwpCuN0bnD7qoujF9K2GvkAdnqXsYeI1MgFoQG TSz4jMQa1yJ/Nm734L8ullkkME/DDGLF3QXe0Y3fbgnmuEtsM5kJISCQZ5VWVmaqfFcR b8h4vTkZL+Fsu3phHeH02CbckB0GTkooDoNqW/514kIosXgIbz4sBvesvNcpeEQ38YRv q6sPWOu6PvtVlKw5cizxfiHummrV6S4NTaGIutZEXfEB2uSVIbM0pnGyn9Yz5l7aZJFh yLsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=wW7AlhxqGYiRva1oC552NzvH7YtXs9EvRN6VDKKQkfM=; fh=sU5ZCWL/Y7G6TDdY+G98mh8sW3iJBtMYhKZ6H2tHE54=; b=AJrUv1iXXFJca0aiSaLDTcQz6RKNBO97PuV7SwlM2hTQdhlx5toJnH+WRKFaUhdGbZ WRoNZwpNGP4EudZzdC/G5R+NE5wOrFoAV59VkCI18ZAoKw3bjerbjYCcNlwxTkefxkiR dvai6b75DoviGICUZnMNT3JH37CxkEGpenGiVblLgpFn+LCnTYkuoYu82eJ3c8+kYpjK jQ72Yn81ekAx8ghEhJjsIgjKhz6rZMlcYsibXsFH6wUE4albx4K/cGQ0Z7Mf3VSqdBI9 VWdxUSorSuQdYg9swE+RYYgOPIJZ7wiRRM30QkmIS/maq14EezuhIAdjCI9/um20I/xb iKNA==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783125311; x=1783730111; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=wW7AlhxqGYiRva1oC552NzvH7YtXs9EvRN6VDKKQkfM=; b=pSnUN7Z1IPzl1PUejj1ZbBo/KW7cjP/Q3GRVbjj/54TkXCqh4uwm302JQIauMohZYJ mUvkfiO6qyBMktjaZ5S6UJJQplzNMgNEdHyJ+QXaBmfHm/b6UEl2ggeU/4s8ijZzbc7r asCQw4+mjoUHkjssFZLc5Iw3B00xouaqqStkeNJ71sRQeB+U+WKPB8jo7KX2siGB3yEh MzOIRkvZJmisEPi9wPPdoJ2vmw3Tty+hKT5+3bSXaeiivvZyJtvBQs04+8DiXDwgOXDL JxshMTB8jXxOe1uLdfz/a7cNGFV1DyfkM0D4mXN0NaarvA3V5YNE7/5XOuU2dql4egiC c3Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783125311; x=1783730111; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wW7AlhxqGYiRva1oC552NzvH7YtXs9EvRN6VDKKQkfM=; b=U7cCzymJ0ddgofJlIN3TPbmX0a+uZYyTyR044XVX0BsR1QcI10x7PiOlWSGI67tPW8 Yak+DgQWrjBldESJUmImO/YyXTD55tQwJNMEHEdUDbtnVBC9PJMjP6tRH59EHZjsdzVV cTF1ffKkRjN2iZeDadfdPW03V1U5scR06pzhqgH9G5mczKR9KChUJCjtDr1kNdaPBMXy QSsEzlBYtKXOC2mmuUmecie7QEmeypQZiL+bhoE4cxNfapNKOsPY1pPUgWBGX0FDTWnp W/Qfs1LPSDtyobLCAoVdaLnJ4+qVJN6ee9vysFgBdHhy86hxbtG3xeXD65ikkSC2nS4d ZIug== X-Forwarded-Encrypted: i=1; AFNElJ8G5bT3dNHBiWUMnoGlXZMhOrxfkCLMwY0FyL1ZVLLVYx4sbskYOoNFHK+i6/dwnQsTcG1ZEhD0GlQpFrQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzm1eq8kjx/leVm7NNiGFzUB79JXqY8ADoEwv0y1a21tcpwlVOs rXcK8QzmytkTyKKaLmJ37NsncYYWxdH8vULbXpRTmIjC+vyUUb9APhyK/UpW6Qd5F7+BaJ/xhWe JNDrmvlRKLWHMfMsgd7/pdtUHqatM3EfRwRuP X-Gm-Gg: AfdE7cld+Y6/jX3ufv2Vv3ItAVNOd0R/CY3GnzHHDINjL9RRBlHMU2nfGQp+oyI7E+j lqXCRZuSJiJuubLtd5XSa+WpNo+N496AI4+mJDCAEk73k6T+gZu7UHRl/q4yfTFVY8N/yoR4oD2 Nxi9OuEs9xCl5hIM27fWH2sAOJS84ebj22DcWSkuLSfP7tlxDTvZs09+EUNty8OHwPCLXGjkoLK v8sZFQLddECNeDXqGYNa2ocOGpOHYknsHJSQccq1dQctmYXveIjAgwoTQW2BByeoxMtAzblfMGW 151GTaMuLj5Xg3xKwOTSvFak05XKXc6tX+wDGIuz2R+WgMHq/aDj X-Received: by 2002:a05:600c:5250:b0:493:bb0:3b43 with SMTP id 5b1f17b1804b1-493d11cefc8mr15023595e9.2.1783125311110; Fri, 03 Jul 2026 17:35:11 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260701000949.1666714-1-joannelkoong@gmail.com> <20260701000949.1666714-19-joannelkoong@gmail.com> <20260702192658.GN9392@frogsfrogsfrogs> <20260703020020.GS9392@frogsfrogsfrogs> <20260703124331.GA26440@lst.de> <20260703161147.GB9407@frogsfrogsfrogs> In-Reply-To: <20260703161147.GB9407@frogsfrogsfrogs> From: Joanne Koong Date: Fri, 3 Jul 2026 17:34:59 -0700 X-Gm-Features: AVVi8Cc9z61uFW2rqHr93JegF3VWx93elWcFHjnHavv8xxM4AtcZoZcVqoAB6DI Message-ID: Subject: Re: [PATCH v2 18/18] Documentation: iomap: update docs to reflect iomap_next model To: "Darrick J. Wong" Cc: Christoph Hellwig , brauner@kernel.org, willy@infradead.org, hsiangkao@linux.alibaba.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, Jonathan Corbet , Shuah Khan , "open list:DOCUMENTATION" , open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jul 3, 2026 at 9:11=E2=80=AFAM Darrick J. Wong = wrote: > > On Fri, Jul 03, 2026 at 02:43:31PM +0200, Christoph Hellwig wrote: > > On Thu, Jul 02, 2026 at 07:00:20PM -0700, Darrick J. Wong wrote: > > > The ->begin method can still set iomap::private and the ->end method = can > > > dispose of it, right? Oh, wait, no, that doesn't work because you're > > > talking about ->begin/->end passing something to the next ->begin. > > > > Should we move ->private from struct iomap to struct iomap_iter? > > That'll deal with the constness and the fact that private data > > really is a per-operation thing. I'm not sure I understand. Doesn't struct iomap_iter already have a private field that holds caller-supplied per-operation context? afaics, the users of iomap->private (gfs2, ntfs3, fuse-dax) do use it for per-mapping data and release it in the same iteration. > > I dunno -- towards the end of the fuse-iomap development work I actually > had started using iomap.private to store per-mapping private data. But > that work is dead now, so that's not a strong argument. > > > That also reminds me that now that we actually still keep the low-level > > begin/end ops we need to switch them to a calling convention that > > passes the iter instead of the ugly container_of. This is something > > I wanted deferred until we get the iter conversion, but it turns out > > that now leaves them untouched.. That's a good point. Do you think it'd be better to include those changes as part of this series or do that as a separate follow-up series that targets the same merge window timeline as this one? > > Oh, you mean changing the signature to: > > typedef int (iomap_begin_fn)(struct iomap_iter *iter...); > > instead of passing parts of the iter as separate arguments? > Yeah, that would be nice. Agreed. Thanks, Joanne