From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752477AbdFQAw4 (ORCPT ); Fri, 16 Jun 2017 20:52:56 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:33636 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752096AbdFQAwz (ORCPT ); Fri, 16 Jun 2017 20:52:55 -0400 MIME-Version: 1.0 In-Reply-To: <6542869.y10POnRxLl@aspire.rjw.lan> References: <1496889556-17923-1-git-send-email-lenb@kernel.org> <1ecfadf4193fbd8873d4bcda9e9faec5825bcafb.1496889051.git.len.brown@intel.com> <6542869.y10POnRxLl@aspire.rjw.lan> From: Len Brown Date: Fri, 16 Jun 2017 20:52:53 -0400 X-Google-Sender-Auth: P_IkrfPaAKBfXFdRXBPH60nEOEk Message-ID: Subject: Re: [PATCH 4/5] intel_pstate: skip scheduler hook when in "performance" mode. To: "Rafael J. Wysocki" Cc: Srinivas Pandruvada , X86 ML , "H. Peter Anvin" , Peter Zijlstra , "Rafael J. Wysocki" , Linux PM list , "linux-kernel@vger.kernel.org" , Len Brown Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 16, 2017 at 8:04 PM, Rafael J. Wysocki wrote: > On Wednesday, June 07, 2017 07:39:15 PM Len Brown wrote: >> From: Len Brown >> >> When the governor is set to "performance", intel_pstate does not >> need the scheduler hook for doing any calculations. Under these >> conditions, its only purpose is to continue to maintain >> cpufreq/scaling_cur_freq. >> >> But the cpufreq/scaling_cur_freq sysfs attribute is now provided by >> the x86 cpufreq core on all modern x86 systems, including >> all systems supported by the intel_pstate driver. >> >> So in "performance" governor mode, the scheduler hook can be skipped. >> This applies to both in Software and Hardware P-state control modes. >> >> Suggested-by: Srinivas Pandruvada >> Signed-off-by: Len Brown >> --- >> drivers/cpufreq/intel_pstate.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c >> index 5d67780..0ff3a4b 100644 >> --- a/drivers/cpufreq/intel_pstate.c >> +++ b/drivers/cpufreq/intel_pstate.c >> @@ -2025,10 +2025,10 @@ static int intel_pstate_set_policy(struct cpufreq_policy *policy) >> */ >> intel_pstate_clear_update_util_hook(policy->cpu); > > The statement above shouldn't be necessary any more after the change below. The policy can change at run time form something other than performance to performance, so we want to clear the hook in that case, no? >> intel_pstate_max_within_limits(cpu); >> + } else { >> + intel_pstate_set_update_util_hook(policy->cpu); >> } >> >> - intel_pstate_set_update_util_hook(policy->cpu); >> - >> if (hwp_active) >> intel_pstate_hwp_set(policy->cpu); >> > > What about update_turbo_pstate()? > > In theory MSR_IA32_MISC_ENABLE_TURBO_DISABLE can be set at any time, so > wouldn't that become problematic after this change? yes, the sysfs "no_turbo" attribute can be modified at any time, invoking update_turbo_state(), which will update MSR_IA32_MISC_ENABLE_TURBO_DISABLE But how is the presence or change in turbo related to the lack of a need to hook the scheduler callback in "performance" mode? The hook literally does nothing in this case, except consume cycles, no? -- Len Brown, Intel Open Source Technology Center