From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24BB5C2BA19 for ; Mon, 13 Apr 2020 16:05:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E83222063A for ; Mon, 13 Apr 2020 16:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586793934; bh=GuHQ5AOajO2wFlsVNY9STmYJGaGPlWLnXWrZNU2kR2o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=XATiX2iDsBO8wlglWO46WynJFSqIEzhbOEfqilqIxEzSMGzw3ywyExPjYpb8cSpQm i6wejMP75knosUD883ZggnTzHfwC18xTaxzTPH/O86kkwJp1q7P6ouwjLzTxLjy1se nGK284zpHqvPTes5DiFyFtFjM5+jOeJhs3fX0RH8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731240AbgDMQFc (ORCPT ); Mon, 13 Apr 2020 12:05:32 -0400 Received: from conssluserg-04.nifty.com ([210.131.2.83]:57608 "EHLO conssluserg-04.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731231AbgDMQFa (ORCPT ); Mon, 13 Apr 2020 12:05:30 -0400 Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) (authenticated) by conssluserg-04.nifty.com with ESMTP id 03DG503n017830; Tue, 14 Apr 2020 01:05:01 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com 03DG503n017830 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1586793901; bh=qdBXTtVXlmfInBglCB4Rk784hZBIzdkmk2OHy9zWc0E=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZBtq4Uel4kvwvLuoqKV+DGfHfwfnHwwgPnYDE1Bc5lDZTmlEsBGBdYtP0cd5fCbjA Y+TRGr0ItNJgqw0IhBwWr39BoBFUxxNUI92XxtuBDUoOvSZkSVucpj34lDVPPG244S iaO91hqJA99D5AzX7BXUce5oGIZvQ/MO8HEGWoMg0dr/Vb8ZovnT7l+hnM/bsPHsol hPSdpNhwVwKgndNp5AK1Mtpm590qtscdgmzdALJW27i2uS/x+LZw7iPm6le/zgD8vp m9IVrAnGx5uDESlnI4sOdqUmyHDqMMf9vgx9JGcewXUdoOoJ5IhCNJqkoFGCNyPsrs uxUJKUTj515xQ== X-Nifty-SrcIP: [209.85.217.45] Received: by mail-vs1-f45.google.com with SMTP id h189so5667936vsc.13; Mon, 13 Apr 2020 09:05:01 -0700 (PDT) X-Gm-Message-State: AGi0PuaNqwV6AEewigYB0STXYMTJqzh3aX4U0116B0VttHe75PK1u/4W nPWBXAV6WGBDRMoYXqWJ99Yy9jyNtyIxcsLm7BA= X-Google-Smtp-Source: APiQypL4dw2znwNWubmbI3gALnJloVgNJyOQijQgQpbjdpbED+7UPbrhQzZ1L78areRXcF3hBEv+ZsbVQTNcvMp405w= X-Received: by 2002:a67:fa11:: with SMTP id i17mr13152238vsq.155.1586793900135; Mon, 13 Apr 2020 09:05:00 -0700 (PDT) MIME-Version: 1.0 References: <20200413014743.16353-1-masahiroy@kernel.org> In-Reply-To: From: Masahiro Yamada Date: Tue, 14 Apr 2020 01:04:23 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] sh: fix build error in mm/init.c To: Logan Gunthorpe Cc: Andrew Morton , Yoshinori Sato , Rich Felker , Linux-sh list , Linux Kernel Mailing List , Dan Williams , David Hildenbrand , Michal Hocko , Mike Rapoport , Oscar Salvador , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 14, 2020 at 12:43 AM Logan Gunthorpe wrote: > > > > On 2020-04-12 7:47 p.m., Masahiro Yamada wrote: > > The closing parenthesis is missing. > > > > Fixes: bfeb022f8fe4 ("mm/memory_hotplug: add pgprot_t to mhp_params") > > Signed-off-by: Masahiro Yamada > > --- > > Oh, oops, I thought I compile checked all the arches. Must have been a > last minute change. I'm also surprised the kbuild robot didn't catch this. > > Reviewed-by: Logan Gunthorpe > > Andrew, can this be squashed into the existing patch? The offending commit is already in Linus' tree. I was also surprised that no bot or human complained about this breakage before it was merged. -- Best Regards Masahiro Yamada